Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IndiegogoBridge] New Bridge #2135

Merged
merged 2 commits into from
Jul 27, 2021
Merged

[IndiegogoBridge] New Bridge #2135

merged 2 commits into from
Jul 27, 2021

Conversation

Bockiii
Copy link
Contributor

@Bockiii Bockiii commented May 29, 2021

Solves #2130

@Bockiii Bockiii force-pushed the indiegogo branch 4 times, most recently from 4caffd2 to 45e91b6 Compare May 29, 2021 13:27
@Bockiii
Copy link
Contributor Author

Bockiii commented May 29, 2021

All checks fixed, should be mergeable.

Copy link
Contributor

@VerifiedJoseph VerifiedJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding the timing parameter to each context (All Categories, Tech & Innovation, etc) you can put it in a global context and it will be applied to all contexts for you.

https://github.com/RSS-Bridge/rss-bridge/wiki/const-PARAMETERS#level-1---context

Add the following to PARAMETERS array:

		'global' => array(
			'timing' => array(
				'name' => 'Project Timing',
				'type' => 'list',
				'values' => array(
					'All' => 'all',
					'Launching Soon' => 'launching_soon',
					'Just Launched' => 'just_launched',
					'Ending Soon' => 'ending_soon',
				),
			),
		), 

bridges/IndiegogoBridge.php Show resolved Hide resolved
bridges/IndiegogoBridge.php Outdated Show resolved Hide resolved
bridges/IndiegogoBridge.php Outdated Show resolved Hide resolved
bridges/IndiegogoBridge.php Outdated Show resolved Hide resolved
bridges/IndiegogoBridge.php Outdated Show resolved Hide resolved
@Bockiii
Copy link
Contributor Author

Bockiii commented May 30, 2021

I'll test and rework the commits, but thanks for the contribution! didnt see the global thingy

@Bockiii
Copy link
Contributor Author

Bockiii commented May 30, 2021

I needed to rework the "All Categories" section. It seems like there is no way to have a section that is only filled with the 'global' parameters.

So we should look into that. Maybe just adding a type "Label" to display a text or so. To work around that for now, I just added a prechecked-checkbox.

@em92
Copy link
Contributor

em92 commented May 30, 2021

What is "All categories" checkbox for? Section "All categories" and checkbox "All categories" are confusing.

@Bockiii
Copy link
Contributor Author

Bockiii commented May 30, 2021

Its just there as a placeholder because I dont know how else to solve it:

See my note from before. I dont know how I could add a section called "All Categories" that includes only a global filter. I tried an empty array but that leads to funky behaviour. My workaround would be an entry of type "label" or so to just display a text. So if you have another solution.. go :)

@Bockiii
Copy link
Contributor Author

Bockiii commented May 31, 2021

Forget that. Found a solution in another bridge. It seems like I just had a formatting error before. It works now.

@Bockiii
Copy link
Contributor Author

Bockiii commented Jul 24, 2021

@em92 ?

@em92 em92 merged commit bf1cb8f into RSS-Bridge:master Jul 27, 2021
@em92
Copy link
Contributor

em92 commented Jul 27, 2021

gj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants