Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NYTBridge] Fix article parsing (fix #1930) #2106

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

corenting
Copy link
Contributor

Commit a reworked version of the fix proposed by @podiki in #1930 :

  • Fix the missing full article content
  • Fix the missing article subtitle
  • Reduce CACHE_TIMEOUT + change collectExpandableDatas from 15 to 40 latest articles to avoid to avoid missing articles.

It is still a bit buggy for the content on some articles (interactive content for example) though, but should work for most articles.

@corenting
Copy link
Contributor Author

@em92 Is it possible to merge this to fix the issue ?

@em92 em92 merged commit 0de2db8 into RSS-Bridge:master Jun 30, 2021
@em92
Copy link
Contributor

em92 commented Jun 30, 2021

gj, Corentin!

@corenting corenting deleted the fix_nyt branch June 30, 2021 11:49
@corenting
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants