Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwitterBridge] Fix username matching to be case insensitive with noretweet option #1924

Merged
merged 2 commits into from
Jan 10, 2021
Merged

[TwitterBridge] Fix username matching to be case insensitive with noretweet option #1924

merged 2 commits into from
Jan 10, 2021

Conversation

drklee3
Copy link
Contributor

@drklee3 drklee3 commented Jan 10, 2021

Makes username comparisons case insensitive with strtolower. This fixes the problem where all tweets are considered as a retweet if the input username is not cased the same as the actual username.

For example: aoc instead of the actual username AOC with no retweets turned on will return empty results.

@em92 em92 merged commit 6b870f0 into RSS-Bridge:master Jan 10, 2021
@em92
Copy link
Contributor

em92 commented Jan 10, 2021

gj @drklee3 !

For example: aoc instead of the actual username AOC with no retweets turned on will return empty results.

This is reproducible if we turn on DEBUG mode, where caching is turned off in most cases. In my case I opened with aoc - it gave empty feed. Then I switched to AOC - it also gave empty feed. Turned on debug mode on my laptop, and it reproduced it there.

@drklee3 drklee3 deleted the drklee3/twitter-case-insensitive branch January 10, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants