Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend UnsplashBridge #1744

Closed
wants to merge 26 commits into from
Closed

extend UnsplashBridge #1744

wants to merge 26 commits into from

Conversation

langfingaz
Copy link
Contributor

Thanks @nel50n for his UnsplashBridge! The commit is mainly based on his work.

As I this new bridge is based on UnsplashBridge.php, I left the MAINTAINER in line 6 to @nel50n . What do you think, shall I change this to me or leave it as is?

Signed-off-by: langfingaz [email protected]

Thanks @nel50n for his UnsplashBridge! This Commit is mainly based on his work.

Signed-off-by: langfingaz <[email protected]>
@langfingaz
Copy link
Contributor Author

In this bridge one can "follow" a username on https://unsplash.com receiving new images.

Here is one example of a running rss-bridge instance with this bridge enabled: https://rss.privacy1st.de/?action=display&bridge=UnsplashUser&u=h4mmiidd&m=20&w=1920&q=75&format=Html

@langfingaz
Copy link
Contributor Author

And I'm not sure, but maybe one could merge this bridge into the already existing UnsplashBridge so that one can select if one would like to get the latest unsplas images or new images from a specific user. Help or ideas on how to do this are welcome!

@em92
Copy link
Contributor

em92 commented Sep 18, 2020

I left the MAINTAINER in line 6 to @nel50n . What do you think, shall I change this to me or leave it as is?

Generally speaking, if you are making new bridge, you should set MAINTAINER to yourself.

And I'm not sure, but maybe one could merge this bridge into the already existing UnsplashBridge

You can add param like "Filter by Username (optional)" or "Username (optional)" and defaultValue = "". Then you can change api source depending if this param is given.

+ filter photo stream for username
+ change image preview quality
+ add link to user, location (if present), link to photo on unsplash to $item['content']

Signed-off-by: langfingaz <[email protected]>
@langfingaz
Copy link
Contributor Author

langfingaz commented Sep 18, 2020

You can add param like "Filter by Username (optional)" or "Username (optional)" and defaultValue = "". Then you can change api source depending if this param is given.

All right, I did some more work on the UnsplashBridge and merged my new UnsplashUserBridge into the already existing UnsplashBridge.

Generally speaking, if you are making new bridge, you should set MAINTAINER to yourself.

And I'm now added as second MAINTAINER.


You can test the modified UnsplashBridge here: https://rss.privacy1st.de

Functionality is now merged into UnsplashBridge
@langfingaz langfingaz changed the title add Bridge: Image feed of Unsplash user extende UnsplashBridge Sep 21, 2020
@langfingaz langfingaz changed the title extende UnsplashBridge extend UnsplashBridge Sep 21, 2020
@em92
Copy link
Contributor

em92 commented Oct 19, 2020

Hi, @langfingaz ! Could you please rebase your PR?

I have recently fixed Travis CI. It runs some tests and linting checks.

theScrabi and others added 20 commits October 21, 2020 14:08
The bridge was taking another article abstract as subtitle for #LeBrief articles
* [TwitterBridge] Optimise regular expression code

Optimise regular expression search code so adding new URLs is cleaner
Fixes multi-page article fetching by adding '&seite=all' to  article URL.
@langfingaz
Copy link
Contributor Author

Well, I'm sorry that I somehow failed rebasing my changes... The master branch of my forked repo is now 26 (and not 3) commits ahead of RSS-Bridge:master.

I created a branch langfingaz/unsplash which is 3 commits ahead of RSS-Bridge:master.
Probably it better to create a new pull request from within that branch and close this pull request to keep it cleaner?

Sorry for the inconvenience.

@em92 em92 closed this Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.