Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EpicgamesBridge] Add pinned posts to list #1736

Merged
merged 2 commits into from
Sep 14, 2020
Merged

[EpicgamesBridge] Add pinned posts to list #1736

merged 2 commits into from
Sep 14, 2020

Conversation

otakuf
Copy link
Contributor

@otakuf otakuf commented Sep 8, 2020

Pinned posts were not included in the list, a separate api request is used for pinned posts. To fix it, we take data from both sources, sort by date, display.

Seen after: #1709 (comment)

Copy link
Contributor

@em92 em92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет @otakuf ! Есть замечания

bridges/EpicgamesBridge.php Outdated Show resolved Hide resolved
bridges/EpicgamesBridge.php Outdated Show resolved Hide resolved
@otakuf
Copy link
Contributor Author

otakuf commented Sep 9, 2020

Заменил метод сортировки на usort. Поправил замечания по выводу ошибки.

@em92 em92 merged commit d299adb into RSS-Bridge:master Sep 14, 2020
@em92
Copy link
Contributor

em92 commented Sep 14, 2020

Круто, @otakuf !

@otakuf otakuf deleted the EpicgamesBridge-add-pinned-posts branch September 15, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants