[request-pull] fix GithubIssueBridgeIssue/1444

[somini]

This is the contents of #1444 , in PR format for easier digestion. I also rebased to the latest master.

All credit to @pmaziere

[TehPeGaSuS]

I'm seeing a weird issue with my instance after replacing the shipped GithubIssueBridge.php with this one..

On Project Issues and enabling Show Issues Comments

InspIRCd feed HTML format display issues from oldest to newest.

Without enabling Show Issues Comments the feed is displayed properly (from newest to oldest).

Other ones that I've tried like KiwiIRC seems to display all properly with or without Show Issues Comments enabled.

Any ideas?

[somini]

Any ideas?

🤷‍♂️ This was merged, so open a new issue if this remains a problem.

[pmaziere]

@somini: being a huge moron with a gigantic ego, I find it utterly uncool that you hijack my nobel price level contribution so that you can take full credits about it ! oh wait…

Joke aside, I'm aware that my way of submitting PR does not go well with the github workflow. A long time ago (#277), @mitsukarenai gently gave me the go to send my git request-pull via the github issues, therefore I kept doing it this way for my annual fix. I'm all ears about a better way to send my contributions, aside from creating a repo on github.

I don't know how @logmanoriginal did it in the past, but he always associated my github handle with the commits he imported from my gitlab repo to the rss-bridge github repo. It would be nice to continue having it this way.

Many thanks to all of you who continue to maintain this really useful piece of code !

[somini]

@somini: being a huge moron with a gigantic ego, I find it utterly uncool that you hijack my nobel price level contribution so that you can take full credits about it ! oh wait…

😁

Joke aside, I'm aware that my way of submitting PR does not go well with the github workflow. A long time ago (#277), @mitsukarenai gently gave me the go to send my git request-pull via the github issues, therefore I kept doing it this way for my annual fix. I'm all ears about a better way to send my contributions, aside from creating a repo on github.

From #1444:

https://framagit.org/peetah/rss-bridge.git/ GithubIssueBridge

On your local repository, add that as another remote:

$ git remote add pmaziere "https://framagit.org/peetah/rss-bridge.git"
$ git fetch pmaziere

After that's done (you can update it with a simple git fetch --all), you get the data on your local repository and you can just merge things locally and push it here.

For example, to create this MR, I did just that, using pmaziere/GithubIssueBridge as a basis to create a new branch.

GitHub will not allow external MR (probably ever), so that's "solved". Gitlab might eventually implement this, but that's on the lowest of the lowest backlog.

I don't know how @logmanoriginal did it in the past, but he always associated my github handle with the commits he imported from my gitlab repo to the rss-bridge github repo. It would be nice to continue having it this way.

If the commit's email is the same on your account here, this is automatic.

---

TLDR: It's fine to open the odd pull requests like this I think. This get unwieldy if many people have external repos, but I don't think we are there yet. I'm happy to serve as go-between if the workload remains minimal. 😃