[DonnonsBridge] Add a new bridge #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teromene
requested changes
Feb 4, 2020
|
Hi @teromene, thanks you for your reply. I added the pattern as asked (see commit c21a304). Donnons.org recently changed their query parameters, so i just fixed what i think is the last error in my bridge with commit 836dc28. I will test my "new version" a few day, and tell you when it's ok to merge my bridge into main project. Have a nice day. |
|
Hi @teromene, all my tests are OK. You can merge my bridge 👍 |
|
Looks great to me ! Thank you for the PR and for the thorough testing ! |
teromene
approved these changes
Feb 10, 2020
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bridge allows french users to scrap pages from https://donnons.org/
I test it since 2 month on my own server and it works nicely.
Before submiting my MR, i checked that my code and commits were following code styling rules.
Any comments or suggestions are very welcome since this is my first "bridge".