Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double XML encoding on Atom feed title #1247

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

somini
Copy link
Contributor

@somini somini commented Jul 31, 2019

This can be seen on the current Dilbert bridge, there's a title named:

Can't Succeed Within The Rules - Dilbert by Scott Adams

This title will disappear tomorrow, a new comic will take its place. :D

@somini
Copy link
Contributor Author

somini commented Jul 31, 2019

@em92
Copy link
Contributor

em92 commented Aug 21, 2019

Nice catch!
Payed attention myself, that Html version does not double quote titles comparing to Atom version.
As example (see Ibb & obb):
html version: https://feed.eugenemolotov.ru/?action=display&bridge=Steam&userid=76561198260599288&only_discount=off&format=Html
atom: https://feed.eugenemolotov.ru/?action=display&bridge=Steam&userid=76561198260599288&only_discount=off&format=Atom
atom but fixed: https://feed.eugenemolotov.ru/dev/?action=display&bridge=Steam&userid=76561198260599288&only_discount=off&format=Atom

@teromene teromene merged commit 48d0385 into RSS-Bridge:master Aug 28, 2019
@teromene
Copy link
Member

Nice catch !

@somini somini deleted the fix/double-encoding branch February 27, 2020 01:30
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants