Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DavesTrailerPageBridge] Add new bridge #1246

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

johnnygroovy
Copy link
Contributor

Adds a bridge for Dave's Trailer, witch simply offers direct links to Apple trailers.

There's probably a more reliable way to fetch item['uri'] for 1080p links, but this is where my programmer talents stops.

Copy link
Member

@teromene teromene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last but not least, we use tabs instead of spaces in the file.
You can fix all of the issues here by running:
phpcbf . --standard=phpcs.xml --extensions=php -p on your code
If you need help, do not hesitate to ask

bridges/DavesTrailerPageBridge.php Outdated Show resolved Hide resolved
bridges/DavesTrailerPageBridge.php Outdated Show resolved Hide resolved
bridges/DavesTrailerPageBridge.php Outdated Show resolved Hide resolved
bridges/DavesTrailerPageBridge.php Outdated Show resolved Hide resolved
bridges/DavesTrailerPageBridge.php Outdated Show resolved Hide resolved
@teromene teromene merged commit c899265 into RSS-Bridge:master Jul 31, 2019
@teromene
Copy link
Member

Thanks for your first PR and welcome here !

@johnnygroovy
Copy link
Contributor Author

Thanks for your help :)

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants