Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LaCentraleBridge] Add new bridge #1201

Merged
merged 6 commits into from
Jul 26, 2019
Merged

Conversation

JackNUMBER
Copy link
Contributor

Hi,
I made a bridge for lacentrale.fr. It's a french website to buy/sell wheeled vehicles.
It was pretty easy, the website has no counter-fraud.

I applied all main filters. For the brand input you can't selected several options, I hope #1199 will be accepted for this.

Test

This search is equal to this settings with the bridge:

?action=display&bridge=LaCentrale&type=moto&brand=SUZUKI&model=GSX-S&versions=&category=&pricemin=&pricemax=8000&location=&distance=&region=FR-IDF&mileagemin=&mileagemax=&yearmin=2018&yearmax=&cubiccapacitymin=750&cubiccapacitymax=750&fuel=&gearbox=&doors=&firsthand=on&seller=&sort=priceAsc&format=Html

Let me know any changes needed.
Thanks for reviewing.

Inputs added: price, location, distance arround location, mileage, year, cubic capacity, first hand, seller profile
Data check: the distance (radius arround a place) needs a place to be useful
@logmanoriginal
Copy link
Contributor

Thanks for the PR. The bridge looks good to me, but Travis is reporting a few issues. Please take a look at the build results: https://travis-ci.org/RSS-Bridge/rss-bridge/jobs/552538624

FILE: /home/travis/build/RSS-Bridge/rss-bridge/bridges/LaCentraleBridge.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 465 | ERROR | [ ] String concat is not required here; use a single string
     |       |     instead
 466 | ERROR | [ ] String concat is not required here; use a single string
     |       |     instead
 472 | ERROR | [x] Space found before semicolon; expected "];" but found "]
     |       |     			;"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

@JackNUMBER
Copy link
Contributor Author

JackNUMBER commented Jul 6, 2019

Thanks for the highlight, I was focused on the red line in the Travis' log and didn't see these errors.
It decreases a bit the readability of the code 😕

Then, it's fixed

@teromene teromene merged commit 52a4f08 into RSS-Bridge:master Jul 26, 2019
@teromene
Copy link
Member

Thanks for the PR ! As for the multiple select, I might take a look

@JackNUMBER JackNUMBER deleted the LaCentrale branch September 4, 2019 13:26
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
* [LaCentraleBridge] Introduce new bridge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants