Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BrutBridge] New bridge #1159

Merged
merged 9 commits into from
Jun 8, 2019
Merged

[BrutBridge] New bridge #1159

merged 9 commits into from
Jun 8, 2019

Conversation

VerifiedJoseph
Copy link
Contributor

A bridge for Brut. Returns the 5 newest videos by category and edition. closes #1092

Copy link
Contributor

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting bridge, thanks for the PR 👍

Find below a few comments for consideration. Please also take a look at the complaints from Travis.

bridges/BrutBridge.php Outdated Show resolved Hide resolved
bridges/BrutBridge.php Outdated Show resolved Hide resolved
bridges/BrutBridge.php Outdated Show resolved Hide resolved
bridges/BrutBridge.php Outdated Show resolved Hide resolved
Move location of item limit check and use code suggested by @logmanoriginal in code review.

#1159 (comment)
Remove whitespace from end of line 81
@logmanoriginal
Copy link
Contributor

Looks good to me. Thanks again for the PR 👍

@logmanoriginal logmanoriginal merged commit f00a054 into RSS-Bridge:master Jun 8, 2019
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
@dvikan
Copy link
Contributor

dvikan commented Jun 5, 2022

@VerifiedJoseph The bridge is currently broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge request for Brut
3 participants