Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Switch Docker Image to official php base image #1140

Merged
merged 2 commits into from
Jun 1, 2019

Conversation

captn3m0
Copy link
Contributor

Switches away from the unofficial Alpine+php image
to the official php-apache image. This has 2 advantages:

  1. Official image is guaranteed to have regular updates etc
  2. The persistent Docker Alpine DNS Issue goes away; DNS Issue gliderlabs/docker-alpine#255

@captn3m0 captn3m0 changed the title Switch Docker Image to official php base image [Docker] Switch Docker Image to official php base image May 24, 2019
@captn3m0
Copy link
Contributor Author

This is testable by running the following:

docker create \
--name=rss-bridge \
--volume </path/to/whitelist.txt>:/app/public/whitelist.txt \
--publish 3000:80 \
captn3m0/rss-bridge:docker-improvements

Switches away from the unofficial Alpine+php image
to the official php-apache image. This has 2 advantages:

1. Official image is guaranteed to have regular updates etc
2. The persistent Docker Alpine DNS Issue goes away; gliderlabs/docker-alpine#255
@logmanoriginal logmanoriginal merged commit 72bcc17 into RSS-Bridge:master Jun 1, 2019
@logmanoriginal
Copy link
Contributor

Thanks for maintaining the Docker configuration 🥇

@logmanoriginal
Copy link
Contributor

I just realized that the image size grew from ~35MB to ~190MB. Do you think that should be addressed?
I don't know if this is considered a "big" image or not.

image

@captn3m0
Copy link
Contributor Author

captn3m0 commented Jun 1, 2019 via email

@captn3m0 captn3m0 deleted the docker-improvements branch June 1, 2019 12:25
@captn3m0
Copy link
Contributor Author

captn3m0 commented Jun 1, 2019

@logmanoriginal Just as a note, this changes the location of whitelist.txt on the container as well. If someone has a a custom list they were using along with this, it needs a slight change in the mount path. Adding the below to the next release CHANGELOG would be helpful:

The base docker image was switched from Alpine to the official PHP image. If you are using the Docker Image, note that the path to mount whitelist.txt has changed from /app/public/whitelist.txt to just /app/whitelist.txt. The wiki has been updated.

@logmanoriginal
Copy link
Contributor

Thanks for updating the Wiki 👍
I added your message to the release notes for the next release.

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
)

* Switch Docker Image to official php base image

Switch from the unofficial Alpine+php image to the official php-apache image.
This has 2 advantages:

1. Official image is guaranteed to have regular updates, etc
2. The persistent Docker Alpine DNS Issue goes away;
gliderlabs/docker-alpine#255

* [Docker] Ignore more files from Docker Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants