[LeMondeInformatique] Handle special articles #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| ); | ||
|
|
||
| //No response header sets the encoding, explicit conversion is needed or subsequent xml_encode() will fail | ||
| $item['content'] = utf8_encode($this->cleanArticle($article_html->find('div.col-primary', 0)->innertext)); | ||
| $item['content'] = utf8_encode($this->cleanArticle($article_html->find('div.col-primary, div.col-sm-9', 0)->innertext)); |
There was a problem hiding this comment.
Travis has problems with the length of this line. It's probably best to split it into multiple like so:
Suggested change
| $item['content'] = utf8_encode($this->cleanArticle($article_html->find('div.col-primary, div.col-sm-9', 0)->innertext)); | |
| $content = $article_html->find('div.col-primary, div.col-sm-9', 0); | |
| $item['content'] = utf8_encode($this->cleanArticle($content->innertext)); |
Fix content extraction for special article compiling previous articles
|
Whoops. Fixed! |
|
Merged. Thanks! |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
Fix content extraction for special article compiling previous articles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix content extraction for special article compiling previous articles (sample)