[MozillaSecurityBridge] Make the URI unique by adding timestamp #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mandatory for some feed reader (Kriss Feed for instance)
Nono-m0le
changed the title
|
Thanks for this PR! This PR is a workaround for the issues discussed in #977 but only works for one bridge. The proposed fix is to introduce a new (optional) parameter to I'll get back to you once it is implemented. Leave this PR open in the mean time. |
if UID is mandatory for RSS-Bridge, the unicity of the URI is also mandatory for some reader (like kriss feed).
|
Hi @logmanoriginal just for me to know, do I need to do anything special for this PR to be approved ? |
|
Thanks @teromene for stepping in. Sorry @Nono-m0le I've been ill the past weeks, so I couldn't merge. |
|
No problem at all, important is the community can now hopefully enjoy it :) |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
'uid' represents the unique id for a feed item. This item is null by default and can be set to any string value. The provided string value is always hashed to sha1 to make it the same length in all cases. References RSS-Bridge#977, RSS-Bridge#1005
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
…Bridge#1005) * added unique UID + URI if UID is mandatory for RSS-Bridge, the unicity of the URI is also mandatory for some reader (like kriss feed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mandatory for some feed reader (Kriss Feed for instance)