refactor: add php autoloader (#2655)

RSS-Bridge · Apr 25, 2022 · 0ef298f · 0ef298f
1 parent b090b17
commit 0ef298f
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 12 deletions.
diff --git a/lib/ActionFactory.php b/lib/ActionFactory.php
@@ -27,8 +27,6 @@ public function create($name) {
 			throw new \Exception('Action ' . $name . ' does not exist!');
 		}
 
-		require_once $filePath;
-
 		$class = $this->buildClassName($name);
 
 		if((new \ReflectionClass($class))->isInstantiable()) {

diff --git a/lib/BridgeFactory.php b/lib/BridgeFactory.php
@@ -68,8 +68,6 @@ public function create($name){
 			throw new \Exception('Bridge file ' . $filePath . ' does not exist!');
 		}
 
-		require_once $filePath;
-
 		if((new \ReflectionClass($name))->isInstantiable()) {
 			return new $name();
 		}

diff --git a/lib/CacheFactory.php b/lib/CacheFactory.php
@@ -54,8 +54,6 @@ public function create($name){
 			throw new \Exception('Cache file ' . $filePath . ' does not exist!');
 		}
 
-		require_once $filePath;
-
 		if((new \ReflectionClass($name))->isInstantiable()) {
 			return new $name();
 		}

diff --git a/lib/FormatFactory.php b/lib/FormatFactory.php
@@ -59,8 +59,6 @@ public function create($name){
 			throw new \Exception('Format file ' . $filePath . ' does not exist!');
 		}
 
-		require_once $pathFormat;
-
 		if((new \ReflectionClass($name))->isInstantiable()) {
 			return new $name();
 		}

diff --git a/lib/rssbridge.php b/lib/rssbridge.php
@@ -88,6 +88,22 @@
 require_once PATH_LIB_VENDOR . 'php-urljoin/src/urljoin.php';
 require_once PATH_LIB_VENDOR . 'simplehtmldom/simple_html_dom.php';
 
+spl_autoload_register(function ($className) {
+	$folders = [
+		__DIR__ . '/../actions/',
+		__DIR__ . '/../bridges/',
+		__DIR__ . '/../caches/',
+		__DIR__ . '/../formats/',
+		__DIR__ . '/../lib/',
+	];
+	foreach ($folders as $folder) {
+		$file = $folder . $className . '.php';
+		if (is_file($file)) {
+			require $file;
+		}
+	}
+});
+
 Configuration::verifyInstallation();
 Configuration::loadConfiguration();
 Authentication::showPromptIfNeeded();
diff --git a/tests/ActionImplementationTest.php b/tests/ActionImplementationTest.php
@@ -48,7 +48,6 @@ public function dataActionsProvider() {
 	}
 
 	private function setAction($path) {
-		require_once $path;
 		$this->class = basename($path, '.php');
 		$this->assertTrue(class_exists($this->class), 'class ' . $this->class . ' doesn\'t exist');
 		$this->obj = new $this->class();

diff --git a/tests/BridgeImplementationTest.php b/tests/BridgeImplementationTest.php
@@ -212,7 +212,6 @@ public function dataBridgesProvider() {
 	}
 
 	private function setBridge($path) {
-		require_once $path;
 		$this->class = basename($path, '.php');
 		$this->assertTrue(class_exists($this->class), 'class ' . $this->class . ' doesn\'t exist');
 		$this->obj = new $this->class();

diff --git a/tests/CacheImplementationTest.php b/tests/CacheImplementationTest.php
@@ -34,7 +34,6 @@ public function dataCachesProvider() {
 	}
 
 	private function setCache($path) {
-		require_once $path;
 		$this->class = basename($path, '.php');
 		$this->assertTrue(class_exists($this->class), 'class ' . $this->class . ' doesn\'t exist');
 	}

diff --git a/tests/FormatImplementationTest.php b/tests/FormatImplementationTest.php
@@ -33,7 +33,6 @@ public function dataFormatsProvider() {
 	}
 
 	private function setFormat($path) {
-		require_once $path;
 		$this->class = basename($path, '.php');
 		$this->assertTrue(class_exists($this->class), 'class ' . $this->class . ' doesn\'t exist');
 		$this->obj = new $this->class();