Skip to content

Commit

Permalink
Fix napi_create*error to match headers not docs
Browse files Browse the repository at this point in the history
  • Loading branch information
RReverser committed Jun 9, 2017
1 parent f319a58 commit dd14063
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions src/exceptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,41 +10,37 @@ import {
lastError,
} from './utils';

function createError(Ctor, msg) {
return new Ctor(UTF8ToString(msg));
}

function setPendingException(exception) {
caughtException(exception);
return Status.Ok();
}

export function napi_create_error(env, msg, result) {
return setValue(result, createError(Error, msg));
return setValue(result, new Error(handles[msg]));
}

export function napi_create_type_error(env, msg, result) {
return setValue(result, createError(TypeError, msg));
return setValue(result, new TypeError(handles[msg]));
}

export function napi_create_range_error(env, msg, result) {
return setValue(result, createError(RangeError, msg));
return setValue(result, new RangeError(handles[msg]));
}

export function napi_throw(env, error) {
return setPendingException(handles[error]);
}

export function napi_throw_error(env, msg) {
return setPendingException(createError(Error, msg));
return setPendingException(new Error(UTF8ToString(msg)));
}

export function napi_throw_type_error(env, msg) {
return setPendingException(createError(TypeError, msg));
return setPendingException(new TypeError(UTF8ToString(msg)));
}

export function napi_throw_range_error(env, msg) {
return setPendingException(createError(RangeError, msg));
return setPendingException(new RangeError(UTF8ToString(msg)));
}

export function napi_is_exception_pending(env, result) {
Expand Down

0 comments on commit dd14063

Please sign in to comment.