Export base directory before loading config file

[LCvanDinteren]

By exporting the base directory before loading config, it is possible to use the base dir within the config file.

[XECDesign]

I suspect shellcheck wouldn't be happy with that and want the assignment and export on separate lines.

[LCvanDinteren]

I suspect shellcheck wouldn't be happy with that and want the assignment and export on separate lines.

This same structure is used for many exports below, which is why I chose to keep in line with those lines.
Do you suggest something like this? :

if [ -z "${BASE_DIR}" ]; then
  BASE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
fi
export BASE_DIR

[XECDesign]

I didn't know about shellcheck when I wrote the first version, so I wouldn't be surprised. Just trying to stick to better practices now.

In most case, an export and assignment on the same line is fine because there's no command substitution. In this case, because the assignment can fail, you'd want to catch that (which doesn't happen if you export on the same line).

I'm not sure the [ -z "${BASE_DIR}" ] would make sense. What would be the use case for setting a BASE_DIR that's outside of build.sh? Has that use case been tested to work with that change or would it also be broken in other ways?

I think if you move the existing BASE_DIR= and export BASE_DIR lines up so that's they're after the root user check, it should be fine.

[LCvanDinteren]

Alright, always a fan of better practices:)

I can't think of any use for defining BASE_DIR outside of build.sh, but figured that as I'm changing it anyway, might as well align it with the rest of the code.

Updated as per your suggestion.

[XECDesign]

Just one last thing. There's a stray export BASE_DIR here

pi-gen/build.sh

Line 183 in 97076ab

export BASE_DIR

[LCvanDinteren]

Nice catch, my bad!

[XECDesign]

Many thanks

[LCvanDinteren]

Many thanks to you as well!