build-docker.sh does not assume PWD=<repo root> #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macisamuele
force-pushed
the
maci-remove-run-directory-assumption
branch
from
171dacf to
2ddd7c1
Compare
|
Thanks |
fuji246
pushed a commit
to lomorage/pi-gen
that referenced
this pull request
Sep 17, 2019
* bash variables in build-docker.sh are wrapped by curly brackets * Ensure presence of config file while running build-docker.sh * Do not assume that build-docker.sh is run from the repository root directory * Mount config file in predictable location in docker container
general-wedge
pushed a commit
to HQapp/hq-os
that referenced
this pull request
Jan 5, 2020
* bash variables in build-docker.sh are wrapped by curly brackets * Ensure presence of config file while running build-docker.sh * Do not assume that build-docker.sh is run from the repository root directory * Mount config file in predictable location in docker container
alexgg
pushed a commit
to balena-os/pi-gen
that referenced
this pull request
Jul 12, 2021
* bash variables in build-docker.sh are wrapped by curly brackets * Ensure presence of config file while running build-docker.sh * Do not assume that build-docker.sh is run from the repository root directory * Mount config file in predictable location in docker container
UmeshMohan-Dozee
pushed a commit
to DozeeRnD/pi-gen
that referenced
this pull request
Sep 18, 2024
* bash variables in build-docker.sh are wrapped by curly brackets * Ensure presence of config file while running build-docker.sh * Do not assume that build-docker.sh is run from the repository root directory * Mount config file in predictable location in docker container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build-docker.shscript should not assume that is executed from the repository root especially as the assumption is only used to build the docker-container.Allowing the script to "auto-determine" its directory allows users to create configurations on their desired directories and then run something like
bash ${RPi-Distro/pi-gen/build-docker.sh} -c config.