Fix build.sh to run dependencies_check prior to using curl. #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
fuji246
pushed a commit
to lomorage/pi-gen
that referenced
this pull request
Sep 17, 2019
general-wedge
pushed a commit
to HQapp/hq-os
that referenced
this pull request
Jan 5, 2020
alexgg
pushed a commit
to balena-os/pi-gen
that referenced
this pull request
Jul 12, 2021
UmeshMohan-Dozee
pushed a commit
to DozeeRnD/pi-gen
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
${APT_PROXY}is set, then the build script usescurlto see if it can connect to it.Currently, if curl is not installed, then the script bombs out such as:
Of course, the reason the server couldn't be reached is because curl isn't installed - not due to any network issue.
This pull request simply moves the
dependencies_checkcall prior to the use of curl. This way if curl is not installed, then the script exits gracefully with the instructions to install curl.I believe this is a low priority fix. For most users, this will be a cosmetic change, since they'd be able to interpret the error sequence anyway.