Transformers 4.52 fix #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly set to None Signed-off-by: Gregory Shtrasberg <[email protected]>
gshtras
requested review from
charlifu,
hongxiayang,
maleksan85,
mawong-amd,
shajrawi and
sunway513
as code owners
gshtras
changed the title
shajrawi
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vllm-project#18432
Starting from transformers == 4.52.0 due to the huggingface/transformers@6f4058a#diff-e3f568ba34f66657a90b8e138028e69f5ce07050f549d45bd7c4ffc8a5a0b3a4L175 change (and others similar) it is no longer possible to use a fallback value for getattr, because head_dim is explicitly set to None