Make CAR ROCm 6.1 compatible. #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iotamudelta
commented
Aug 14, 2024
iotamudelta
commented
- remove scoping
- while there fix a typo
- while there remove unused variable
* remove scoping * while there fix a typo * while there remove unused variable
gshtras
approved these changes
Aug 14, 2024
|
Do we have any performance uplift numbers wrt the previous implementation of CAR? |
gshtras
added a commit
that referenced
this pull request
Aug 15, 2024
* Per @iotamudelta suggestion until the deadlocks issue is better understood Revert "Make CAR ROCm 6.1 compatible. (#137)" This reverts commit 4d2dda6. * Per @iotamudelta suggestion until the deadlocks issue is better understood Revert "Optimize custom all reduce (#130)" This reverts commit 636ff01.
kkHuang-amd
pushed a commit
that referenced
this pull request
Aug 23, 2024
* remove scoping * while there fix a typo * while there remove unused variable
sogalin
pushed a commit
to sogalin/vllm
that referenced
this pull request
Sep 3, 2024
* remove scoping * while there fix a typo * while there remove unused variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.