Fixed single GPU issue without setting up mp. Added toggles for server request batching parameters #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r request batching parameters
mawong-amd
approved these changes
Aug 2, 2024
| logger.info("No unfinished requests. Waiting...") | ||
| (request_id, prompt, sampling_params) = self.input_queue.get() | ||
| if self.need_restart: | ||
| if self.need_restart and isinstance( |
There was a problem hiding this comment.
Would suggest syncing this logic with line 101, or at least a comment clarifying that need_restart is produced but not consumed in the single-GPU GPUExecutor case.
Collaborator
Author
There was a problem hiding this comment.
Not having the if isinstance where this value is set is a micro-optimization :p
There was a problem hiding this comment.
Comments have no performance impact 😼 Will leave this convo up in the event some confused person noses around this part of the code.
gshtras
added a commit
that referenced
this pull request
Aug 13, 2024
…r request batching parameters (#114) * Fixed single GPU issue without setting up mp. Added toggles for server request batching parameters * Adding HTTP headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue where a method from multiprocess gpu executor was being called on a regular gpu executor
Additional toggles to tweak the sync openai server request batching to not have the decode interrupted by prefill too often