Repository navigation
Conversation
This was referenced Sep 21, 2026
jithunnair-amd
approved these changes
Sep 21, 2026
ethanwee1
marked this pull request as ready for review
September 22, 2026 16:11
This was referenced Sep 22, 2026
Author
|
Dependent pin updates are open for ROCm/pytorch release/2.12 (triton-lang#3676), release/2.13 (triton-lang#3678), and release/2.14 (triton-lang#3677). |
This was referenced Sep 22, 2026
|
@zhanglx13 Can you help assess if these failures are legit? We need to bump 3.8 branch to support python3.15. |
Author
|
I confirmed with @zhanglx13 and we do not have to pass CI to merge the PR |
|
I don't seem to have merge powers here |
zhanglx13
approved these changes
Oct 5, 2026
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Oct 5, 2026
## Problem PyTorch release/2.13 pins Triton metadata that rejects Python 3.15 wheels. ## Changes - Pin ROCm/triton commit `66b3f9ff575eb8db6adec658bbf0badd9a8d2e25`, merged through ROCm/triton#971. - Use its Python 3.15 metadata and AST compatibility fixes. ## Validation - Confirmed the pinned commit exists on ROCm/triton and is the merge result of ROCm/triton#971. - `git diff --check` passed. - Fresh cp315 proofs passed on [Linux](https://github.com/ROCm/TheRock/actions/runs/37349913799) and [Windows](https://github.com/ROCm/TheRock/actions/runs/37349914243). - Earlier cp315 proofs using the same fix passed on [Linux](https://github.com/ROCm/TheRock/actions/runs/35757615112/job/106847430092) and [Windows](https://github.com/ROCm/TheRock/actions/runs/35776564974). TheRock release enablement: ROCm/TheRock#8394. Tracked in AIPYTORCH-1241.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Triton 3.8 builds on Python 3.15, but its wheel metadata rejects installation. Its annotated-default AST construction is also invalid on Python 3.15.
Changes
Dependencies
Validation
Tracked in AIPYTORCH-1241.
New contributor declaration
littests.