Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Introduce hermetic rocm dependency #2759

Open
wants to merge 10 commits into
base: develop-upstream
Choose a base branch
from

Conversation

alekstheod
Copy link

@alekstheod alekstheod commented Nov 14, 2024

This change has as a goal to introduce an external dependency to the rocm library and tools.

Building xla with the hermetic rocm is done by using these env variables:

--repo_env=OS=ubuntu_20.04
--repo_env=ROCM_VERSION=6.2.0

One has to provie OS version and ROCm version to initialize a proper rocm repository.
If these flags are not set then default ROCm installation will be used to build XLA.

@alekstheod alekstheod changed the title WIP Introduce hermetic rocm dependency [ROCm] Introduce hermetic rocm dependency Nov 15, 2024
@alekstheod alekstheod force-pushed the ci_introduce_hermetic_rocm branch from 85c9767 to 963d88a Compare November 18, 2024 08:00
@alekstheod alekstheod requested review from i-chaochen and jayfurmanek and removed request for i-chaochen and jayfurmanek November 19, 2024 08:41
@alekstheod alekstheod marked this pull request as draft November 19, 2024 11:08
@alekstheod alekstheod force-pushed the ci_introduce_hermetic_rocm branch 2 times, most recently from 6e89c4c to bcf279c Compare November 20, 2024 17:39
@alekstheod alekstheod marked this pull request as ready for review November 20, 2024 17:50
@alekstheod alekstheod force-pushed the ci_introduce_hermetic_rocm branch from bcf279c to 402354e Compare November 20, 2024 18:04
@alekstheod alekstheod self-assigned this Nov 20, 2024
@alekstheod alekstheod force-pushed the ci_introduce_hermetic_rocm branch from 20e1a47 to 98dc885 Compare December 4, 2024 09:22
@alekstheod alekstheod force-pushed the ci_introduce_hermetic_rocm branch from 98dc885 to 7cc9486 Compare December 4, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant