Repository navigation
Use idomatic approach to extending CMAKE_MODULE_PATH. - #97
Closed
stellaraccident wants to merge 1 commit into
Closed
stellaraccident wants to merge 1 commit into
stellaraccident wants to merge 1 commit into
Conversation
There are many reasons why there may already be a CMAKE_MODULE_PATH defined. The idiomatic way to extend it in a project is via `list(APPEND`.
stellaraccident
requested review from
dayatsin-amd and
shwetagkhatri
as code owners
February 12, 2025 06:12
stellaraccident
added a commit
to ROCm/TheRock
that referenced
this pull request
Feb 12, 2025
* Adds host-math group and includes OpenBLAS and SuiteSparse in it to provide libcholmod (so that we have the option to avoid system deps for these). * Includes upstream patch ROCm/hipSOLVER#364 * Includes upstream patch ROCm/rocminfo#97 Includes workarounds for #82, #83 --------- Co-authored-by: Stella Laurenzo <stellaraccident@gmail.com>
Contributor
|
Please post PR against amd-staging branch. Otherwise change looks good to me. Thanks |
dayatsin-amd
approved these changes
Mar 6, 2025
dayatsin-amd
left a comment
dayatsin-amd
left a comment
Contributor
There was a problem hiding this comment.
@shwetagkhatri Can you submit the patch from internal ROCr repo.
The script to automatically pull patches from public into internal is not ready.
rahulc-gh
pushed a commit
that referenced
this pull request
Mar 15, 2025
There are many reasons why there may already be a CMAKE_MODULE_PATH defined. The idiomatic way to extend it in a project is via list(APPEND). #97 submitted by @stellaraccident Co-authored-by: Stella Laurenzo <Stella.Laurenzo@amd.com>
rahulc-gh
pushed a commit
that referenced
this pull request
Apr 9, 2025
* Obey CMAKE_BUILD_TYPE Obey CMAKE_BUILD_TYPE when it is passed on the command line. Previous behavior remains: Debug by default ROCRTST_BLD_TYPE can set build type * External CI: change trigger from amd-master to amd-mainline * Added gfx94x and gfx11xx IDs to enumerator (#5) * Use idomatic approach to extending CMAKE_MODULE_PATH. (#7) There are many reasons why there may already be a CMAKE_MODULE_PATH defined. The idiomatic way to extend it in a project is via list(APPEND). #97 submitted by @stellaraccident Co-authored-by: Stella Laurenzo <Stella.Laurenzo@amd.com> * Added release trigger for further releases * Fix for typo in ISA_TO_ID table (#6) Change-Id: Id0720988fb01079a3ca6f3287dc743d93db4fd0f * Remove WSL checks for displaying UUID and BDFID Signed-off-by: lyndonli <Lyndon.Li@amd.com> * Added KWS check for amd-mainline (#9) --------- Signed-off-by: lyndonli <Lyndon.Li@amd.com> Co-authored-by: benrichard-amd <ben.richard@amd.com> Co-authored-by: Su, Daniel <Daniel.Su@amd.com> Co-authored-by: Stella Laurenzo <Stella.Laurenzo@amd.com> Co-authored-by: Mallya, Ameya Keshava <AmeyaKeshava.Mallya@amd.com> Co-authored-by: Yat Sin, David <David.YatSin@amd.com> Co-authored-by: lyndonli <Lyndon.Li@amd.com>
jayhawk-commits
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
Aug 11, 2025
There are many reasons why there may already be a CMAKE_MODULE_PATH defined. The idiomatic way to extend it in a project is via list(APPEND). ROCm/rocminfo#97 submitted by @stellaraccident Co-authored-by: Stella Laurenzo <Stella.Laurenzo@amd.com> [ROCm/rocminfo commit: 8503ec3]
jayhawk-commits
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
Aug 11, 2025
* Obey CMAKE_BUILD_TYPE Obey CMAKE_BUILD_TYPE when it is passed on the command line. Previous behavior remains: Debug by default ROCRTST_BLD_TYPE can set build type * External CI: change trigger from amd-master to amd-mainline * Added gfx94x and gfx11xx IDs to enumerator (#5) * Use idomatic approach to extending CMAKE_MODULE_PATH. (#7) There are many reasons why there may already be a CMAKE_MODULE_PATH defined. The idiomatic way to extend it in a project is via list(APPEND). ROCm/rocminfo#97 submitted by @stellaraccident Co-authored-by: Stella Laurenzo <Stella.Laurenzo@amd.com> * Added release trigger for further releases * Fix for typo in ISA_TO_ID table (#6) Change-Id: Id0720988fb01079a3ca6f3287dc743d93db4fd0f * Remove WSL checks for displaying UUID and BDFID Signed-off-by: lyndonli <Lyndon.Li@amd.com> * Added KWS check for amd-mainline (#9) --------- Signed-off-by: lyndonli <Lyndon.Li@amd.com> Co-authored-by: benrichard-amd <ben.richard@amd.com> Co-authored-by: Su, Daniel <Daniel.Su@amd.com> Co-authored-by: Stella Laurenzo <Stella.Laurenzo@amd.com> Co-authored-by: Mallya, Ameya Keshava <AmeyaKeshava.Mallya@amd.com> Co-authored-by: Yat Sin, David <David.YatSin@amd.com> Co-authored-by: lyndonli <Lyndon.Li@amd.com> [ROCm/rocminfo commit: aec5d6f]
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
There are many reasons why there may already be a CMAKE_MODULE_PATH defined. The idiomatic way to extend it in a project is via list(APPEND). #97 submitted by @stellaraccident Co-authored-by: Stella Laurenzo <Stella.Laurenzo@amd.com> [ROCm/rocminfo commit: 8503ec3]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many reasons why there may already be a CMAKE_MODULE_PATH defined. The idiomatic way to extend it in a project is via
list(APPEND.