Skip to content

fix incorrect tyep casting for workgroup_max_dim and grid_max_dim #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfreehill merged 2 commits into from
May 9, 2018
Merged

fix incorrect tyep casting for workgroup_max_dim and grid_max_dim #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed70127
fix incorrect tyep casting for workgroup_max_dim and grid_max_dim
scchan May 8, 2018
788070d
change naming from Dim[n] to (x,y,z)
scchan May 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 20 additions & 24 deletions rocminfo.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,25 +452,22 @@ static void DisplayAgentInfo(agent_info_t *agent_i) {
printLabelStr("Fast F16 Operation:", agent_i->fast_f16 ? "TRUE":"FALSE", 1);

printLabelInt("Wavefront Size:", agent_i->wavefront_size, 1);

printLabelInt("Workgroup Max Size:", agent_i->workgroup_max_size, 1);
printLabel("Workgroup Max Size per Dimension:", true, 1);
printLabelInt("x", static_cast<uint32_t>(agent_i->workgroup_max_dim[0]), 2);
printLabelInt("y", static_cast<uint32_t>(agent_i->workgroup_max_dim[1]), 2);
printLabelInt("z", static_cast<uint32_t>(agent_i->workgroup_max_dim[2]), 2);

printLabel("Workgroup Max Size Per Dimension:", true, 1);
std::string dim;
for (int i = 0; i < 3; i++) {
dim = "Dim[" + std::to_string(i) + "]:";
printLabelInt(dim.c_str(),
reinterpret_cast<uint32_t*>(&agent_i->workgroup_max_dim)[i], 2);
}
printLabelInt("Grid Max Size:", agent_i->grid_max_size, 1);
printLabelInt("Waves Per CU:", agent_i->waves_per_cu, 1);
printLabelInt("Max Work-item Per CU:",
agent_i->wavefront_size*agent_i->waves_per_cu, 1);

printLabelInt("Grid Max Size:", agent_i->grid_max_size, 1);
printLabel("Grid Max Size per Dimension:", true, 1);
for (int i = 0; i < 3; i++) {
dim = "Dim[" + std::to_string(i) + "]:";
printLabelInt(dim.c_str(),
reinterpret_cast<uint32_t*>(&agent_i->grid_max_dim)[i], 2);
}
printLabelInt("x", agent_i->grid_max_dim.x, 2);
printLabelInt("y", agent_i->grid_max_dim.y, 2);
printLabelInt("z", agent_i->grid_max_dim.z, 2);

printLabelInt("Max number Of fbarriers Per Workgroup:",
agent_i->fbarrier_max_size, 1);
Expand Down Expand Up @@ -724,22 +721,21 @@ static void DisplayISAInfo(isa_info_t *isa_i, uint32_t indent) {

printLabelStr("Fast f16:", (isa_i->fast_f16 ? "TRUE" : "FALSE"), indent);

printLabel("Workgroup Max Dimension:", true, indent);
std::string dim;
for (int i = 0; i < 3; i++) {
dim = "Dim[" + std::to_string(i) + "]:";
printLabelInt(dim.c_str(),
reinterpret_cast<uint32_t*>(&isa_i->workgroup_max_dim)[i], indent+1);
}

printLabelInt("Workgroup Max Size:", isa_i->workgroup_max_size, indent);

printLabel("Grid Max Dimension:", true, indent);
printLabel("Workgroup Max Size per Dimension:", true, indent);
printLabelInt("x",
static_cast<uint32_t>(isa_i->workgroup_max_dim[0]), indent+1);
printLabelInt("y",
static_cast<uint32_t>(isa_i->workgroup_max_dim[1]), indent+1);
printLabelInt("z",
static_cast<uint32_t>(isa_i->workgroup_max_dim[2]), indent+1);

printLabelInt("Grid Max Size:", isa_i->grid_max_size, indent);
printLabel("Grid Max Size per Dimension:", true, indent);
printLabelInt("x", isa_i->grid_max_dim.x, indent+1);
printLabelInt("y", isa_i->grid_max_dim.y, indent+1);
printLabelInt("z", isa_i->grid_max_dim.z, indent+1);

printLabelInt("Grid Max Size:", isa_i->grid_max_size, indent);
printLabelInt("FBarrier Max Size:", isa_i->fbarrier_max_size, indent);
}

Expand Down