Skip to content

feat(rocprofiler-sdk): scope dispatch ATT to configured agents - #9934

Merged
amd-vkale merged 3 commits into
users/vkale/remove-callbacks-thread-tracefrom
users/vkale/thread-trace-per-agent-scoping
Aug 18, 2026
Merged

amd-vkale merged 3 commits into
users/vkale/remove-callbacks-thread-tracefrom
users/vkale/thread-trace-per-agent-scoping

Conversation

@amd-vkale

Copy link
Copy Markdown
Contributor

Motivation

This PR applies per-agent scoping from PR #9868 to the thread-trace callback-removal branch.

Technical Details

  • Per-agent serialization ref-counting in queue_controller
  • DispatchThreadTracer configured_agents/collects_on/intersects helpers
  • Scoped enable/disable serialization in start_context/stop_context
  • Agent filtering in thread_trace::write_hook
  • Disjoint dispatch ATT context conflict rules

Issue Tracking

Test Plan

Test Result

Submission Checklist

Apply per-agent scoping from PR #9868 to the thread-trace callback-removal branch:
- Per-agent serialization ref-counting in queue_controller
- DispatchThreadTracer configured_agents/collects_on/intersects helpers
- Scoped enable/disable serialization in start_context/stop_context
- Agent filtering in thread_trace::write_hook
- Disjoint dispatch ATT context conflict rules

Co-authored-by: Vivek Kale <vivek.kale@amd.com>
cursoragent and others added 2 commits August 10, 2026 23:06
Make agents_map_mut mutable for const query methods, rename locals that
shadow the agents member, and apply clang-format 11 to queue_controller.

Co-authored-by: Vivek Kale <vivek.kale@amd.com>
Declaration alignment in configured_agents and intersects.

Co-authored-by: Vivek Kale <vivek.kale@amd.com>
@cursor

cursor Bot commented Aug 18, 2026

Copy link
Copy Markdown

Automated stacked-PR status check (Cursor)

This PR's base branch (users/vkale/remove-callbacks-thread-trace-cursor-fixes) has no open tracking PR — it looks like it was pushed directly rather than opened as a PR (unlike the counters/SPM "cursor-fixes" pattern used elsewhere in this stack family). Under the "base PR must also be yours" merge policy, there's currently no base PR to evaluate readiness against, so this can't be considered for stacked auto-merge as-is.

Other blockers:

Remaining steps:

  1. Open a tracking PR for users/vkale/remove-callbacks-thread-trace-cursor-fixes (or fold it into refactor(rocprofiler-sdk): migrate thread trace off the per-queue callback registry #8790) so there's an actual base PR to gate on.
  2. Take this PR out of draft once ready.
  3. Fix the failing CI jobs.
  4. Rebase the whole thread-trace stack onto current develop (1506 commits behind).

Posted by an automated stacked-PR status check — no code or branch changes were made.

@amd-vkale

Copy link
Copy Markdown
Contributor Author

Mergeability (local review + GPU unit tests, 2026-08-18)

This draft is not ready to fold into #8790.

  • Still a draft, zero reviews.
  • Per-agent ATT scoping is a feature, not a review-fix.

Separately: this PR is based on users/vkale/remove-callbacks-thread-trace-cursor-fixes, which has no pull request. That one commit (cc09f3c053 — reject a second concurrent ATT context, drop the dead client global) is ready to land in #8790. It is exactly the fast-follow @bwelton asked for when approving #8790. Local thread-trace-queue-hooks-test (1/1) and thread-trace-packet-test (8/8) passed on that tip.

Plan: fast-forward that unpublished commit into #8790, then retarget this draft onto #8790. Do not merge this draft with #8790.

@amd-vkale
amd-vkale changed the base branch from users/vkale/remove-callbacks-thread-trace-cursor-fixes to users/vkale/remove-callbacks-thread-trace August 18, 2026 06:00
@amd-vkale

Copy link
Copy Markdown
Contributor Author

Update: the unpublished thread-trace cursor-fixes commit is now in #8790 (cc09f3c053). This PR’s base was retargeted onto users/vkale/remove-callbacks-thread-trace. Still draft / not for fold.

@amd-vkale
amd-vkale merged commit 7d7b8ea into users/vkale/remove-callbacks-thread-trace Aug 18, 2026
42 of 47 checks passed
@amd-vkale
amd-vkale deleted the users/vkale/thread-trace-per-agent-scoping branch August 18, 2026 06:31
@amd-vkale

Copy link
Copy Markdown
Contributor Author

Folded into #8790. Dispatch ATT per-agent scoping is now on users/vkale/remove-callbacks-thread-trace (d39785f333), plus new unit tests for disjoint vs overlapping contexts, scoped serialization, and write_hook skipping other agents. GitHub marked this PR merged once the base fast-forwarded through the feature commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants