[mikeqinamd]

This PR cleans up a few ABI/API issues.

Motivation

Unwanted Symbols

Currently, we expose a few unwanted symbols, and this PR removes them.

• Mangled version of hipExtModuleLaunchKernel and hipHccModuleLaunchKernel. They need to be extern "C".
• __gnu_h2f_ieee and __gnu_f2h_ieee. These are from libgcc. We should not be providing these symbols.

MSVC Warning

Right now MSVC generates many warnings because of a cast from hipError_t to uint32_t. This PR uses C++ enum classes to fix this warning. This explicitly specifies that hipError_t should be a uint32_t, which makes the ABI clearer (under Windows).

Hidden Visibility by Default.

Under Linux, all symbols are visible by default. While this is the default behaviour, it can cause unwanted conflicts during loading (because ELF uses a flat namespace). This PR uses -fvisibililty=hidden to hide symbols by default.

To expose public APIs, we define HIP_PUBLIC_API as __attribute__((visibility=default)) so that the compiler can expose this during compilation phase. Under GCC, this is essential to prevent compiler from optimizing the function into internal linkage.

We also need to remove HIP_PUBLIC_API from the public header, since now this contains symbol visibility attribute and we do not want to force applications to export our symbols. This macro is moved to hip_internal.hpp and it's exclusively designed for HIP developers now: if you would like to implement a public API (in hip_runtime_api.h), include hip_internal.hpp and decorate your function with HIP_PUBLIC_API.

Issue Tracking

JIRAID : AIRUNTIME-2633 Close

Test Result

All tests link and pass fine. We shouldn't use the private ABI for tests.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

[therock-pr-bot]

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*). Current: code file(s) changed: projects/clr/hipamd/include/hip/amd_detail/amd_channel_descriptor.h, projects/clr/hipamd/src/hip_activity.cpp, projects/clr/hipamd/src/hip_deprecated_abi.cpp, projects/clr/hipamd/src/hip_global.cpp, projects/clr/hipamd/src/hip_intercept.cpp (+6 more); no test file found
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

• ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

[jungx098]

@github-copilot review

[kjayapra-amd]

I agree with exposing a uniform "C" only interface.

But, we need to make sure the APIs were not exposed in C++ for a specific reason. @mangupta can you please confirm?

I believe this is also a breaking change.

[Copilot]

Pull request overview

Cleans up HIP ABI exposure across MSVC and GCC builds.

Changes:

• Gives hipError_t a fixed C++ underlying type.
• Consolidates C-linkage kernel wrappers.
• Configures runtime linkage and symbol visibility.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
projects/hip/include/hip/hip_runtime_api.h	Updates hipError_t representation.
projects/clr/hipamd/src/hip_table_interface.cpp	Adds C linkage to kernel APIs.
projects/clr/hipamd/src/hip_table_interface_c.cpp	Removes duplicate wrappers.
projects/clr/hipamd/src/CMakeLists.txt	Adjusts sources and visibility.
projects/clr/CMakeLists.txt	Modernizes MSVC runtime selection.

Suppressed comments (1)

projects/clr/hipamd/src/hip_table_interface.cpp:2560

• This moved definition likewise has no prior HIP_PUBLIC_API declaration in this translation unit (hip_ext.h:68-76 is not included). Once amdhip64 is compiled with hidden visibility, the deprecated but public C entry point cannot be exported by the version script. Give the definition default visibility or include the public declaration.

extern "C" hipError_t hipHccModuleLaunchKernel(hipFunction_t f, uint32_t globalWorkSizeX,

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[mikeqinamd]

Here's what I use to dump the exported symbols.

(venv) mqin@canmkmqinlnx (git)-[main]!-% nm -D --defined-only hipamd/lib/libamdhip64.so | awk '$2 ~ /^[TWD]$/ {print $3}' | sort

Before and after this PR:

(venv) mqin@canmkmqinlnx (git)-[main]!-% diff -u old.txt new.txt
--- old.txt     2026-09-14 14:32:02.843411499 -0400
+++ new.txt     2026-09-14 16:11:16.036595112 -0400
@@ -1,8 +1,6 @@
 amd_dbgapi_get_build_id@@hip_4.5
 amd_dbgapi_get_build_name@@hip_4.5
 amd_dbgapi_get_git_hash@@hip_4.5
-__gnu_f2h_ieee@@hip_4.2
-__gnu_h2f_ieee@@hip_4.2
 hipApiName@@hip_4.2
 hipArray3DCreate@@hip_4.2
 hipArray3DGetDescriptor@@hip_5.6
@@ -565,5 +563,3 @@
 hipUserObjectRelease@@hip_5.3
 hipUserObjectRetain@@hip_5.3
 hipWaitExternalSemaphoresAsync@@hip_4.3
-_Z24hipExtModuleLaunchKernelP18ihipModuleSymbol_tjjjjjjmP12ihipStream_tPPvS4_P11ihipEvent_tS6_j@@hip_4.2
-_Z24hipHccModuleLaunchKernelP18ihipModuleSymbol_tjjjjjjmP12ihipStream_tPPvS4_P11ihipEvent_tS6_@@hip_4.2

[systems-assistant]

TheRock Submodule Bump Activity

Newest first

• 2026-09-19 — Included in TheRock via ROCm/TheRock#8334.

[pfultz2]

Here's what I use to dump the exported symbols.

(venv) mqin@canmkmqinlnx (git)-[main]!-% nm -D --defined-only hipamd/lib/libamdhip64.so | awk '$2 ~ /^[TWD]$/ {print $3}' | sort

Before and after this PR:

(venv) mqin@canmkmqinlnx (git)-[main]!-% diff -u old.txt new.txt
--- old.txt     2026-09-14 14:32:02.843411499 -0400
+++ new.txt     2026-09-14 16:11:16.036595112 -0400
@@ -1,8 +1,6 @@
 amd_dbgapi_get_build_id@@hip_4.5
 amd_dbgapi_get_build_name@@hip_4.5
 amd_dbgapi_get_git_hash@@hip_4.5
-__gnu_f2h_ieee@@hip_4.2
-__gnu_h2f_ieee@@hip_4.2
 hipApiName@@hip_4.2
 hipArray3DCreate@@hip_4.2
 hipArray3DGetDescriptor@@hip_5.6
@@ -565,5 +563,3 @@
 hipUserObjectRelease@@hip_5.3
 hipUserObjectRetain@@hip_5.3
 hipWaitExternalSemaphoresAsync@@hip_4.3
-_Z24hipExtModuleLaunchKernelP18ihipModuleSymbol_tjjjjjjmP12ihipStream_tPPvS4_P11ihipEvent_tS6_j@@hip_4.2
-_Z24hipHccModuleLaunchKernelP18ihipModuleSymbol_tjjjjjjmP12ihipStream_tPPvS4_P11ihipEvent_tS6_@@hip_4.2

Doesnt this break ABI compatibility, shouldn't the major version be updated?