Skip to content

[rocprofiler-systems] Remove oneTBB dependency - #9876

Merged
dgaliffiAMD merged 10 commits into
developfrom
users/sputhala/tbbRemovalFixSystems
Oct 2, 2026
Merged

[rocprofiler-systems] Remove oneTBB dependency#9876
dgaliffiAMD merged 10 commits into
developfrom
users/sputhala/tbbRemovalFixSystems

Conversation

@sputhala-amd

@sputhala-amd sputhala-amd commented Aug 7, 2026 •
edited by dgaliffiAMD
Loading

Copy link
Copy Markdown
Contributor

Motivation

This PR removes oneTBB entirely as a transitive dependency of Dyninst, which the rocprof-sys-instrument binary-instrumentation tool links.

The dyninst side changes are in the PR: ROCm/dyninst#26

Dyninst used TBB solely for its internal concurrent containers (concurrent_hash_map, concurrent_vector, concurrent_unordered_set); the parallelism itself is driven by OpenMP, not TBB's task scheduler.

Technical Details

Build options / presets

  • Drop the ROCPROFSYS_BUILD_TBB option (CMakeLists.txt) and its CMakePresets.json entries.

CMake machinery

  • Delete cmake/DyninstTBB.cmake (system-find / build-from-source logic) and cmake/Modules/FindTBB.cmake.
  • cmake/DyninstExternals.cmake: stop including DyninstTBB / building the TBB external target and drop TBB from the deprecated DYNINST_BUILD_* → ROCPROFSYS_BUILD_* mapping.

Bundled dependency

  • Remove the external/onetbb submodule and its .gitmodules entry.

Packaging / CI / tooling

  • cmake/ConfigCPack.cmake: drop the libtbb-dev Debian runtime dependency.
  • scripts/build-release.sh: stop passing -DROCPROFSYS_BUILD_TBB=ON.
  • Sanitizer suppressions (rocprof-sys-{asan,lsan,leak,thread,ubsan}.supp): remove TBB entries.
  • .github/ci-build-matrix.json: drop libtbb-dev from the system-deps installs.
  • .github/workflows/*: stop passing -DROCPROFSYS_BUILD_TBB and drop the libtbb-dev / tbb-devel installs

Instrumenter / runtime

  • source/bin/rocprof-sys-instrument/internal_libs.cpp and the libs_regex in rocprof-sys-instrument.cpp: drop libtbb* from the internal-library filters.
  • source/lib/rocprof-sys/library/causal/data.cpp: drop tbbmalloc from the causal binary-exclude filter.

Submodule pointer

  • Bump the external/dyninst submodule to the TBB-free Dyninst commit.

Docs

  • Update docs/install/build.rst, docs/how-to/instrumenting-rewriting-binary-application.rst, and README.md.

Issue Tracking

JIRA ID: AIPROFSYST-545

Test Plan

  • Ran existing workflows
  • Compared various metrics between TBB-version and non-TBB version.

Test Result

Submission Checklist

@sputhala-amd
sputhala-amd requested review from a team and jrmadsen as code owners August 7, 2026 20:25
Copilot AI lite review requested due to automatic review settings August 7, 2026 20:25
@sputhala-amd
sputhala-amd requested a review from a team as a code owner August 7, 2026 20:25
@sputhala-amd
sputhala-amd marked this pull request as draft August 7, 2026 20:25
@github-actions github-actions Bot added documentation Improvements or additions to documentation project: rocprofiler-systems labels Aug 7, 2026
@therock-pr-bot

therock-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocprofiler-systems/source/bin/rocprof-sys-instrument/internal_libs.cpp, projects/rocprofiler-systems/source/bin/rocprof-sys-instrument/rocprof-sys-instrument.cpp, projects/rocprofiler-systems/source/lib/rocprof-sys/library/causal/data.cpp; no test file found
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

Copilot AI reviewed Aug 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes oneTBB as a Dyninst transitive dependency for rocprof-sys-instrument by deleting the project’s TBB build/find machinery, removing TBB link/include plumbing from Dyninst packaging targets, and scrubbing TBB-specific runtime filters/suppressions and documentation.

Changes:

  • Removed the ROCPROFSYS_BUILD_TBB option and deleted DyninstTBB.cmake / FindTBB.cmake, plus the related find_package(TBB) / include/link wiring.
  • Updated instrumenter internal-library filters and sanitizer suppression lists to stop treating TBB libraries as internal dependencies.
  • Updated docs, presets, packaging/CI metadata, and release scripts to reflect the removal of TBB.

Reviewed changes

Copilot reviewed 21 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
projects/rocprofiler-systems/source/lib/rocprof-sys/library/causal/data.cpp Removes tbbmalloc from the causal binary exclude filter.
projects/rocprofiler-systems/source/bin/rocprof-sys-instrument/rocprof-sys-instrument.cpp Removes TBB libraries from the instrumenter’s internal-library regex filter.
projects/rocprofiler-systems/source/bin/rocprof-sys-instrument/internal_libs.cpp Removes Dyninst’s former TBB shared-library entries from the internal library set.
projects/rocprofiler-systems/scripts/rocprof-sys-ubsan.supp Removes TBB UBSan suppressions.
projects/rocprofiler-systems/scripts/rocprof-sys-thread.supp Removes libtbb.so from thread-sanitizer suppressions.
projects/rocprofiler-systems/scripts/rocprof-sys-lsan.supp Removes TBB leak suppressions.
projects/rocprofiler-systems/scripts/rocprof-sys-leak.supp Removes TBB leak suppressions.
projects/rocprofiler-systems/scripts/rocprof-sys-asan.supp Removes libtbb.so ASan interceptor suppressions.
projects/rocprofiler-systems/scripts/build-release.sh Stops enabling ROCPROFSYS_BUILD_TBB for release builds.
projects/rocprofiler-systems/README.md Removes ROCPROFSYS_BUILD_TBB from the build example.
projects/rocprofiler-systems/docs/install/build.rst Removes TBB from Dyninst dependency docs and build instructions.
projects/rocprofiler-systems/docs/how-to/instrumenting-rewriting-binary-application.rst Removes TBB libraries from documented internal-library listings.
projects/rocprofiler-systems/CMakePresets.json Removes preset entries setting ROCPROFSYS_BUILD_TBB.
projects/rocprofiler-systems/CMakeLists.txt Deletes the ROCPROFSYS_BUILD_TBB CMake option.
projects/rocprofiler-systems/cmake/Packages.cmake Removes the TBB interface target and TBB find/include/link logic from Dyninst packaging.
projects/rocprofiler-systems/cmake/Modules/FindTBB.cmake Deletes the in-tree TBB find module.
projects/rocprofiler-systems/cmake/DyninstTBB.cmake Deletes bundled/system TBB configuration and external build logic.
projects/rocprofiler-systems/cmake/DyninstExternals.cmake Removes TBB from deprecated option mapping and external dependency build chain.
projects/rocprofiler-systems/cmake/ConfigCPack.cmake Drops Debian dependency logic for libtbb-dev.
projects/rocprofiler-systems/.github/ci-build-matrix.json Removes libtbb-dev from the system dependency install set.
.gitmodules Removes the external/onetbb submodule entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread projects/rocprofiler-systems/docs/install/build.rst Resolved
Comment thread projects/rocprofiler-systems/CMakeLists.txt Resolved
Comment thread projects/rocprofiler-systems/docs/install/build.rst Resolved
@github-actions

github-actions Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

rocprofiler-systems CI Summary

Test Results (for commit 372c570)

Workflow jobs covered: 36

Workflow Runs Avg Test Time Tests Skipped Failed
Ubuntu 22.04 5 29m 52s 2,685 105 0
Ubuntu 24.04 5 31m 09s 2,705 115 0
Debian 4 38m 28s 2,260 82 0
RHEL 12 36m 44s 6,444 307 0
System deps 10 29m 26s 5,594 226 0
Total 36 33m 10s 19,688 835 0

Failed Tests

No failed tests reported.

Sanitizers

Thread Undefined Address
Passed Passed Passed

@sputhala-amd

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Aug 18, 2026
@sputhala-amd
sputhala-amd marked this pull request as ready for review August 18, 2026 02:20
@sputhala-amd
sputhala-amd requested a review from a team as a code owner August 18, 2026 02:20
@github-actions

github-actions Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Coverage Report

Code Coverage Report

Unit Tests

Lines: 🔴 19.5% (📉 -3.59% vs base) — 6,637/33,979 across 313 files
Functions: 🔴 20.3% — 702/3,462

🔴 0-20% (184 files)
Lines Functions File
0.0% 0/106 0/9 source/bin/common/argument_registration.hpp
0.0% 0/267 0/28 source/bin/common/tool_runner.cpp
0.0% 0/992 0/48 source/bin/rocprof-sys-avail/avail.cpp
0.0% 0/60 0/6 source/bin/rocprof-sys-avail/avail.hpp
0.0% 0/223 0/24 source/bin/rocprof-sys-avail/common.cpp
0.0% 0/18 0/3 source/bin/rocprof-sys-avail/component_categories.hpp
0.0% 0/274 0/12 source/bin/rocprof-sys-avail/generate_config.cpp
0.0% 0/39 0/2 source/bin/rocprof-sys-avail/get_availability.hpp
0.0% 0/11 0/1 source/bin/rocprof-sys-avail/get_categories.hpp
0.0% 0/106 0/6 source/bin/rocprof-sys-avail/hw_counter_query.cpp
0.0% 0/4 0/1 source/bin/rocprof-sys-avail/info_type.cpp
0.0% 0/9 0/1 source/bin/rocprof-sys-avail/info_type.hpp
0.0% 0/454 0/47 source/bin/rocprof-sys-causal/impl.cpp
0.0% 0/82 0/2 source/bin/rocprof-sys-causal/rocprof-sys-causal.cpp
0.0% 0/706 0/45 source/bin/rocprof-sys-instrument/details.cpp
0.0% 0/106 0/7 source/bin/rocprof-sys-instrument/function_signature.cpp
0.0% 0/20 0/5 source/bin/rocprof-sys-instrument/function_signature.hpp
0.0% 0/160 0/7 source/bin/rocprof-sys-instrument/info.hpp
0.0% 0/277 0/22 source/bin/rocprof-sys-instrument/internal_libs.cpp
0.0% 0/63 0/5 source/bin/rocprof-sys-instrument/log.cpp
0.0% 0/5 0/1 source/bin/rocprof-sys-instrument/log.hpp
0.0% 0/547 0/41 source/bin/rocprof-sys-instrument/module_function.cpp
0.0% 0/93 0/7 source/bin/rocprof-sys-instrument/module_function.hpp
0.0% 0/1588 0/87 source/bin/rocprof-sys-instrument/rocprof-sys-instrument.cpp
0.0% 0/166 0/12 source/bin/rocprof-sys-instrument/rocprof-sys-instrument.hpp
0.0% 0/2 0/1 source/bin/rocprof-sys-run/rocprof-sys-run.cpp
0.0% 0/2 0/1 source/bin/rocprof-sys-sample/rocprof-sys-sample.cpp
0.0% 0/24 0/1 source/lib/backends/amd_smi/wrapper.hpp
0.0% 0/46 0/2 source/lib/backends/rocprofiler_sdk/wrapper.hpp
0.0% 0/16 0/4 source/lib/binary/address_multirange.cpp
0.0% 0/9 0/1 source/lib/binary/address_multirange.hpp
0.0% 0/126 0/5 source/lib/binary/analysis.cpp
0.0% 0/7 0/1 source/lib/binary/binary_info.hpp
0.0% 0/107 0/9 source/lib/binary/dwarf_entry.cpp
0.0% 0/1 0/1 source/lib/binary/dwarf_entry.hpp
0.0% 0/74 0/6 source/lib/binary/link_map.cpp
0.0% 0/3 0/1 source/lib/binary/link_map.hpp
0.0% 0/10 0/1 source/lib/binary/scope_filter.cpp
0.0% 0/6 0/2 source/lib/binary/scope_filter.hpp
0.0% 0/162 0/18 source/lib/binary/symbol.cpp
0.0% 0/8 0/8 source/lib/binary/symbol.hpp
0.0% 0/10 0/2 source/lib/common/env_vars.hpp
0.0% 0/40 0/3 source/lib/common/invoke.hpp
0.0% 0/153 0/10 source/lib/common/md5sum.hpp
0.0% 0/22 0/2 source/lib/common/setup.hpp
0.0% 0/166 0/2 source/lib/core/agent_info.hpp
0.0% 0/25 0/2 source/lib/core/amd_smi.cpp
0.0% 0/74 0/18 source/lib/core/binary/address_range.cpp
0.0% 0/9 0/3 source/lib/core/binary/address_range.hpp
0.0% 0/21 0/6 source/lib/core/categories.cpp
0.0% 0/11 0/11 source/lib/core/components/fwd.hpp
0.0% 0/29 0/3 source/lib/core/config.hpp
0.0% 0/85 0/5 source/lib/core/cpu.cpp
0.0% 0/1 0/1 source/lib/core/cpu.hpp
0.0% 0/61 0/6 source/lib/core/dynamic_library.cpp
0.0% 0/28 0/7 source/lib/core/exception.cpp
0.0% 0/182 0/23 source/lib/core/gpu.cpp
0.0% 0/162 0/12 source/lib/core/gpu_metrics.cpp
0.0% 0/33 0/6 source/lib/core/mpi.hpp
0.0% 0/59 0/4 source/lib/core/mproc.cpp
0.0% 0/24 0/2 source/lib/core/node_info.cpp
0.0% 0/2 0/2 source/lib/core/node_info.hpp
0.0% 0/78 0/5 source/lib/core/perf.cpp
0.0% 0/52 0/5 source/lib/core/perfetto/cached_perfetto_session.cpp
0.0% 0/33 0/4 source/lib/core/perfetto/counter_track.hpp
0.0% 0/32 0/7 source/lib/core/perfetto/emitter.cpp
0.0% 0/48 0/9 source/lib/core/perfetto/emitter.hpp
0.0% 0/9 0/1 source/lib/core/perfetto/sinks/append_mode.hpp
0.0% 0/1 0/1 source/lib/core/progress/bar.hpp
0.0% 0/8 0/3 source/lib/core/sdk/tracing-config-deps.hpp
0.0% 0/54 0/3 source/lib/core/trace_cache/cache_manager.cpp
0.0% 0/7 0/3 source/lib/core/trace_cache/cache_manager.hpp
0.0% 0/520 0/71 source/lib/core/trace_cache/metadata_registry.cpp
0.0% 0/805 0/102 source/lib/core/trace_cache/perfetto_processor.cpp
0.0% 0/122 0/12 source/lib/core/trace_cache/post_processor.cpp
0.0% 0/839 0/32 source/lib/core/trace_cache/rocpd_processor.cpp
0.0% 0/77 0/1 source/lib/core/trace_cache/sample_processor.hpp
0.0% 0/14 0/6 source/lib/rocprof-sys-causal-api/causal_api.cpp
0.0% 0/543 0/85 source/lib/rocprof-sys-dl/dl.cpp
0.0% 0/16 0/1 source/lib/rocprof-sys-dl/main.c
0.0% 0/280 0/31 source/lib/rocprof-sys-rt/src/RTcommon.c
0.0% 0/29 0/4 source/lib/rocprof-sys-rt/src/RTheap-linux.c
0.0% 0/65 0/4 source/lib/rocprof-sys-rt/src/RTheap.c
0.0% 0/212 0/22 source/lib/rocprof-sys-rt/src/RTlinux.c
0.0% 0/97 0/8 source/lib/rocprof-sys-rt/src/RTposix.c
0.0% 0/6 0/2 source/lib/rocprof-sys-rt/src/RTsignal.c
0.0% 0/11 0/2 source/lib/rocprof-sys-rt/src/RTthread-x86-64.c
0.0% 0/3 0/1 source/lib/rocprof-sys-rt/src/RTthread.c
0.0% 0/84 0/20 source/lib/rocprof-sys/api.cpp
0.0% 0/694 0/40 source/lib/rocprof-sys/library.cpp
0.0% 0/78 0/6 source/lib/rocprof-sys/library/causal/components/backtrace.cpp
0.0% 0/8 0/1 source/lib/rocprof-sys/library/causal/components/backtrace.hpp
0.0% 0/105 0/11 source/lib/rocprof-sys/library/causal/components/blocking_gotcha.cpp
0.0% 0/37 0/7 source/lib/rocprof-sys/library/causal/components/causal_gotcha.cpp
0.0% 0/86 0/22 source/lib/rocprof-sys/library/causal/components/progress_point.cpp
0.0% 0/23 0/3 source/lib/rocprof-sys/library/causal/components/progress_point.hpp
0.0% 0/50 0/8 source/lib/rocprof-sys/library/causal/components/unblocking_gotcha.cpp
0.0% 0/564 0/33 source/lib/rocprof-sys/library/causal/data.cpp
0.0% 0/91 0/16 source/lib/rocprof-sys/library/causal/delay.cpp
0.0% 0/391 0/29 source/lib/rocprof-sys/library/causal/experiment.cpp
0.0% 0/3 0/1 source/lib/rocprof-sys/library/causal/experiment.hpp
0.0% 0/24 0/5 source/lib/rocprof-sys/library/causal/sample_data.cpp
0.0% 0/296 0/25 source/lib/rocprof-sys/library/causal/sampling.cpp
0.0% 0/4 0/1 source/lib/rocprof-sys/library/causal/selected_entry.cpp
0.0% 0/5 0/3 source/lib/rocprof-sys/library/causal/selected_entry.hpp
0.0% 0/76 0/11 source/lib/rocprof-sys/library/components/backtrace.cpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/backtrace.hpp
0.0% 0/217 0/30 source/lib/rocprof-sys/library/components/backtrace_metrics.cpp
0.0% 0/11 0/2 source/lib/rocprof-sys/library/components/backtrace_metrics.hpp
0.0% 0/9 0/3 source/lib/rocprof-sys/library/components/backtrace_timestamp.cpp
0.0% 0/4 0/2 source/lib/rocprof-sys/library/components/backtrace_timestamp.hpp
0.0% 0/74 0/10 source/lib/rocprof-sys/library/components/callchain.cpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/callchain.hpp
0.0% 0/378 0/30 source/lib/rocprof-sys/library/components/comm_data.cpp
0.0% 0/19 0/5 source/lib/rocprof-sys/library/components/comm_data.hpp
0.0% 0/8 0/2 source/lib/rocprof-sys/library/components/ensure_storage.hpp
0.0% 0/29 0/6 source/lib/rocprof-sys/library/components/exit_gotcha.cpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/exit_gotcha.hpp
0.0% 0/70 0/8 source/lib/rocprof-sys/library/components/fork_gotcha.cpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/fork_gotcha.hpp
0.0% 0/13 0/3 source/lib/rocprof-sys/library/components/kill_gotcha.cpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/kill_gotcha.hpp
0.0% 0/176 0/22 source/lib/rocprof-sys/library/components/mpi_gotcha.cpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/components/mpi_gotcha.hpp
0.0% 0/533 0/12 source/lib/rocprof-sys/library/components/mpip.hpp
0.0% 0/79 0/19 source/lib/rocprof-sys/library/components/numa_gotcha.cpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/components/numa_gotcha.hpp
0.0% 0/352 0/20 source/lib/rocprof-sys/library/components/pthread_create_gotcha.cpp
0.0% 0/5 0/1 source/lib/rocprof-sys/library/components/pthread_create_gotcha.hpp
0.0% 0/35 0/9 source/lib/rocprof-sys/library/components/pthread_gotcha.cpp
0.0% 0/24 0/2 source/lib/rocprof-sys/library/components/pthread_mutex_gotcha_policy.hpp
0.0% 0/165 0/31 source/lib/rocprof-sys/library/components/vaapi_gotcha.cpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/components/vaapi_gotcha.hpp
0.0% 0/147 0/10 source/lib/rocprof-sys/library/coverage.cpp
0.0% 0/29 0/5 source/lib/rocprof-sys/library/coverage.hpp
0.0% 0/66 0/16 source/lib/rocprof-sys/library/coverage/impl.hpp
0.0% 0/268 0/37 source/lib/rocprof-sys/library/kokkosp.cpp
0.0% 0/252 0/32 source/lib/rocprof-sys/library/perf.cpp
0.0% 0/11 0/3 source/lib/rocprof-sys/library/perf.hpp
0.0% 0/150 0/9 source/lib/rocprof-sys/library/pmc/collectors/common/settings.hpp
0.0% 0/69 0/5 source/lib/rocprof-sys/library/pmc/collectors/cpu/cache_policy.hpp
0.0% 0/47 0/6 source/lib/rocprof-sys/library/pmc/collectors/cpu/cpu_traits.hpp
0.0% 0/53 0/9 source/lib/rocprof-sys/library/pmc/collectors/cpu/perfetto_policy.hpp
0.0% 0/116 0/6 source/lib/rocprof-sys/library/pmc/collectors/gpu/cache_policy.hpp
0.0% 0/225 0/36 source/lib/rocprof-sys/library/pmc/collectors/gpu/perfetto_policy.hpp
0.0% 0/25 0/3 source/lib/rocprof-sys/library/pmc/collectors/gpu/sample.hpp
0.0% 0/34 0/3 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/cache_policy.hpp
0.0% 0/44 0/7 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/perfetto_policy.hpp
0.0% 0/16 0/2 source/lib/rocprof-sys/library/pmc/collectors/nic/sample.hpp
0.0% 0/14 0/2 source/lib/rocprof-sys/library/pmc/device_providers/procfs/provider.hpp
0.0% 0/169 0/20 source/lib/rocprof-sys/library/pmc/sampler.cpp
0.0% 0/125 0/11 source/lib/rocprof-sys/library/process_sampler.cpp
0.0% 0/15 0/3 source/lib/rocprof-sys/library/process_sampler.hpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/rocm.cpp
0.0% 0/1146 0/73 source/lib/rocprof-sys/library/rocprofiler-sdk.cpp
0.0% 0/16 0/2 source/lib/rocprof-sys/library/rocprofiler-sdk/callback/hip_stream.hpp
0.0% 0/111 0/13 source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp
0.0% 0/17 0/6 source/lib/rocprof-sys/library/rocprofiler-sdk/counters.hpp
0.0% 0/132 0/9 source/lib/rocprof-sys/library/rocprofiler-sdk/fwd.cpp
0.0% 0/33 0/7 source/lib/rocprof-sys/library/rocprofiler-sdk/fwd.hpp
0.0% 0/36 0/9 source/lib/rocprof-sys/library/rocprofiler-sdk/marker_writer.cpp
0.0% 0/136 0/13 source/lib/rocprof-sys/library/rocprofiler-sdk/rccl.cpp
0.0% 0/109 0/10 source/lib/rocprof-sys/library/rocprofiler-sdk/roctx_client.cpp
0.0% 0/122 0/20 source/lib/rocprof-sys/library/runtime.cpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/runtime.hpp
0.0% 0/978 0/58 source/lib/rocprof-sys/library/sampling.cpp
0.0% 0/148 0/31 source/lib/rocprof-sys/library/thread_data.hpp
0.0% 0/10 0/3 source/lib/rocprof-sys/library/thread_data_growth.hpp
0.0% 0/11 0/1 source/lib/rocprof-sys/library/thread_deleter.cpp
0.0% 0/5 0/1 source/lib/rocprof-sys/library/thread_deleter.hpp
0.0% 0/168 0/27 source/lib/rocprof-sys/library/thread_info.cpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/thread_info.hpp
0.0% 0/118 0/11 source/lib/rocprof-sys/library/tracing.cpp
0.0% 0/111 0/30 source/lib/rocprof-sys/library/tracing.hpp
0.0% 0/3 0/1 source/lib/rocprof-sys/library/tracing/annotation.cpp
0.0% 0/45 0/4 source/lib/rocprof-sys/library/tracing/annotation.hpp
0.0% 0/8 0/2 source/lib/rocprof-sys/progress.cpp
0.0% 0/74 0/16 source/lib/rocprof-sys/regions.cpp
0.0% 0/91 0/6 source/lib/rocprof-sys/timeout.cpp
0.0% 0/453 0/45 source/python/libpyrocprofsys.cpp
0.6% 1/173 1/13 source/lib/core/perfetto.cpp
0.8% 7/855 1/72 source/lib/core/argparse.cpp
2.6% 47/1805 7/301 source/lib/core/config.cpp
18.8% 6/32 2/5 source/bin/common/common_utils.hpp
🟠 20-50% (6 files)
Lines Functions File
20.0% 1/5 0/2 source/lib/core/argparse.hpp
23.3% 14/60 3/12 source/lib/core/agent_manager.cpp
31.2% 20/64 4/9 source/lib/core/utility.hpp
36.7% 11/30 1/6 source/lib/core/trace_cache/metadata_registry.hpp
40.9% 18/44 1/7 source/lib/rocprof-sys/library/rocprofiler-sdk/types.hpp
49.6% 131/264 14/32 source/lib/rocprof-sys/library/components/category_region.hpp
🟡 50-80% (26 files)
Lines Functions File
50.0% 19/38 4/5 source/lib/common/static_object.hpp
50.0% 27/54 3/5 source/lib/core/output_file_registry.cpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/pmc/collectors/nic/types.hpp
50.2% 210/418 23/35 source/bin/common/common_utils.cpp
52.0% 13/25 2/3 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/gpu_perf_counter_traits.hpp
55.7% 34/61 5/8 source/lib/rocprof-sys/library/pmc/collectors/cpu/sample.hpp
56.2% 9/16 3/3 source/lib/core/perfetto/sinks/per_pid_file_sink.cpp
60.0% 3/5 1/1 source/lib/core/agent.hpp
61.4% 70/114 7/10 source/lib/core/progress/bar.cpp
62.1% 41/66 7/8 source/lib/rocprof-sys/library/pmc/collectors/base/collector.hpp
62.9% 347/552 26/40 source/bin/common/json_config.cpp
63.1% 53/84 4/5 source/lib/core/trace_cache/discovery.cpp
66.2% 47/71 5/5 source/lib/rocprof-sys/library/pmc/collectors/gpu/gpu_traits.hpp
66.7% 2/3 0/2 source/lib/rocprof-sys/library/pmc/collectors/cpu/types.hpp
66.7% 22/33 3/8 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/types.hpp
68.4% 39/57 4/6 source/lib/core/perfetto.hpp
68.7% 46/67 11/14 source/lib/core/trace_cache/data_types.cpp
70.0% 236/337 15/17 source/bin/common/preset_registry.cpp
71.9% 87/121 14/17 source/lib/core/perfetto/engine.cpp
72.2% 13/18 2/6 source/lib/rocprof-sys/library/rocprofiler-sdk/roctx_client.hpp
72.7% 32/44 3/3 source/lib/core/perfetto/sinks/file_output.cpp
74.3% 78/105 9/10 source/lib/core/perfetto/engine_impl.hpp
74.5% 41/55 4/7 source/lib/core/config/trace_period_config.hpp
75.0% 3/4 0/1 source/lib/backends/amd_smi/nic_types.hpp
78.2% 61/78 9/10 source/lib/rocprof-sys/library/pmc/device_providers/rocprofiler_sdk/provider.hpp
78.8% 78/99 4/4 source/lib/core/perfetto/sinks/single_file_sink.cpp
🟢 80-100% (97 files)
Lines Functions File
80.0% 100/125 14/16 source/lib/common/path.hpp
80.6% 133/165 10/14 source/lib/backends/procfs/backend.hpp
81.8% 36/44 3/6 source/lib/core/containers/static_vector.hpp
83.9% 73/87 10/12 source/lib/logger/logger.hpp
84.6% 55/65 4/4 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/page_migrate.hpp
85.1% 40/47 2/2 source/lib/core/trace_cache/storage_parser.hpp
85.2% 213/250 20/33 source/lib/core/sdk/tracing-config.hpp
86.0% 49/57 4/4 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/device.hpp
86.6% 259/299 27/33 source/lib/common/environment.hpp
87.8% 151/172 17/19 source/lib/rocprof-sys/library/rocprofiler-sdk/domain_service.hpp
88.2% 135/153 30/32 source/lib/backends/rocprofiler_sdk/backend.hpp
88.9% 24/27 5/6 source/lib/rocprof-sys/library/rocprofiler-sdk/stream_stack_service.hpp
89.1% 106/119 8/8 source/lib/rocprof-sys/library/pmc/collectors/cpu/device.hpp
89.3% 50/56 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/event_page_migrate.hpp
90.0% 54/60 4/4 source/lib/core/trace_cache/buffer_storage.cpp
90.2% 240/266 21/30 source/lib/core/trace_cache/sample_type.hpp
90.4% 178/197 14/18 source/lib/rocprof-sys/library/components/shmem_gotcha.hpp
90.5% 249/275 19/20 source/lib/core/trace_cache/unified_memory_processor.cpp
90.7% 39/43 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/event_page_fault.hpp
90.7% 39/43 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/event_queue.hpp
91.1% 41/45 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/queue.hpp
91.5% 43/47 7/7 source/lib/core/control/triggers/time_window.hpp
91.7% 11/12 2/2 source/lib/core/perfetto/session_backend.hpp
91.7% 44/48 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/event_unmap_from_gpu.hpp
92.1% 70/76 7/8 source/lib/core/trace_cache/buffer_storage.hpp
92.2% 47/51 7/7 source/lib/core/control/clocks/posix.hpp
92.3% 24/26 1/3 source/lib/core/containers/c_array.hpp
92.3% 36/39 3/4 source/lib/rocprof-sys/library/rocprofiler-sdk/callback/common_tracing_callbacks.hpp
92.5% 37/40 2/2 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/scratch_memory.hpp
92.6% 163/176 9/9 source/lib/rocprof-sys/library/pmc/collectors/gpu/device.hpp
92.9% 13/14 0/1 source/lib/rocprof-sys/library/pmc/collectors/common/collector_slice.hpp
92.9% 13/14 1/2 source/lib/rocprof-sys/library/rocprofiler-sdk/callback_domain.hpp
93.1% 54/58 6/8 source/lib/rocprof-sys/library/components/pthread_mutex_gotcha.hpp
94.4% 51/54 4/7 source/lib/core/containers/aligned_static_vector.hpp
95.2% 20/21 2/2 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/memory_allocation.hpp
95.3% 162/170 19/22 source/lib/rocprof-sys/library/components/ucx_gotcha.hpp
95.4% 62/65 1/5 source/lib/core/trace_cache/cacheable.hpp
95.4% 83/87 19/23 source/lib/core/containers/stable_vector.hpp
95.8% 23/24 2/4 source/lib/common/pci_bdf.hpp
95.8% 23/24 4/6 source/lib/common/synchronized.hpp
96.3% 26/27 1/2 source/lib/common/delimit.hpp
96.5% 82/85 11/12 source/lib/core/state.hpp
96.8% 30/31 3/4 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/sample.hpp
97.0% 32/33 2/2 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/event_dropped_events.hpp
97.4% 74/76 6/6 source/lib/core/common_types.hpp
97.5% 39/40 6/7 source/lib/core/trace_cache/rocpd_helpers.hpp
97.5% 39/40 3/3 source/lib/core/utility.cpp
97.6% 40/41 2/2 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/memory_copy.hpp
97.7% 85/87 11/12 source/lib/core/control/triggers/roctx.cpp
97.7% 43/44 5/6 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered_domain.hpp
97.8% 44/45 7/11 source/lib/core/demangler.hpp
97.8% 45/46 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/page_fault.hpp
97.8% 45/46 7/7 source/lib/rocprof-sys/library/rocprofiler-sdk/rccl_internal.hpp
97.9% 47/48 3/3 source/lib/rocprof-sys/library/pmc/collectors/nic/device.hpp
98.1% 53/54 7/7 source/lib/rocprof-sys/library/pmc/device_providers/amd_smi/provider.hpp
98.5% 67/68 10/12 source/lib/common/string_utility.hpp
98.7% 76/77 3/3 source/lib/core/perfetto/packet_framing.hpp
98.8% 81/82 15/16 source/lib/backends/amd_smi/backend.hpp
99.1% 115/116 19/19 source/lib/core/control/session.cpp
100.0% 1/1 0/1 source/bin/common/json_config.hpp
100.0% 110/110 13/14 source/lib/backends/amd_smi/device.hpp
100.0% 7/7 0/1 source/lib/backends/amd_smi/gpu_types.hpp
100.0% 1/1 0/1 source/lib/backends/rocprofiler_sdk/types.hpp
100.0% 12/12 1/1 source/lib/common/join.hpp
100.0% 14/14 2/4 source/lib/common/units/data_size.hpp
100.0% 11/11 2/3 source/lib/common/units/frequency.hpp
100.0% 11/11 2/3 source/lib/common/units/power.hpp
100.0% 5/5 0/3 source/lib/common/units/quantity.hpp
100.0% 8/8 0/2 source/lib/common/version.hpp
100.0% 2/2 0/2 source/lib/core/agent_manager.hpp
100.0% 22/22 0/2 source/lib/core/containers/operators.hpp
100.0% 19/19 4/4 source/lib/core/control/clocks/steady.cpp
100.0% 2/2 1/2 source/lib/core/control/clocks/steady.hpp
100.0% 15/15 3/5 source/lib/core/control/session.hpp
100.0% 3/3 0/2 source/lib/core/control/triggers/roctx.hpp
100.0% 1/1 0/1 source/lib/core/output_file_registry.hpp
100.0% 1/1 0/1 source/lib/core/perfetto/category_registry.hpp
100.0% 1/1 0/1 source/lib/core/perfetto/engine.hpp
100.0% 7/7 0/1 source/lib/core/perfetto/sinks/file_output.hpp
100.0% 1/1 0/1 source/lib/core/perfetto/sinks/per_pid_file_sink.hpp
100.0% 2/2 0/1 source/lib/core/perfetto/sinks/single_file_sink.hpp
100.0% 2/2 0/1 source/lib/core/perfetto/sinks/trace_sink.hpp
100.0% 7/7 2/2 source/lib/core/progress/tracker.cpp
100.0% 1/1 0/1 source/lib/core/progress/tracker.hpp
100.0% 4/4 0/3 source/lib/core/trace_cache/data_types.hpp
100.0% 9/9 3/3 source/lib/core/trace_cache/type_registry.hpp
100.0% 24/24 4/5 source/lib/core/trace_cache/unified_memory_processor.hpp
100.0% 5/5 2/2 source/lib/core/track_registry.cpp
100.0% 4/4 0/2 source/lib/core/track_registry.hpp
100.0% 12/12 1/1 source/lib/logger/logger.cpp
100.0% 9/9 0/2 source/lib/rocprof-sys/library/pmc/collectors/gpu/types.hpp
100.0% 21/21 4/4 source/lib/rocprof-sys/library/pmc/collectors/nic/perfetto_policy.hpp
100.0% 2/2 0/2 source/lib/rocprof-sys/library/pmc/common/types.hpp
100.0% 43/43 2/2 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kernel_dispatch.hpp
100.0% 4/4 1/1 source/lib/rocprof-sys/library/rocprofiler-sdk/callback/code_object.hpp
100.0% 27/27 3/4 source/lib/rocprof-sys/library/rocprofiler-sdk/domain_registry.hpp
100.0% 33/33 3/4 source/lib/rocprof-sys/library/rocprofiler-sdk/marker_writer.hpp

Distribution

Range Files
0-20% 184
20-50% 6
50-80% 26
80-100% 97

Unit Tests (PR Diff Files Only)

Lines: 🔴 0.0% — 0/2,429 across 3 files
Functions: 🔴 0.0% — 0/142

🔴 0-20% (3 files)
Lines Functions File
0.0% 0/277 0/22 source/bin/rocprof-sys-instrument/internal_libs.cpp
0.0% 0/1588 0/87 source/bin/rocprof-sys-instrument/rocprof-sys-instrument.cpp
0.0% 0/564 0/33 source/lib/rocprof-sys/library/causal/data.cpp

Distribution

Range Files
0-20% 3
20-50% 0
50-80% 0
80-100% 0

E2E Tests

Lines: 🟡 66.1% — 22,469/33,979 across 313 files
Functions: 🟡 65.9% — 2,280/3,462

🔴 0-20% (43 files)
Lines Functions File
0.0% 0/106 0/6 source/bin/rocprof-sys-avail/hw_counter_query.cpp
0.0% 0/24 0/1 source/lib/backends/amd_smi/wrapper.hpp
0.0% 0/166 0/2 source/lib/core/agent_info.hpp
0.0% 0/85 0/5 source/lib/core/cpu.cpp
0.0% 0/1 0/1 source/lib/core/cpu.hpp
0.0% 0/61 0/6 source/lib/core/dynamic_library.cpp
0.0% 0/28 0/7 source/lib/core/exception.cpp
0.0% 0/162 0/12 source/lib/core/gpu_metrics.cpp
0.0% 0/8 0/3 source/lib/core/sdk/tracing-config-deps.hpp
0.0% 0/6 0/2 source/lib/rocprof-sys-rt/src/RTsignal.c
0.0% 0/11 0/2 source/lib/rocprof-sys-rt/src/RTthread-x86-64.c
0.0% 0/3 0/1 source/lib/rocprof-sys-rt/src/RTthread.c
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/exit_gotcha.hpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/kill_gotcha.hpp
0.0% 0/53 0/9 source/lib/rocprof-sys/library/pmc/collectors/cpu/perfetto_policy.hpp
0.0% 0/116 0/6 source/lib/rocprof-sys/library/pmc/collectors/gpu/cache_policy.hpp
0.0% 0/225 0/36 source/lib/rocprof-sys/library/pmc/collectors/gpu/perfetto_policy.hpp
0.0% 0/25 0/3 source/lib/rocprof-sys/library/pmc/collectors/gpu/sample.hpp
0.0% 0/34 0/3 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/cache_policy.hpp
0.0% 0/44 0/7 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/perfetto_policy.hpp
0.0% 0/16 0/2 source/lib/rocprof-sys/library/pmc/collectors/nic/sample.hpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/rocm.cpp
0.0% 0/16 0/2 source/lib/rocprof-sys/library/rocprofiler-sdk/callback/hip_stream.hpp
0.0% 0/111 0/13 source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp
0.0% 0/17 0/6 source/lib/rocprof-sys/library/rocprofiler-sdk/counters.hpp
0.0% 0/132 0/9 source/lib/rocprof-sys/library/rocprofiler-sdk/fwd.cpp
0.0% 0/136 0/13 source/lib/rocprof-sys/library/rocprofiler-sdk/rccl.cpp
0.0% 0/109 0/10 source/lib/rocprof-sys/library/rocprofiler-sdk/roctx_client.cpp
0.0% 0/3 0/1 source/lib/rocprof-sys/library/tracing/annotation.cpp
0.0% 0/45 0/4 source/lib/rocprof-sys/library/tracing/annotation.hpp
0.0% 0/453 0/45 source/python/libpyrocprofsys.cpp
0.6% 1/173 1/13 source/lib/core/perfetto.cpp
4.8% 8/165 2/31 source/lib/rocprof-sys/library/components/vaapi_gotcha.cpp
5.3% 61/1146 12/73 source/lib/rocprof-sys/library/rocprofiler-sdk.cpp
8.3% 3/36 1/9 source/lib/rocprof-sys/library/rocprofiler-sdk/marker_writer.cpp
8.7% 4/46 0/2 source/lib/backends/rocprofiler_sdk/wrapper.hpp
9.1% 3/33 0/7 source/lib/rocprof-sys/library/rocprofiler-sdk/fwd.hpp
12.0% 3/25 1/2 source/lib/core/amd_smi.cpp
13.6% 38/280 7/31 source/lib/rocprof-sys-rt/src/RTcommon.c
13.8% 4/29 1/4 source/lib/rocprof-sys-rt/src/RTheap-linux.c
14.2% 30/212 4/22 source/lib/rocprof-sys-rt/src/RTlinux.c
16.2% 12/74 4/16 source/lib/rocprof-sys/regions.cpp
17.6% 32/182 6/23 source/lib/core/gpu.cpp
🟠 20-50% (20 files)
Lines Functions File
22.7% 34/150 4/9 source/lib/rocprof-sys/library/pmc/collectors/common/settings.hpp
22.8% 191/839 9/32 source/lib/core/trace_cache/rocpd_processor.cpp
23.5% 122/520 24/71 source/lib/core/trace_cache/metadata_registry.cpp
24.4% 19/78 3/5 source/lib/core/perf.cpp
27.8% 27/97 4/8 source/lib/rocprof-sys-rt/src/RTposix.c
30.9% 249/805 32/102 source/lib/core/trace_cache/perfetto_processor.cpp
34.5% 10/29 3/6 source/lib/rocprof-sys/library/components/exit_gotcha.cpp
35.7% 30/84 10/20 source/lib/rocprof-sys/api.cpp
37.1% 39/105 5/11 source/lib/rocprof-sys/library/causal/components/blocking_gotcha.cpp
37.8% 31/82 1/2 source/bin/rocprof-sys-causal/rocprof-sys-causal.cpp
38.5% 5/13 2/3 source/lib/rocprof-sys/library/components/kill_gotcha.cpp
40.9% 18/44 1/7 source/lib/rocprof-sys/library/rocprofiler-sdk/types.hpp
41.7% 25/60 7/12 source/lib/core/agent_manager.cpp
43.8% 21/48 6/9 source/lib/core/perfetto/emitter.hpp
44.4% 4/9 1/3 source/lib/rocprof-sys/library/components/backtrace_timestamp.cpp
45.0% 72/160 3/7 source/bin/rocprof-sys-instrument/info.hpp
45.5% 30/66 6/16 source/lib/rocprof-sys/library/coverage/impl.hpp
46.2% 42/91 2/6 source/lib/rocprof-sys/timeout.cpp
47.4% 179/378 16/30 source/lib/rocprof-sys/library/components/comm_data.cpp
47.7% 31/65 3/4 source/lib/rocprof-sys-rt/src/RTheap.c
🟡 50-80% (60 files)
Lines Functions File
50.0% 8/16 2/4 source/lib/binary/address_multirange.cpp
50.0% 16/32 5/7 source/lib/core/perfetto/emitter.cpp
50.0% 7/14 2/6 source/lib/rocprof-sys-causal-api/causal_api.cpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/components/numa_gotcha.hpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/components/vaapi_gotcha.hpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/pmc/collectors/nic/types.hpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/thread_info.hpp
50.0% 4/8 1/2 source/lib/rocprof-sys/progress.cpp
50.5% 56/111 12/30 source/lib/rocprof-sys/library/tracing.hpp
52.0% 13/25 2/3 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/gpu_perf_counter_traits.hpp
53.0% 142/268 27/37 source/lib/rocprof-sys/library/kokkosp.cpp
53.2% 41/77 0/1 source/lib/core/trace_cache/sample_processor.hpp
57.0% 45/79 8/19 source/lib/rocprof-sys/library/components/numa_gotcha.cpp
57.5% 23/40 1/3 source/lib/common/invoke.hpp
58.6% 99/169 15/20 source/lib/rocprof-sys/library/pmc/sampler.cpp
59.4% 63/106 5/9 source/bin/common/argument_registration.hpp
59.5% 44/74 13/18 source/lib/core/binary/address_range.cpp
60.0% 3/5 1/1 source/lib/core/agent.hpp
60.8% 132/217 12/30 source/lib/rocprof-sys/library/components/backtrace_metrics.cpp
61.4% 70/114 7/10 source/lib/core/progress/bar.cpp
62.7% 37/59 3/4 source/lib/core/mproc.cpp
62.9% 44/70 5/8 source/lib/rocprof-sys/library/components/fork_gotcha.cpp
63.9% 161/252 24/32 source/lib/rocprof-sys/library/perf.cpp
64.3% 54/84 4/5 source/lib/core/trace_cache/discovery.cpp
66.2% 47/71 5/5 source/lib/rocprof-sys/library/pmc/collectors/gpu/gpu_traits.hpp
66.3% 468/706 33/45 source/bin/rocprof-sys-instrument/details.cpp
66.4% 81/122 15/20 source/lib/rocprof-sys/library/runtime.cpp
66.7% 6/9 1/1 source/lib/core/perfetto/sinks/append_mode.hpp
66.7% 22/33 3/8 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/types.hpp
67.6% 25/37 5/7 source/lib/rocprof-sys/library/causal/components/causal_gotcha.cpp
69.1% 375/543 40/85 source/lib/rocprof-sys-dl/dl.cpp
70.0% 35/50 5/8 source/lib/rocprof-sys/library/causal/components/unblocking_gotcha.cpp
70.2% 40/57 4/6 source/lib/core/perfetto.hpp
70.5% 124/176 16/22 source/lib/rocprof-sys/library/components/mpi_gotcha.cpp
72.2% 13/18 2/6 source/lib/rocprof-sys/library/rocprofiler-sdk/roctx_client.hpp
72.7% 245/337 16/17 source/bin/common/preset_registry.cpp
72.7% 32/44 3/3 source/lib/core/perfetto/sinks/file_output.cpp
72.8% 712/978 46/58 source/lib/rocprof-sys/library/sampling.cpp
73.0% 54/74 5/6 source/lib/binary/link_map.cpp
73.6% 406/552 30/40 source/bin/common/json_config.cpp
73.6% 78/106 5/7 source/bin/rocprof-sys-instrument/function_signature.cpp
74.5% 35/47 4/6 source/lib/rocprof-sys/library/pmc/collectors/cpu/cpu_traits.hpp
74.6% 1184/1588 51/87 source/bin/rocprof-sys-instrument/rocprof-sys-instrument.cpp
74.6% 47/63 4/5 source/bin/rocprof-sys-instrument/log.cpp
74.6% 312/418 33/35 source/bin/common/common_utils.cpp
74.6% 421/564 30/33 source/lib/rocprof-sys/library/causal/data.cpp
75.0% 15/20 5/5 source/bin/rocprof-sys-instrument/function_signature.hpp
75.0% 3/4 0/1 source/lib/backends/amd_smi/nic_types.hpp
75.0% 18/24 4/5 source/lib/rocprof-sys/library/causal/sample_data.cpp
75.3% 223/296 23/25 source/lib/rocprof-sys/library/causal/sampling.cpp
75.7% 414/547 40/41 source/bin/rocprof-sys-instrument/module_function.cpp
76.2% 93/122 11/12 source/lib/core/trace_cache/post_processor.cpp
76.3% 29/38 5/5 source/lib/common/static_object.hpp
78.2% 61/78 9/10 source/lib/rocprof-sys/library/pmc/device_providers/rocprofiler_sdk/provider.hpp
78.3% 209/267 24/28 source/bin/common/tool_runner.cpp
78.4% 116/148 26/31 source/lib/rocprof-sys/library/thread_data.hpp
79.0% 83/105 10/10 source/lib/core/perfetto/engine_impl.hpp
79.1% 219/277 20/22 source/bin/rocprof-sys-instrument/internal_libs.cpp
79.2% 19/24 2/2 source/lib/core/node_info.cpp
79.8% 134/168 24/27 source/lib/rocprof-sys/library/thread_info.cpp
🟢 80-100% (190 files)
Lines Functions File
80.0% 4/5 0/1 source/bin/rocprof-sys-instrument/log.hpp
80.7% 134/166 12/12 source/bin/rocprof-sys-instrument/rocprof-sys-instrument.hpp
81.1% 1464/1805 275/301 source/lib/core/config.cpp
81.2% 181/223 21/24 source/bin/rocprof-sys-avail/common.cpp
81.2% 13/16 1/1 source/lib/rocprof-sys-dl/main.c
81.4% 70/86 17/22 source/lib/rocprof-sys/library/causal/components/progress_point.cpp
82.7% 43/52 5/5 source/lib/core/perfetto/cached_perfetto_session.cpp
83.2% 89/107 8/9 source/lib/binary/dwarf_entry.cpp
83.3% 578/694 35/40 source/lib/rocprof-sys/library.cpp
83.3% 25/30 3/6 source/lib/core/trace_cache/metadata_registry.hpp
83.6% 327/391 18/29 source/lib/rocprof-sys/library/causal/experiment.cpp
84.2% 16/19 3/5 source/lib/rocprof-sys/library/components/comm_data.hpp
84.2% 139/165 11/14 source/lib/backends/procfs/backend.hpp
84.6% 137/162 17/18 source/lib/binary/symbol.cpp
84.6% 55/65 4/4 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/page_migrate.hpp
84.8% 84/99 4/4 source/lib/core/perfetto/sinks/single_file_sink.cpp
84.8% 56/66 8/8 source/lib/rocprof-sys/library/pmc/collectors/base/collector.hpp
85.1% 74/87 10/12 source/lib/logger/logger.hpp
85.7% 78/91 14/16 source/lib/rocprof-sys/library/causal/delay.cpp
86.0% 49/57 4/4 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/device.hpp
86.0% 80/93 5/7 source/bin/rocprof-sys-instrument/module_function.hpp
87.0% 47/54 3/3 source/lib/core/trace_cache/cache_manager.cpp
87.6% 262/299 29/33 source/lib/common/environment.hpp
87.8% 129/147 10/10 source/lib/rocprof-sys/library/coverage.cpp
87.8% 151/172 17/19 source/lib/rocprof-sys/library/rocprofiler-sdk/domain_service.hpp
87.9% 399/454 35/47 source/bin/rocprof-sys-causal/impl.cpp
88.1% 104/118 10/11 source/lib/rocprof-sys/library/tracing.cpp
88.2% 67/76 9/11 source/lib/rocprof-sys/library/components/backtrace.cpp
88.2% 135/153 30/32 source/lib/backends/rocprofiler_sdk/backend.hpp
88.9% 48/54 4/5 source/lib/core/output_file_registry.cpp
88.9% 24/27 5/6 source/lib/rocprof-sys/library/rocprofiler-sdk/stream_stack_service.hpp
89.0% 761/855 57/72 source/lib/core/argparse.cpp
89.2% 66/74 7/10 source/lib/rocprof-sys/library/components/callchain.cpp
89.2% 223/250 23/33 source/lib/core/sdk/tracing-config.hpp
89.3% 50/56 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/event_page_migrate.hpp
90.0% 9/10 1/1 source/lib/binary/scope_filter.cpp
90.0% 54/60 4/4 source/lib/core/trace_cache/buffer_storage.cpp
90.1% 247/274 11/12 source/bin/rocprof-sys-avail/generate_config.cpp
90.2% 240/266 21/30 source/lib/core/trace_cache/sample_type.hpp
90.5% 249/275 19/20 source/lib/core/trace_cache/unified_memory_processor.cpp
90.7% 39/43 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/event_page_fault.hpp
90.7% 39/43 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/event_queue.hpp
90.9% 20/22 2/2 source/lib/common/setup.hpp
90.9% 320/352 18/20 source/lib/rocprof-sys/library/components/pthread_create_gotcha.cpp
90.9% 10/11 1/1 source/lib/rocprof-sys/library/thread_deleter.cpp
91.1% 41/45 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/queue.hpp
91.6% 109/119 8/8 source/lib/rocprof-sys/library/pmc/collectors/cpu/device.hpp
91.7% 11/12 2/2 source/lib/core/perfetto/session_backend.hpp
91.7% 44/48 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/event_unmap_from_gpu.hpp
92.1% 116/126 5/5 source/lib/binary/analysis.cpp
92.1% 70/76 7/8 source/lib/core/trace_cache/buffer_storage.hpp
92.2% 47/51 7/7 source/lib/core/control/clocks/posix.hpp
92.3% 36/39 3/4 source/lib/rocprof-sys/library/rocprofiler-sdk/callback/common_tracing_callbacks.hpp
92.5% 37/40 2/2 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/scratch_memory.hpp
92.6% 112/121 16/17 source/lib/core/perfetto/engine.cpp
92.6% 163/176 9/9 source/lib/rocprof-sys/library/pmc/collectors/gpu/device.hpp
92.6% 919/992 41/48 source/bin/rocprof-sys-avail/avail.cpp
92.8% 116/125 11/11 source/lib/rocprof-sys/library/process_sampler.cpp
92.8% 245/264 28/32 source/lib/rocprof-sys/library/components/category_region.hpp
92.9% 13/14 2/2 source/lib/rocprof-sys/library/pmc/device_providers/procfs/provider.hpp
92.9% 13/14 1/2 source/lib/rocprof-sys/library/rocprofiler-sdk/callback_domain.hpp
93.1% 27/29 3/5 source/lib/rocprof-sys/library/coverage.hpp
93.6% 73/78 6/6 source/lib/rocprof-sys/library/causal/components/backtrace.cpp
93.8% 15/16 3/3 source/lib/core/perfetto/sinks/per_pid_file_sink.cpp
93.9% 31/33 6/6 source/lib/core/mpi.hpp
94.3% 33/35 7/9 source/lib/rocprof-sys/library/components/pthread_gotcha.cpp
94.4% 118/125 15/16 source/lib/common/path.hpp
94.4% 186/197 16/18 source/lib/rocprof-sys/library/components/shmem_gotcha.hpp
94.4% 17/18 3/3 source/bin/rocprof-sys-avail/component_categories.hpp
95.1% 58/61 7/8 source/lib/rocprof-sys/library/pmc/collectors/cpu/sample.hpp
95.2% 20/21 2/2 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/memory_allocation.hpp
95.3% 162/170 19/22 source/lib/rocprof-sys/library/components/ucx_gotcha.hpp
95.4% 62/65 1/5 source/lib/core/trace_cache/cacheable.hpp
95.7% 45/47 2/2 source/lib/core/trace_cache/storage_parser.hpp
95.8% 23/24 2/4 source/lib/common/pci_bdf.hpp
96.3% 26/27 1/2 source/lib/common/delimit.hpp
96.3% 52/54 5/7 source/lib/core/containers/aligned_static_vector.hpp
96.6% 28/29 3/3 source/lib/core/config.hpp
96.7% 148/153 9/10 source/lib/common/md5sum.hpp
96.8% 30/31 3/4 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/sample.hpp
96.9% 62/64 9/9 source/lib/core/utility.hpp
97.0% 32/33 4/4 source/lib/core/perfetto/counter_track.hpp
97.0% 32/33 2/2 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/event_dropped_events.hpp
97.0% 65/67 14/14 source/lib/core/trace_cache/data_types.cpp
97.4% 74/76 6/6 source/lib/core/common_types.hpp
97.5% 39/40 6/7 source/lib/core/trace_cache/rocpd_helpers.hpp
97.5% 39/40 3/3 source/lib/core/utility.cpp
97.6% 40/41 2/2 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/memory_copy.hpp
97.7% 85/87 11/12 source/lib/core/control/triggers/roctx.cpp
97.7% 43/44 5/6 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered_domain.hpp
97.8% 44/45 7/11 source/lib/core/demangler.hpp
97.8% 45/46 3/3 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kfd/page_fault.hpp
97.8% 45/46 7/7 source/lib/rocprof-sys/library/rocprofiler-sdk/rccl_internal.hpp
97.9% 47/48 3/3 source/lib/rocprof-sys/library/pmc/collectors/nic/device.hpp
98.1% 53/54 7/7 source/lib/rocprof-sys/library/pmc/device_providers/amd_smi/provider.hpp
98.3% 57/58 6/8 source/lib/rocprof-sys/library/components/pthread_mutex_gotcha.hpp
98.5% 67/68 10/12 source/lib/common/string_utility.hpp
98.6% 68/69 5/5 source/lib/rocprof-sys/library/pmc/collectors/cpu/cache_policy.hpp
98.7% 76/77 3/3 source/lib/core/perfetto/packet_framing.hpp
98.8% 81/82 15/16 source/lib/backends/amd_smi/backend.hpp
99.1% 115/116 19/19 source/lib/core/control/session.cpp
100.0% 32/32 4/5 source/bin/common/common_utils.hpp
100.0% 1/1 0/1 source/bin/common/json_config.hpp
100.0% 60/60 6/6 source/bin/rocprof-sys-avail/avail.hpp
100.0% 39/39 2/2 source/bin/rocprof-sys-avail/get_availability.hpp
100.0% 11/11 1/1 source/bin/rocprof-sys-avail/get_categories.hpp
100.0% 4/4 1/1 source/bin/rocprof-sys-avail/info_type.cpp
100.0% 9/9 0/1 source/bin/rocprof-sys-avail/info_type.hpp
100.0% 2/2 1/1 source/bin/rocprof-sys-run/rocprof-sys-run.cpp
100.0% 2/2 1/1 source/bin/rocprof-sys-sample/rocprof-sys-sample.cpp
100.0% 110/110 13/14 source/lib/backends/amd_smi/device.hpp
100.0% 7/7 0/1 source/lib/backends/amd_smi/gpu_types.hpp
100.0% 1/1 0/1 source/lib/backends/rocprofiler_sdk/types.hpp
100.0% 9/9 0/1 source/lib/binary/address_multirange.hpp
100.0% 7/7 1/1 source/lib/binary/binary_info.hpp
100.0% 1/1 0/1 source/lib/binary/dwarf_entry.hpp
100.0% 3/3 0/1 source/lib/binary/link_map.hpp
100.0% 6/6 1/2 source/lib/binary/scope_filter.hpp
100.0% 8/8 7/8 source/lib/binary/symbol.hpp
100.0% 10/10 2/2 source/lib/common/env_vars.hpp
100.0% 12/12 1/1 source/lib/common/join.hpp
100.0% 24/24 5/6 source/lib/common/synchronized.hpp
100.0% 14/14 2/4 source/lib/common/units/data_size.hpp
100.0% 11/11 2/3 source/lib/common/units/frequency.hpp
100.0% 11/11 2/3 source/lib/common/units/power.hpp
100.0% 5/5 0/3 source/lib/common/units/quantity.hpp
100.0% 8/8 0/2 source/lib/common/version.hpp
100.0% 2/2 1/2 source/lib/core/agent_manager.hpp
100.0% 5/5 0/2 source/lib/core/argparse.hpp
100.0% 9/9 1/3 source/lib/core/binary/address_range.hpp
100.0% 21/21 6/6 source/lib/core/categories.cpp
100.0% 11/11 11/11 source/lib/core/components/fwd.hpp
100.0% 55/55 6/7 source/lib/core/config/trace_period_config.hpp
100.0% 26/26 1/3 source/lib/core/containers/c_array.hpp
100.0% 22/22 0/2 source/lib/core/containers/operators.hpp
100.0% 87/87 20/23 source/lib/core/containers/stable_vector.hpp
100.0% 44/44 3/6 source/lib/core/containers/static_vector.hpp
100.0% 19/19 4/4 source/lib/core/control/clocks/steady.cpp
100.0% 2/2 2/2 source/lib/core/control/clocks/steady.hpp
100.0% 15/15 3/5 source/lib/core/control/session.hpp
100.0% 3/3 0/2 source/lib/core/control/triggers/roctx.hpp
100.0% 47/47 7/7 source/lib/core/control/triggers/time_window.hpp
100.0% 2/2 2/2 source/lib/core/node_info.hpp
100.0% 1/1 0/1 source/lib/core/output_file_registry.hpp
100.0% 1/1 0/1 source/lib/core/perfetto/category_registry.hpp
100.0% 1/1 0/1 source/lib/core/perfetto/engine.hpp
100.0% 7/7 0/1 source/lib/core/perfetto/sinks/file_output.hpp
100.0% 1/1 0/1 source/lib/core/perfetto/sinks/per_pid_file_sink.hpp
100.0% 2/2 0/1 source/lib/core/perfetto/sinks/single_file_sink.hpp
100.0% 2/2 0/1 source/lib/core/perfetto/sinks/trace_sink.hpp
100.0% 1/1 0/1 source/lib/core/progress/bar.hpp
100.0% 7/7 2/2 source/lib/core/progress/tracker.cpp
100.0% 1/1 0/1 source/lib/core/progress/tracker.hpp
100.0% 85/85 11/12 source/lib/core/state.hpp
100.0% 7/7 1/3 source/lib/core/trace_cache/cache_manager.hpp
100.0% 4/4 0/3 source/lib/core/trace_cache/data_types.hpp
100.0% 9/9 3/3 source/lib/core/trace_cache/type_registry.hpp
100.0% 24/24 4/5 source/lib/core/trace_cache/unified_memory_processor.hpp
100.0% 5/5 2/2 source/lib/core/track_registry.cpp
100.0% 4/4 0/2 source/lib/core/track_registry.hpp
100.0% 12/12 1/1 source/lib/logger/logger.cpp
100.0% 8/8 0/1 source/lib/rocprof-sys/library/causal/components/backtrace.hpp
100.0% 23/23 2/3 source/lib/rocprof-sys/library/causal/components/progress_point.hpp
100.0% 3/3 0/1 source/lib/rocprof-sys/library/causal/experiment.hpp
100.0% 4/4 1/1 source/lib/rocprof-sys/library/causal/selected_entry.cpp
100.0% 5/5 2/3 source/lib/rocprof-sys/library/causal/selected_entry.hpp
100.0% 1/1 0/1 source/lib/rocprof-sys/library/components/backtrace.hpp
100.0% 11/11 1/2 source/lib/rocprof-sys/library/components/backtrace_metrics.hpp
100.0% 4/4 0/2 source/lib/rocprof-sys/library/components/backtrace_timestamp.hpp
100.0% 1/1 0/1 source/lib/rocprof-sys/library/components/callchain.hpp
100.0% 8/8 2/2 source/lib/rocprof-sys/library/components/ensure_storage.hpp
100.0% 1/1 0/1 source/lib/rocprof-sys/library/components/fork_gotcha.hpp
100.0% 2/2 0/1 source/lib/rocprof-sys/library/components/mpi_gotcha.hpp
100.0% 533/533 12/12 source/lib/rocprof-sys/library/components/mpip.hpp
100.0% 5/5 0/1 source/lib/rocprof-sys/library/components/pthread_create_gotcha.hpp
100.0% 24/24 1/2 source/lib/rocprof-sys/library/components/pthread_mutex_gotcha_policy.hpp
100.0% 11/11 0/3 source/lib/rocprof-sys/library/perf.hpp
100.0% 14/14 0/1 source/lib/rocprof-sys/library/pmc/collectors/common/collector_slice.hpp
100.0% 3/3 0/2 source/lib/rocprof-sys/library/pmc/collectors/cpu/types.hpp
100.0% 9/9 0/2 source/lib/rocprof-sys/library/pmc/collectors/gpu/types.hpp
100.0% 21/21 4/4 source/lib/rocprof-sys/library/pmc/collectors/nic/perfetto_policy.hpp
100.0% 2/2 0/2 source/lib/rocprof-sys/library/pmc/common/types.hpp
100.0% 15/15 2/3 source/lib/rocprof-sys/library/process_sampler.hpp
100.0% 43/43 2/2 source/lib/rocprof-sys/library/rocprofiler-sdk/buffered/kernel_dispatch.hpp
100.0% 4/4 1/1 source/lib/rocprof-sys/library/rocprofiler-sdk/callback/code_object.hpp
100.0% 27/27 3/4 source/lib/rocprof-sys/library/rocprofiler-sdk/domain_registry.hpp
100.0% 33/33 3/4 source/lib/rocprof-sys/library/rocprofiler-sdk/marker_writer.hpp
100.0% 2/2 0/1 source/lib/rocprof-sys/library/runtime.hpp
100.0% 10/10 3/3 source/lib/rocprof-sys/library/thread_data_growth.hpp
100.0% 5/5 1/1 source/lib/rocprof-sys/library/thread_deleter.hpp

Distribution

Range Files
0-20% 43
20-50% 20
50-80% 60
80-100% 190

@sputhala-amd

sputhala-amd commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Updated numbers for the final state of this branch.

Both trees were rebuilt from the same rocprofiler-systems source, so Dyninst is the only variable.

The memory regression reported above is gone.
Peak RSS is now at parity with the TBB baseline.

Instrumentation wall time

8 threads:

Target TBB Final (no TBB)
transpose (282 KB) 0.82 s 0.83 s (+1.2%)
lulesh (5.3 MB) 1.16 s 1.13 s (-2.6%)
libdyninstAPI.so (76 MB) 9.97 s 11.36 s (+13.9%)

64 threads:

Target TBB Final (no TBB)
transpose (282 KB) 0.84 s 0.85 s (+1.2%)
lulesh (5.3 MB) 1.16 s 1.17 s (+0.9%)
libdyninstAPI.so (76 MB) 9.90 s 11.05 s (+11.6%)

Both real applications are within 1.5% of the TBB baseline at 8 and 64 threads.
The 76 MB shared library retains a residual: +11.6% at 64 threads and +13.9% at 8.
That target is a deliberately extreme parse, not something CI instruments.

Peak RSS at 8 threads

Target TBB Final (no TBB)
transpose (282 KB) 441 MB 441 MB (0.0%)
lulesh (5.3 MB) 545 MB 546 MB (+0.2%)
libdyninstAPI.so (76 MB) 819 MB 819 MB (0.0%)

Peak RSS on the 76 MB target is bimodal, landing at either ~819 MB or ~2180 MB.

Callgrind puts total instruction counts within 0.5% (ours fewer) and minor page faults are lower on this branch, so the cost is the allocator rather than the containers.

@sputhala-amd
sputhala-amd force-pushed the users/sputhala/tbbRemovalFixSystems branch from a982217 to 9e074ce Compare September 11, 2026 20:28
dgaliffiAMD
dgaliffiAMD reviewed Sep 21, 2026
View reviewed changes
Comment thread projects/rocprofiler-systems/.github/ci-build-matrix.json Resolved
Comment thread projects/rocprofiler-systems/cmake/Packages.cmake Resolved
@sputhala-amd
sputhala-amd force-pushed the users/sputhala/tbbRemovalFixSystems branch from 0e7a2bb to 150887d Compare September 25, 2026 15:50
@sputhala-amd

sputhala-amd commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

The code coverage job builds the base branch first to produce a coverage baseline, so dropping libtbb-dev broke it - develop still requires a system TBB, and its configure aborted with "Could NOT find TBB" before any coverage was collected.

It also re-syncs the Dyninst submodule when switching from the baseline to the PR, because git checkout moves the gitlink but leaves the submodule work tree on the base branch's Dyninst, which would otherwise make the PR half of the job test the wrong Dyninst.

@sputhala-amd
sputhala-amd force-pushed the users/sputhala/tbbRemovalFixSystems branch 2 times, most recently from 611f8f6 to 94cb843 Compare September 30, 2026 20:45
@dgaliffiAMD

dgaliffiAMD commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Can you update the CHANGELOGS for this feature? A stacked PR is okay, so it doesn't have to re-run all of the testing

@sputhala-amd
[rocprofiler-systems] Remove oneTBB dependency
ffeccf6 
Dyninst no longer requires TBB (its concurrent containers were replaced with
standard-library equivalents), so remove all TBB provisioning from
rocprofiler-systems:

- Drop the ROCPROFSYS_BUILD_TBB option (CMakeLists.txt, CMakePresets.json)
- Delete cmake/DyninstTBB.cmake and cmake/Modules/FindTBB.cmake
- Remove TBB wiring from DyninstExternals.cmake and Packages.cmake
  (rocprofiler-systems-tbb interface library, find_package(TBB), Dyninst::TBB
  link, TBB include dirs)
- Remove the bundled oneTBB submodule (external/onetbb) and its .gitmodules entry
- Drop libtbb-dev from the CPack Debian dependencies
- Remove TBB from build-release.sh and the sanitizer suppression files
- Drop libtbb* from the instrumenter internal-library filters and the causal
  binary filter
- Update documentation
@sputhala-amd
Update dyninst pointer
cae8eb7
@sputhala-amd
Remove TBB from workflow files and actions
b61db0a
@sputhala-amd
Update dyninst branch
f0bd9df
@sputhala-amd
Update Dyninst pointer
1bf40ed
@sputhala-amd
Update Dyninst pointer
4980a27
@sputhala-amd
remove boost and revert Pacakges.cmake
1f8abb1
@sputhala-amd
Fix formatting and clang-tidy errors
4026ac2
@sputhala-amd
ci(rocprofiler-systems): Fix code coverage baseline build
dc2c4db 
The code coverage job builds the base branch first to produce a
coverage baseline, then rebuilds the PR in the same tree. Dropping
libtbb-dev from the container broke that baseline: the base branch
still requires a system TBB, so its configure aborted with
"Could NOT find TBB" before any coverage data was collected.

Keep libtbb-dev until the base branch no longer needs TBB. It is
inert for this branch, which no longer looks for TBB anywhere.

Also sync the Dyninst submodule when switching from the baseline to
the PR. git checkout updates the gitlink but leaves the submodule
work tree untouched, and the CMake submodule helper returns early
when the directory is already populated, so the PR half of the job
would otherwise be measured against the base branch's Dyninst.
@sputhala-amd
sputhala-amd force-pushed the users/sputhala/tbbRemovalFixSystems branch from a33e8e2 to dc2c4db Compare October 1, 2026 16:58
@dgaliffiAMD

dgaliffiAMD commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Windows sanity test appears to be halted. All other tests pass.

@dgaliffiAMD
dgaliffiAMD merged commit 41c9e94 into develop Oct 2, 2026
378 of 385 checks passed
@dgaliffiAMD
dgaliffiAMD deleted the users/sputhala/tbbRemovalFixSystems branch October 2, 2026 01:45
@systems-assistant

systems-assistant Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

@sputhala-amd sputhala-amd mentioned this pull request Oct 7, 2026
Merged
1 task done
sputhala-amd added a commit to ROCm/TheRock that referenced this pull request Oct 9, 2026
@sputhala-amd @mstankov-amd
fix(profiler): Drop removed rocprofiler-systems TBB dependency (#8834)
b1c1952 
## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

<!-- Most pull requests should be associated with at least one GitHub
issue -->

<!-- GitHub issue: #1234 -->

Rocprofiler-systems no longer depends on oneTBB.
[ROCm/rocm-systems#9876](ROCm/rocm-systems#9876)
removed the `ROCPROFSYS_BUILD_TBB` option after Dyninst stopped using
TBB ([ROCm/dyninst#26](ROCm/dyninst#26)).
TheRock still passed that flag and still suppressed vendored `libtbb*`
RPM metadata for `amdrocm-profiler` (ROCM-28385).

The current `rocm-systems` pin already contains that removal, so the
flag is unused and the RPM filter no longer matches anything that is
installed.

JIRA ID : AIPROFSYST-545

## Technical Details

<!-- Explain the changes along with any relevant GitHub links. -->
- Stop passing `-DROCPROFSYS_BUILD_TBB=ON` when configuring
`rocprofiler-systems`. Dyninst is still built with
`-DROCPROFSYS_BUILD_DYNINST=ON`.
- Remove the `amdrocm-profiler` RPM `__requires_exclude` /
`__provides_exclude` rules for `libtbb.so.*`, `libtbbmalloc.so.*`, and
`libtbbmalloc_proxy.so.*`. Those libraries are no longer shipped, so the
filter that kept vendored TBB from coupling the profiler package to
distribution TBB is obsolete. This work was done as part of the PR:
#7395

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->
- Confirm `profiler/CMakeLists.txt` no longer passes
`ROCPROFSYS_BUILD_TBB`.
- Confirm generated `amdrocm-profiler` RPM specs no longer exclude
`libtbb*` Provides or Requires.
- Let PR CI configure `rocprofiler-systems` against the current
`rocm-systems` pin.

## Test Result

<!-- Briefly summarize test outcomes. -->
Not run locally. Pending PR CI.

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md.

Co-authored-by: Milica Stankovic <milica.stankovic@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dgaliffiAMD dgaliffiAMD dgaliffiAMD approved these changes
@jrmadsen jrmadsen Awaiting requested review from jrmadsen jrmadsen is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation github actions Pull requests that update GitHub Actions code organization: ROCm project: rocprofiler-systems

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sputhala-amd @dgaliffiAMD