Skip to content

test(rocjitsu): narrow model-only execution symbol check #9860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
newling wants to merge 1 commit into from
Closed

test(rocjitsu): narrow model-only execution symbol check #9860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion emulation/rocjitsu/tests/check_model_only_symbols.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,21 @@ if(NOT _nm_result EQUAL 0)
message(FATAL_ERROR "nm failed: ${_nm_error}")
endif()

# Split gfx1250 execution helpers use an `_exec` suffix. Match their qualified
# operand-method names instead of the global `_exec(` substring, which also
# occurs in legitimate model-side helpers such as `writes_exec`.
string(REPLACE "\n" ";" _symbol_lines "${_symbols}")
foreach(_symbol IN LISTS _symbol_lines)
if(_symbol MATCHES "rocjitsu::gfx1250::Operand::.*_exec\\(")
message(
FATAL_ERROR
"model-only binary contains forbidden execution symbol: ${_symbol}"
)
endif()
endforeach()

set(_forbidden_symbols
"::execute_impl("
"_exec("
"rocjitsu::amdgpu::ComputeUnitCore"
"ds_calculate_addresses("
"flat_calculate_addresses("
Expand Down
Loading