Repository navigation
fix(hip-tests) add find_package for hsa and comgr - #9802
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
projects/hip-tests/samples/2_Cookbook/15_static_library/device_functions/CMakeLists.txt:23
- PR description says both the host_functions and device_functions samples add find_package() for both amd_comgr and hsa-runtime64, but this CMakeLists.txt only adds amd_comgr. Either add the hsa-runtime64 find_package here as well, or update the PR description to match the actual scope.
if(UNIX)
find_package(amd_comgr REQUIRED)
endif()
Contributor
Author
|
@ROCm/hip-tests-reviewers @ROCm/lrt-build-infra please review |
rakesroy
reviewed
Sep 25, 2026
rakesroy
approved these changes
Oct 1, 2026
systems-assistant Bot
pushed a commit
to ROCm/hip-tests
that referenced
this pull request
Oct 1, 2026
## Motivation Fixes the following errors in the 15_static_library HIP samples when building with Spack: ``` ld.lld: error: unable to find library -lamd_comgr ld.lld: error: unable to find library -lhsa-runtime64 ``` ## Technical Details Added `find_package` for comgr and hsa-runtime64 to the `host_functions` and `device_functions` sample CMake files to ensure that the libraries can be found during configuration ## Issue Tracking JIRA ID: ROCM-29155 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. [rocm-systems] ROCm/rocm-systems#9802 (commit 88fe493)
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes the following errors in the 15_static_library HIP samples when building with Spack:
Technical Details
Added
find_packagefor comgr and hsa-runtime64 to thehost_functionsanddevice_functionssample CMake files to ensure that the libraries can be found during configurationIssue Tracking
JIRA ID: ROCM-29155
Submission Checklist