Repository navigation
[rocjitsu] Avoid GuestKfd sysfs re-entry on reopen - #9793
Merged
Merged
Conversation
PR #9213 added physical topology validation while GuestKfd::mutex_ is held. Enumerating the real topology through std::filesystem re-enters the sysfs interposer, which attempts to acquire the same mutex and blocks subsequent /dev/kfd opens. Enumerate and inspect topology nodes through libc_passthrough so host validation reaches the real sysfs directly. Add a focused lifecycle test covering close followed by reopen. Tests: - GuestKfd timeout cluster: 9/9 passed - GuestKfd tests: 12/12 passed - Full CTest: 2720 passed, 3 skipped, 2 unrelated failures
kuhar
force-pushed
the
users/kuhar/fix-guest-kfd-reopen
branch
from
August 7, 2026 01:15
4d3a4b7 to
f9f4236
Compare
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
theSK2005
added a commit
that referenced
this pull request
Aug 7, 2026
Reconciles this branch's evolved EXEC/register-spilling work with develop's official EXEC-tracking merge (#7470) and picks up develop-only changes (#9793 GuestKfd, scoped_cfg_edges extraction, analysis-layer additions). Conflict resolution: - amdgpu_code_object.{h,cpp} and tests/code/amdgpu_code_object_test.cpp: kept this branch's version. Its kernel_descriptor_scan / KernelDescriptorInfo refactor supersedes #7470's AmdGpuCodeObject::kernel_wavefront_size and ::kernel_entry_text_offsets members, which are removed here. - patch/instrumentor.cpp: kept this branch's body (scan_kernel_descriptors + the kernel_wavefront_size free function), and added develop's analysis/exec_state.h include -- required because develop's LivenessAnalysis now holds a unique_ptr<ExecMaskAnalysis>, whose complete type is needed wherever a LivenessAnalysis is destroyed (instrumentor.cpp constructs one). - tests/patch/instrumentor_test.cpp: kept this branch's version; develop's added cases exercised the removed members (covered here by kernel_descriptor_scan_test.cpp instead). Adopted develop's analysis layer (liveness 4-arg exec signature, exec_state/def_use, scoped_cfg_edges.{h,cpp}, binary_translator refactor) which this branch had not modified. Builds clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #9213 added physical topology validation while GuestKfd::mutex_ is held. Enumerating the real topology through std::filesystem re-enters the sysfs interposer, which attempts to acquire the same mutex and blocks subsequent /dev/kfd opens.
Enumerate and inspect topology nodes through libc_passthrough so host validation reaches the real sysfs directly. Add a focused lifecycle test covering close followed by reopen.
Tests: