fix(amdsmi): address PR review findings on rocdxg_smi.cpp

14d81e4

Select commit

Loading

Failed to load commit list.

Uh oh!

There was an error while loading. Please reload this page.

Systems PR Bot on: pull_request_target 2

therock-pr-bot

Auto Label PR on: pull_request_target

labeler

AMDSMI SLES Packaging on: pull_request

SLES RPM packaging (openSUSE Leap 15.6)

ABI Compliance Check on: pull_request 2

Major ABI Compliance Check

Minor ABI Compliance Check

AMDSMI Manylinux Wheels on: pull_request 2

Build RPM Wheels (AlmaLinux 8 / manylinux_2_28)

Build Debian Wheels (Ubuntu 22.04)

AINIC RCCL Test Runner on: pull_request

ainic-test-runner

ROCR Runtime WSL on: pull_request 1

ROCR Runtime WSL Test

CodeQL on: pull_request 2

Analyze (python)

Analyze (actions)

AMDSMI DME Integration CI on: pull_request 2

DME Integration * Ubuntu22

AMDSMI CI on: pull_request 9

Build (Manylinux Gate)

Ubuntu20

Ubuntu22

Debian10

SLES

RHEL8

RHEL9

RHEL10

AlmaLinux8

AzureLinux3

AMDSMI Upgrade Downgrade on: pull_request

Debian (Ubuntu 22.04)

RPM (AlmaLinux 9)

LSTT Formatting on: pull_request 3

rdc

amdsmi

rocm-smi-lib

HIP NVIDIA CI on: pull_request

Setup

Build clr + hip-tests (NVIDIA)

HIP NVIDIA CI Summary

TheRock CI on: pull_request 3

Setup

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Build Linux Packages

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Configure test matrix

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test Sanity Check / Test sanity (shard 1 of 1)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hip-tests / Test hip-tests (shard 1 of 4)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hip-tests / Test hip-tests (shard 2 of 4)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hip-tests / Test hip-tests (shard 3 of 4)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hip-tests / Test hip-tests (shard 4 of 4)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocblas / Test rocblas (shard 1 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocblas / Test rocblas (shard 2 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocblas / Test rocblas (shard 3 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocblas / Test rocblas (shard 4 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocblas / Test rocblas (shard 5 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocblas / Test rocblas (shard 6 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hipblas / Test hipblas (shard 1 of 1)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test amdsmi / Test amdsmi (shard 1 of 1)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hipblaslt / Test hipblaslt (shard 1 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hipblaslt / Test hipblaslt (shard 2 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hipblaslt / Test hipblaslt (shard 3 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hipblaslt / Test hipblaslt (shard 4 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hipblaslt / Test hipblaslt (shard 5 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test hipblaslt / Test hipblaslt (shard 6 of 6)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocgdb-cpu / Test rocgdb-cpu (shard 1 of 1)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocgdb-gpu / Test rocgdb-gpu (shard 1 of 1)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocr-debug-agent / Test rocr-debug-agent (shard 1 of 1)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocprofiler-sdk / Test rocprofiler-sdk (shard 1 of 1)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocprofiler-systems / Test rocprofiler-systems (shard 1 of 1)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx94X-dcgpu) / Test / Test rocrtst / Test rocrtst (shard 1 of 1)

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx950-dcgpu) / Build Linux Packages

Linux (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx950-dcgpu) / Test

Linux MI455 Build (gfx125X-dcgpu) / Build Linux Packages

TheRock RCCL CI Linux

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Build Windows Packages

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Configure test matrix

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test Sanity Check / Test sanity (shard 1 of 1)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test hip-tests (PAL) / Test hip-tests (PAL) (shard 1 of 4)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test hip-tests (PAL) / Test hip-tests (PAL) (shard 2 of 4)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test hip-tests (PAL) / Test hip-tests (PAL) (shard 3 of 4)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test hip-tests (PAL) / Test hip-tests (PAL) (shard 4 of 4)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test hip-tests (ROCR) / Test hip-tests (ROCR) (shard 1 of 4) (xfail)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test hip-tests (ROCR) / Test hip-tests (ROCR) (shard 2 of 4) (xfail)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test hip-tests (ROCR) / Test hip-tests (ROCR) (shard 3 of 4) (xfail)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test hip-tests (ROCR) / Test hip-tests (ROCR) (shard 4 of 4) (xfail)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test rocblas / Test rocblas (shard 1 of 6)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test rocblas / Test rocblas (shard 2 of 6)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test rocblas / Test rocblas (shard 3 of 6)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test rocblas / Test rocblas (shard 4 of 6)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test rocblas / Test rocblas (shard 5 of 6)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test rocblas / Test rocblas (shard 6 of 6)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test hipblas / Test hipblas (shard 1 of 1)

Windows (amdsmi, hip-tests, hipblas, hipblaslt, rocblas, rocgdb-cpu, rocgdb-gpu, rocprofiler-sdk, rocprofiler-systems, rocr-debug-agent, rocrtst | gfx1151) / Test / Test hipblaslt / Test hipblaslt (shard 1 of 1)

Linux MI455 Test / Configure test matrix

Linux MI455 Test / Test Sanity Check / Test sanity (shard 1 of 1)

Linux MI455 Test / Test ${{ matrix.components.job_name }}

TheRock CI Summary

TheRock Multi-Arch CI ASAN on: pull_request

setup / setup

Linux::skip

Multi-Arch CI Summary

Code scanning results

CodeQL

Docs Preview Cleanup on: pull_request 1

cleanup

fix(amdsmi): address PR review findings on rocdxg_smi.cpp

Uh oh!

Select a check to view from the sidebar