fix(rocprofiler-sdk): TheRock fixes for SQLite3 include paths and rocm_sysdeps in RUNPATH by jrmadsen · Pull Request #9670 · ROCm/rocm-systems

jrmadsen · 2026-08-04T19:11:17Z

Motivation

Fix a few build system issues.

Technical Details

Minor reorganization to location of rocprofv3-list-avail tool library
Include $ORIGIN/.../rocm_sysdeps/lib in various RUNPATH
Ensure rocprofiler-sdk-output-library target is built with include path to sqlite3.h
- details in [Issue]: rocprofiler-sdk SQLite include path relies on incidental manylinux header TheRock#5868

Issue Tracking

ROCM-28966

Test Plan

Test Result

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

therock-pr-bot · 2026-08-04T19:12:46Z

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like `test_<name>.py` / `test_<name>.cpp` (or `<name>_test.`). Current:* code file(s) changed: `projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/list-avail/rocprofv3_avail.cpp`, `projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/list-avail/rocprofv3_avail.hpp`; no test file found
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

Copilot

Pull request overview

This PR addresses build-system integration issues in rocprofiler-sdk by reorganizing the rocprofv3-list-avail tool library, improving runtime search paths to include rocm_sysdeps, and ensuring SQLite3 headers are available to the output library without forcing SQLite linkage.

Changes:

Move/build rocprofv3-list-avail under rocprofiler-sdk-tool/list-avail and adjust CMake subdirectories accordingly.
Extend several INSTALL_RPATH/default RPATH settings to include $ORIGIN/.../rocm_sysdeps/lib.
Improve SQLite3 dependency wiring and add a *-nolink interface target to propagate SQLite3 include paths without linking.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/CMakeLists.txt	Stops building the old `rocprofiler-avail` subdir from the core SDK lib tree.
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/list-avail/rocprofv3_avail.hpp	Introduces a new exported C API header for the list-avail shared library.
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/list-avail/rocprofv3_avail.cpp	Implements the exported C API for list-avail functionality (noted issues require fixes).
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/list-avail/CMakeLists.txt	Adds build/install rules and updated `INSTALL_RPATH` for `rocprofv3-list-avail`.
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/CMakeLists.txt	Adds `list-avail` subdirectory to the tool build.
projects/rocprofiler-sdk/source/lib/python/CMakeLists.txt	Extends Python library RPATH defaults to include `rocm_sysdeps`.
projects/rocprofiler-sdk/source/lib/output/CMakeLists.txt	Links output library to the SQLite3 nolink interface to obtain `sqlite3.h` include paths.
projects/rocprofiler-sdk/external/CMakeLists.txt	Makes SQLite3 target detection more robust and configures a SQLite3 “nolink” interface target.
projects/rocprofiler-sdk/cmake/rocprofiler_interfaces.cmake	Declares an imported `rocprofiler-sdk-sqlite3-nolink` interface target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-08-30T00:25:47Z

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

Add new commits
Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

github-actions · 2026-09-05T00:22:32Z

This pull request has been automatically closed due to inactivity (30 days with no updates).

If you'd like to continue working on this, feel free to reopen the PR or create a new one.

- this source should be in `source/lib/rocprofiler-sdk-tool/list-avail`

- important for Python bindings - added to rocprofv3 tool and rocprofv3 list avail

- #6664 removed the include directory for rocprofiler-sdk-output-library - detailed explanation in ROCm/TheRock#5868 - added rocprofiler-sdk-sqlite3-nolink target

Copilot

🟡 Changes recommended

Unresolved critical SQLite linkage and missing API implementation, plus moderate correctness and resource-cleanup issues.

1 open finding

Missing SQLite target in list-avail link dependencies · New

🧠 Review effort: Lite

bernardogv · 2026-10-08T02:00:28Z

Tested this on a clean Ubuntu 26.04 build for TheRock #5868. It fixes it.

Setup: TheRock 4c6a8039 (rocm-systems d08190589c), Ubuntu 26.04.1, -DTHEROCK_AMDGPU_TARGETS=gfx1151.
libsqlite3-dev removed, so there is no sqlite3.h in /usr/include or /usr/local/include. Each
run is ninja rocprofiler-sdk+expunge followed by ninja rocprofiler-sdk+build:

rocprofiler-sdk	result
without this PR	fails: `extract_data_type.hpp:27:10: fatal error: 'sqlite3.h' file not found` (9 sources)
with this PR applied	builds (rc=0), header found through TheRock's bundled SQLite

The diff applied cleanly to that older rocm-systems revision. I only checked the build, not the RUNPATH
changes or rocprofv3-list-avail at runtime.

systems-assistant · 2026-10-09T08:54:24Z

TheRock Submodule Bump Activity

Newest first

2026-10-09 — Included in TheRock via ROCm/TheRock#8862.

Both fixes (ROCm/rocm-systems#9670 and #13075) are in the rocm-systems submodule since ROCm#8862.

…m_sysdeps in RUNPATH (#9670) ## Motivation  Fix a few build system issues. ## Technical Details  - Minor reorganization to location of rocprofv3-list-avail tool library - Include `$ORIGIN/.../rocm_sysdeps/lib` in various RUNPATH - Ensure `rocprofiler-sdk-output-library` target is built with include path to `sqlite3.h` - details in ROCm/TheRock#5868 ## Issue Tracking    ROCM-28966 ## Test Plan  ## Test Result  ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. --------- Co-authored-by: Young Hui <young.hui@amd.com>

Copilot AI lite review requested due to automatic review settings August 4, 2026 19:11

jrmadsen requested review from a team as code owners August 4, 2026 19:11

github-actions Bot added the project: rocprofiler-sdk label Aug 4, 2026

Copilot started reviewing on behalf of jrmadsen August 4, 2026 19:12

View session

Copilot AI reviewed Aug 4, 2026

View reviewed changes

systems-assistant Bot added the organization: ROCm label Aug 4, 2026

PeterCDMcLean mentioned this pull request Aug 12, 2026

[Issue] rocprofiler-systems configure fails on build hosts without Tcl: profiler-hub's bundled SQLite3 amalgamation requires tclsh #10059

Open

github-actions Bot added the Stale PR has no activity for 25+ days label Aug 30, 2026

github-actions Bot closed this Sep 5, 2026

jrmadsen reopened this Sep 30, 2026

jrmadsen force-pushed the users/jrmadsen/rocprof-sdk-include-and-rpath-fixes branch from c0e6c63 to 0fd2a39 Compare September 30, 2026 19:12

jrmadsen removed the Stale PR has no activity for 25+ days label Sep 30, 2026

ApoKalipse-V approved these changes Sep 30, 2026

View reviewed changes

MythreyaK approved these changes Oct 1, 2026

View reviewed changes

Comment thread projects/rocprofiler-sdk/external/CMakeLists.txt Resolved

jrmadsen and others added 4 commits October 7, 2026 12:49

Move source/lib/rocprofiler-sdk/rocprofiler-avail

856ae5a

- this source should be in `source/lib/rocprofiler-sdk-tool/list-avail`

Fix RUNPATH for libraries using rocm_sysdeps

6193c23

- important for Python bindings - added to rocprofv3 tool and rocprofv3 list avail

Fix implicit SQLite include path

4b0f6a1

- #6664 removed the include directory for rocprofiler-sdk-output-library - detailed explanation in ROCm/TheRock#5868 - added rocprofiler-sdk-sqlite3-nolink target

formatting fix

a944aae

Copilot AI lite review requested due to automatic review settings October 7, 2026 17:38

yhuiYH force-pushed the users/jrmadsen/rocprof-sdk-include-and-rpath-fixes branch from 0fd2a39 to a944aae Compare October 7, 2026 17:38

Copilot started reviewing on behalf of jrmadsen October 7, 2026 17:39

View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Comment thread projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/CMakeLists.txt Resolved

bernardogv mentioned this pull request Oct 8, 2026

docs: add Ubuntu 26.04 notes to the environment setup guide ROCm/TheRock#8848

Open

1 task done

yhuiYH merged commit 62a555a into develop Oct 8, 2026
241 of 248 checks passed

yhuiYH deleted the users/jrmadsen/rocprof-sdk-include-and-rpath-fixes branch October 8, 2026 13:43

bernardogv added a commit to bernardogv/TheRock that referenced this pull request Oct 10, 2026

docs: drop the sqlite3 and GCC 15 workarounds for Ubuntu 26.04

c47f440

Both fixes (ROCm/rocm-systems#9670 and #13075) are in the rocm-systems submodule since ROCm#8862.

bgopesh mentioned this pull request Oct 14, 2026

docs(rocprofiler-sdk): add 1.4.2 CHANGELOG entries for ROCm 10.2.0 #13452

Merged

1 task done

Navigation Menu

Repository navigation

fix(rocprofiler-sdk): TheRock fixes for SQLite3 include paths and rocm_sysdeps in RUNPATH - #9670

fix(rocprofiler-sdk): TheRock fixes for SQLite3 include paths and rocm_sysdeps in RUNPATH#9670
yhuiYH merged 4 commits into
developfrom
users/jrmadsen/rocprof-sdk-include-and-rpath-fixes

jrmadsen commented Aug 4, 2026

Uh oh!

therock-pr-bot Bot commented Aug 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Aug 30, 2026

Uh oh!

github-actions Bot commented Sep 5, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

bernardogv commented Oct 8, 2026

Uh oh!

Uh oh!

systems-assistant Bot commented Oct 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jrmadsen commented Aug 4, 2026

Motivation

Technical Details

Issue Tracking

Test Plan

Test Result

Submission Checklist

Uh oh!

therock-pr-bot Bot commented Aug 4, 2026

✅ All Policy Checks Passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions Bot commented Aug 30, 2026

Uh oh!

github-actions Bot commented Sep 5, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

bernardogv commented Oct 8, 2026

Uh oh!

Uh oh!

systems-assistant Bot commented Oct 9, 2026

TheRock Submodule Bump Activity

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants