Repository navigation
refactor(amdsmi): remove driver reload API and related functions - #9401
Closed
dmitrii-galantsev wants to merge 6 commits into
Closed
dmitrii-galantsev wants to merge 6 commits into
dmitrii-galantsev wants to merge 6 commits into
Conversation
Signed-off-by: gabrpham <Gabriel.Pham@amd.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
github-actions
Bot
added
documentation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
gabrpham
approved these changes
Jul 28, 2026
marifamd
approved these changes
Jul 28, 2026
Contributor
|
#8575 merged, no need for this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Static code scan revealed potentially vulnerable code in the driver reload API.
Technical Details
amdsmi_gpu_driver_reload()made use of an insecure pattern. The functionality had already been removed from the amdsmi CLI, so we resolved the vulnerability by removing the API and its Python binding entirely, along with the underlying ROCm SMI driver-reload plumbing.JIRA ID
JIRA ID : ROCM-26658
Test Plan
N/A
Test Result
N/A
Submission Checklist
N/A
this is duplicate of #8575 because it got stuck as non-mergeable