Repository navigation
Revert "feat(hipfile): Add getStats functions to public api (#8252)" - #9260
Merged
Merged
Conversation
This reverts commit a3c059c.
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the recently added hipFile “Stats API” (and its dispatch-table wiring/tests) because it is currently causing build failures in profiler-related code paths, restoring the previous public API surface and dispatch ABI expectations.
Changes:
- Removes the public Stats API types and entrypoints (
hipFileGetStatsL1/L2/L3) fromhipfile.hand their runtime implementations. - Removes the Stats function pointers from the hipFile dispatch table (api-trace) and updates ABI/versioning assertions accordingly.
- Removes/updates unit tests that validated the Stats API and dispatch-table population for those entries.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| projects/hipfile/test/amd_detail/hipfile-api.cpp | Removes Stats API unit tests and related includes. |
| projects/hipfile/test/amd_detail/api_trace.cpp | Updates dispatch-table tests to stop expecting Stats API function pointers. |
| projects/hipfile/src/amd_detail/hipfile.cpp | Removes hipFileGetStatsL1/L2/L3 runtime implementations. |
| projects/hipfile/src/amd_detail/api_trace/api-trace.cpp | Stops populating Stats API dispatch entries; updates ABI enforcement/versioning assertions for the smaller table. |
| projects/hipfile/src/amd_detail/api_trace/api-trace-internal.h | Removes internal declarations for the Stats API runtime functions. |
| projects/hipfile/src/amd_detail/api_trace/api-dispatch-interface.cpp | Removes exported C shims for hipFileGetStatsL1/L2/L3. |
| projects/hipfile/include/hipfile.h | Removes the public Stats API (types, macros, and function declarations). |
| projects/hipfile/include/hipfile-api-trace.h | Removes Stats function pointer typedefs/members and rolls HIPFILE_RUNTIME_API_TABLE_STEP_VERSION back to 0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
The nightly system tests will fail on this PR due to a known bug in amdgpu. This has nothing to do with the code changes in this PR. |
john00003
approved these changes
Jul 25, 2026
systems-assistant Bot
pushed a commit
to ROCm/hipFile
that referenced
this pull request
Jul 25, 2026
(#8252)" (#9260) ## Motivation The stats API changes are causing build failures in the profiler code. We are reverting this temporarily and will set up a PR once we've ensured that our API changes will no longer break the profiler. ## Technical Details This reverts commit a3c059c50f9268f5ccb39af3f581213d39a540d8. ## Issue Tracking JIRA ID: AIHIPFILE-240 ## Test Plan CI passes ## Test Result Success ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. [rocm-systems] ROCm/rocm-systems#9260 (commit 3aabde9)
amd-josnarlo
pushed a commit
that referenced
this pull request
Jul 28, 2026
…9260) ## Motivation The stats API changes are causing build failures in the profiler code. We are reverting this temporarily and will set up a PR once we've ensured that our API changes will no longer break the profiler. ## Technical Details This reverts commit a3c059c. ## Issue Tracking JIRA ID: AIHIPFILE-240 ## Test Plan CI passes ## Test Result Success ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The stats API changes are causing build failures in the profiler code. We are reverting this temporarily and will set up a PR once we've ensured that our API changes will no longer break the profiler.
Technical Details
This reverts commit a3c059c.
Issue Tracking
JIRA ID: AIHIPFILE-240
Test Plan
CI passes
Test Result
Success
Submission Checklist