Skip to content

test(rccl): add unit tests for device API #9188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-sannikov merged 5 commits into from
Aug 5, 2026
Merged

test(rccl): add unit tests for device API #9188

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec8d6d9
RCCL: Added GIN device api tests
alexander-sannikov Jul 24, 2026
77f37aa
Merge branch 'develop' into users/asanniko/AICOMRCCL-802
alexander-sannikov Jul 27, 2026
d3d28a0
Merge branch 'develop' into users/asanniko/AICOMRCCL-802
alexander-sannikov Jul 28, 2026
d2fc018
fixed review comments
alexander-sannikov Jul 28, 2026
8ddaf87
Removed excessive tests
alexander-sannikov Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions projects/rccl/src/include/nccl_device/impl/vector__funcs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,13 @@ NCCL_DEVICE_INLINE EltPack<int8_t, 4> reducePack(OpSum<int8_t> const& /* red */,
Int8PackAccess4 out;
aa.pack = a;
bb.pack = b;
#if defined(NCCL_HIP_PLATFORM) || defined(__HIP_PLATFORM_AMD__)
#pragma unroll
for (int i = 0; i < 4; ++i)
out.pack.elts()[i] = static_cast<int8_t>(aa.pack.elts()[i] + bb.pack.elts()[i]);
#else
Comment thread
alexander-sannikov marked this conversation as resolved.
Resolved
out.word = __vadd4(aa.word, bb.word);
#endif
return out.pack;
}

Expand Down
1 change: 1 addition & 0 deletions projects/rccl/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,7 @@ if(BUILD_TESTS)
GinNcclTimeoutMPITests.cpp
SymmetricKernelMPITests.cpp
SymmetricWindowMPITests.cpp
DeviceApiMPITests.cpp
CommNetMismatchMPITests.cpp
)

Expand Down
Loading
Loading