Repository navigation
[policy-bot] Ignore PR description comments in policy checks - #8873
Merged
Merged
Conversation
Assisted-by: OpenAI Codex
Remove stale test-only Policy fields and ignore Python cache directories. Assisted-by: OpenAI Codex
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Member
Author
|
This didn't need to run TheRock CI. I'll update the path filters in https://github.com/ROCm/rocm-systems/blob/develop/.github/scripts/therock_configure_ci.py |
amd-shiraz
approved these changes
Jul 27, 2026
amd-shiraz
left a comment
amd-shiraz
left a comment
Contributor
There was a problem hiding this comment.
lgtm! this can go in independently to be in sync with therock
amd-josnarlo
pushed a commit
that referenced
this pull request
Jul 28, 2026
## Motivation We'd like to put example text in the pull request template without having that text pass the policy checks itself. This can be achieved through HTML/markdown comments, so long as the policy bot does not evaluate the text in comments. * Follow-up to #8497 which added `<!-- GitHub issue: #1234 -->` to `.github/pull_request_template.md` * Progress on #7842 ## Test Plan `python tools\systems_pr_bot\test_policy_check_ut.py` (not yet running on CI, or fully passing) passes the new tests ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We'd like to put example text in the pull request template without having that text pass the policy checks itself. This can be achieved through HTML/markdown comments, so long as the policy bot does not evaluate the text in comments.
<!-- GitHub issue: https://github.com/ROCm/rocm-systems/issues/1234 -->to.github/pull_request_template.mdTest Plan
python tools\systems_pr_bot\test_policy_check_ut.py(not yet running on CI, or fully passing) passes the new testsSubmission Checklist