Skip to content
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a989c7c
ROCM-27216 - ihipLaunchKernel catch all errors, except InvalidSymbol
jiabaxie Jul 11, 2026
357b0a5
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Jul 20, 2026
12c91f7
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Jul 21, 2026
452da68
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Jul 21, 2026
987bb93
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Jul 27, 2026
d8423d0
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Jul 27, 2026
10c2294
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Jul 28, 2026
b45ebda
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Jul 28, 2026
b4ead23
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Aug 7, 2026
ad3b41c
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Aug 10, 2026
d99be17
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Aug 11, 2026
65c2017
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Aug 12, 2026
95f6f5c
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Aug 13, 2026
6ae6ba4
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Aug 13, 2026
73df303
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Aug 17, 2026
3f27487
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Aug 17, 2026
b0078ac
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Aug 19, 2026
05cc627
Merge branch 'develop' into users/jiabaxie/ROCM-27216
jiabaxie Aug 24, 2026
59aafdb
Updated propagate all other errors option
jiabaxie Aug 24, 2026
0bcfa20
Merge branch 'develop' into users/jiabaxie/ROCM-27216
litvaOo Aug 25, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions projects/clr/hipamd/src/hip_platform.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -718,23 +718,21 @@ hipError_t ihipLaunchKernel(const void* hostFunction, dim3 gridDim, dim3 blockDi
const int deviceId = hip::Stream::DeviceId(stream);

const auto [hip_error, func] = [&]() -> std::pair<hipError_t, hipFunction_t> {
hipFunction_t f;
hipFunction_t f = nullptr;
const hipError_t err = PlatformState::Instance().StatCO().GetFunc(&f, hostFunction, deviceId);

// Propagate specific invalid code object errors
if (err == hipErrorInvalidKernelFile ||
err == hipErrorInvalidDeviceFunction ||
err == hipErrorInvalidImage ||
err == hipErrorNotSupported) { // ROCM_KPACK_ENABLED=OFF
return {err, nullptr};
}
// If successful lookup with valid function, use it
if (err == hipSuccess && f) {
return {hipSuccess, f};
}

// Fallback: assume it's a hip function type
return {hipSuccess, reinterpret_cast<hipFunction_t>(const_cast<void*>(hostFunction))};
// Only take fallback for hipErrorInvalidSymbol (not in registered table)
if (err == hipErrorInvalidSymbol) {
return {hipSuccess, reinterpret_cast<hipFunction_t>(const_cast<void*>(hostFunction))};
}

// Propagate all other errors
return {err != hipSuccess ? err : hipErrorInvalidDeviceFunction, nullptr};
}();

if (hip_error != hipSuccess) {
Expand Down
Loading