Skip to content

fix(kfdtest): [AILIKFD-40] fix overwirte of CMAKE_EXE_LINKER_FLAGS - #8042

Merged
andmar-amd merged 1 commit into
developfrom
users/andmar-amd/fix-asan-linker-flags
Jul 3, 2026
Merged

andmar-amd merged 1 commit into
developfrom
users/andmar-amd/fix-asan-linker-flags

Conversation

@andmar-amd

@andmar-amd andmar-amd commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

The ASAN configuration was overwriting CMAKE_EXE_LINKER_FLAGS rather than appending, causing any previously set linker flags to be lost.

Motivation

Technical Details

JIRA ID

Resolves AILIKFD-40

Test Plan

Test Result

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jun 30, 2026 •

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass —
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the ASAN configuration for kfdtest so that enabling AddressSanitizer no longer overwrites existing executable linker flags, preserving any previously configured linker options.

Changes:

  • Update ASAN logic to append -fsanitize=address to CMAKE_EXE_LINKER_FLAGS rather than replacing it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@andmar-amd
andmar-amd force-pushed the users/andmar-amd/fix-asan-linker-flags branch 3 times, most recently from 6fb19c4 to baa92c8 Compare July 2, 2026 18:45
@andmar-amd andmar-amd changed the title fix(kfdtest): append to CMAKE_EXE_LINKER_FLAGS instead of overwriting fix(kfdtest): [AILIKFD-40] append to CMAKE_EXE_LINKER_FLAGS instead of overwriting Jul 2, 2026
@andmar-amd andmar-amd changed the title fix(kfdtest): [AILIKFD-40] append to CMAKE_EXE_LINKER_FLAGS instead of overwriting fix(kfdtest): [AILIKFD-40] fix overwirte of CMAKE_EXE_LINKER_FLAGS Jul 3, 2026
The ASAN configuration was overwriting CMAKE_EXE_LINKER_FLAGS rather
than appending, causing any previously set linker flags to be lost.

Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>
@andmar-amd
andmar-amd force-pushed the users/andmar-amd/fix-asan-linker-flags branch from baa92c8 to 6ce07e5 Compare July 3, 2026 02:23
@andmar-amd
andmar-amd merged commit 62602f4 into develop Jul 3, 2026
59 of 62 checks passed
@andmar-amd
andmar-amd deleted the users/andmar-amd/fix-asan-linker-flags branch July 3, 2026 15:15
systems-assistant Bot pushed a commit to ROCm/ROCR-Runtime that referenced this pull request Jul 3, 2026
 overwriting

The ASAN configuration was overwriting CMAKE_EXE_LINKER_FLAGS rather
than appending, causing any previously set linker flags to be lost.

Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>
[rocm-systems] ROCm/rocm-systems#8042 (commit 62602f4)
@andmar-amd

Copy link
Copy Markdown
Contributor Author

Greetings @kentrussell

Thanks for the approval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants