Repository navigation
fix(kfdtest): [AILIKFD-40] fix overwirte of CMAKE_EXE_LINKER_FLAGS - #8042
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
There was a problem hiding this comment.
Pull request overview
This PR fixes the ASAN configuration for kfdtest so that enabling AddressSanitizer no longer overwrites existing executable linker flags, preserving any previously configured linker options.
Changes:
- Update ASAN logic to append
-fsanitize=addresstoCMAKE_EXE_LINKER_FLAGSrather than replacing it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6fb19c4 to
baa92c8
Compare
The ASAN configuration was overwriting CMAKE_EXE_LINKER_FLAGS rather than appending, causing any previously set linker flags to be lost. Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com>
baa92c8 to
6ce07e5
Compare
overwriting The ASAN configuration was overwriting CMAKE_EXE_LINKER_FLAGS rather than appending, causing any previously set linker flags to be lost. Co-Authored-By: Claude Sonnet 4 (1M context) <noreply@anthropic.com> [rocm-systems] ROCm/rocm-systems#8042 (commit 62602f4)
|
Greetings @kentrussell Thanks for the approval! |
The ASAN configuration was overwriting CMAKE_EXE_LINKER_FLAGS rather than appending, causing any previously set linker flags to be lost.
Motivation
Technical Details
JIRA ID
Resolves AILIKFD-40
Test Plan
Test Result
Submission Checklist