refactor(rocshmem/gda): refactor QueuePair class by omor1 · Pull Request #7217 · ROCm/rocm-systems

omor1 · 2026-06-13T00:10:39Z

Motivation

The QueuePair class [gda/queue_pair.{hpp,cpp}] functions as three classes in a trenchcoat that masquerade as a single class; it simultaneously has functionality for:

common device-side QP initialization and management, including host functions for registering additional local buffers; and
provider-specific send and completion queue management, including WQE posting and CQ polling; and
a multiplexing low-level interface that dispatches to the provider-specific functions based on which is at use at execution time; and
a high-level SHMEM-like communication interface that dispatches to the low-level interface.

Maintaining this complex class and its many interactions is complicated and has led to changes intended for one GDA provider causing unintended impacts on the others, as well making several types of optimizations far more difficult. The goal of this PR is to refactor this single class into several distinct classes that will help improve code readability and maintainability, as well as restoring the ability to compile directly for a specific GDA provider without runtime dispatch.

The end goal is to allow much of the QueuePair and GDA initialization code to be abstracted as a separate library that can be consumed by both rocSHMEM and other users of similar functionality, such as the RCCL-GIN GDA backend.

Technical Details

template <typename Provider> class QueuePairSHMEM
- gda/queue_pair.hpp
- High-level SHMEM-like communication interface
- Uses CRTP to dispatche to low-level functions implemented by Provider
- Contains no non-static data members
template <typename Provider> class QueuePairBase
- gda/queue_pair.hpp
- Common device-side QP initialization and management
- Inherits from QueuePairSHMEM<Provider>
class QueuePairIONIC
- gda/ionic/queue_pair_ionic.{hpp,cpp}
- Implements send and completion queue management for AMD Pensando 'ionic' RDMA NICs
- Inherits from QueuePairBase<QueuePairIONIC>
class QueuePairBNXT
- gda/bnxt/queue_pair_bnxt.{hpp,cpp}
- Implements send and completion queue management for Broadcom 'bnxt' RDMA NICs
- Inherits from QueuePairBase<QueuePairBNXT>
class QueuePairMLX5
- gda/mlx5/queue_pair_mlx5.{hpp,cpp}
- Implements send and completion queue management for NVIDIA/Mellanox 'mlx5' RDMA NICs
- Inherits from QueuePairBase<QueuePairMLX5>
class QueuePairMux
- gda/queue_pair_mux.{hpp,cpp}
- Multiplexing union-like class that implements the low-level interface by dispatching to an underlying GDA provider
- Holds one of QueuePairIONIC, QueuePairBNXT, or QueuePairMLX5
- Inherits from QueuePairSHMEM<QueuePairMux>
alias QueuePair
- gda/queue_pair_provider.hpp
- Alias for one of QueuePairIONIC, QueuePairBNXT, QueuePairMLX5, or QueuePairMux
- Simplifies generic use of any of the Queue Pair classes
- Selected by compile-time configuration

JIRA ID

JIRA ID: AIROCSHMEM-424

Test Plan

Use the rocSHMEM functional tests to validate correctness and performance regression analysis against current develop HEAD.

Test Result

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

omor1 · 2026-06-13T00:19:35Z

TODO:

Rebase on top of develop
- 0a89fd1
- 62b6284
- 4ca9fab
- 8ef949afee2a8a5c2a7f22f187fff6f4cc5df53a
Replace QueuePairMux::provider non-static data member with __constant__ memory, see [rocshmem] use constmem for backend and provider muxing #6880
- 795eb8d
Change post_wqe function interface to consume lkey and rkey directly
- c7a4fe6f893d66e503f29e30fe5fccdeb0579882
Improve optimization template parameter interface
- b5c1293
Move QueuePairSHMEM functionality out of queue_pair.hpp and into GDAContext
Add QueuePairHostProxy for host-side management of Queue Pair classes, so that the device-side classes don't have host-only data members
Additional refactor of QueuePairIONIC code:
- Remove support for non-collapsed CQ (untested, dead code)
- Add support for optimization template parameters

omor1 · 2026-06-24T02:52:16Z

GIN will need to use QueuePair::to_provider_endianness<T>(T val) for passing explicit lkey/rkey to post_wqe_rma/amo, it expects them in the Provider's endianness. NCCL GIN GDAKI stores the lkeys and rkeys in BE, doing the byte swap once during memory registration.

therock-pr-bot · 2026-06-30T00:37:13Z

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

therock-pr-bot · 2026-06-30T00:37:14Z

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Copilot

Pull request overview

Refactors rocSHMEM’s GDA QueuePair implementation by splitting the prior monolithic class into provider-specific queue-pair classes (IONIC/BNXT/MLX5) plus an optional runtime-dispatching mux, enabling cleaner separation of responsibilities and compile-time provider selection.

Changes:

Introduces provider-specific QueuePair* implementations and a QueuePairMux runtime-dispatch wrapper, with QueuePair selected via a new queue_pair_provider.hpp alias.
Updates GDA backend initialization and device-side context code to use the new QueuePair API (including new posting options usage).
Updates build system and bitcode compilation to support GDA_MUX and provider-specific compilation/selection.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
projects/rocshmem/src/gda/queue_pair.cpp	Removes the legacy monolithic `QueuePair` implementation (replaced by refactored classes).
projects/rocshmem/src/gda/queue_pair_provider.hpp	Adds `QueuePair` alias selection for provider/mux at compile time.
projects/rocshmem/src/gda/queue_pair_mux.hpp	Adds mux `QueuePair` type and device-side dispatch helpers.
projects/rocshmem/src/gda/queue_pair_mux.cpp	Implements mux union lifecycle and host-side dispatch helpers.
projects/rocshmem/src/gda/mlx5/queue_pair_mlx5.hpp	Adds MLX5 provider-specific queue pair class interface + templated posting.
projects/rocshmem/src/gda/mlx5/queue_pair_mlx5.cpp	Moves MLX5 queue-pair implementation out of legacy code into provider class.
projects/rocshmem/src/gda/mlx5/provider_gda_mlx5.hpp	Refactors MLX5 inline decision helper to a template form.
projects/rocshmem/src/gda/mlx5/CMakeLists.txt	Adjusts MLX5 sources inclusion based on provider build option.
projects/rocshmem/src/gda/mlx5/backend_gda_mlx5.cpp	Updates MLX5 GPU QP initialization to construct new provider QP object.
projects/rocshmem/src/gda/ionic/queue_pair_ionic.hpp	Adds IONIC provider-specific queue pair class interface + templated posting.
projects/rocshmem/src/gda/ionic/queue_pair_ionic.cpp	Moves IONIC queue-pair implementation out of legacy code into provider class.
projects/rocshmem/src/gda/ionic/provider_gda_ionic.hpp	Introduces device-queue structs and namespaces for IONIC provider internals.
projects/rocshmem/src/gda/ionic/CMakeLists.txt	Adjusts IONIC sources inclusion based on provider build option.
projects/rocshmem/src/gda/ionic/backend_gda_ionic.cpp	Updates IONIC GPU QP initialization to construct new provider QP object.
projects/rocshmem/src/gda/bnxt/queue_pair_bnxt.hpp	Adds BNXT provider-specific queue pair class interface + templated posting.
projects/rocshmem/src/gda/bnxt/queue_pair_bnxt.cpp	Moves BNXT queue-pair implementation out of legacy code into provider class.
projects/rocshmem/src/gda/bnxt/provider_gda_bnxt.hpp	Adds missing includes and constructors for BNXT device queue structs.
projects/rocshmem/src/gda/bnxt/CMakeLists.txt	Adjusts BNXT sources inclusion based on provider build option.
projects/rocshmem/src/gda/bnxt/backend_gda_bnxt.cpp	Updates BNXT GPU QP initialization to construct new provider QP object.
projects/rocshmem/src/gda/gda_enums.hpp	Changes provider enum to `enum class` and keeps `GDAProvider` alias.
projects/rocshmem/src/gda/debug_gda.hpp	Minor annotation update (`[[maybe_unused]]`).
projects/rocshmem/src/gda/context_gda_tmpl_device.hpp	Updates device-side calls to new QP AMO/RMA APIs and posting options.
projects/rocshmem/src/gda/context_gda_device.hpp	Switches include to `queue_pair_provider.hpp`.
projects/rocshmem/src/gda/backend_gda.hpp	Updates includes and provider-guarded declarations for backend init paths.
projects/rocshmem/src/gda/backend_gda.cpp	Updates buffer registration paths and GPU QP setup/teardown for refactor.
projects/rocshmem/src/gda/CMakeLists.txt	Removes legacy queue_pair.cpp and conditionally adds mux sources.
projects/rocshmem/CMakeLists.txt	Adds `GDA_MUX` option, provider-count checks, and backend string updates.
projects/rocshmem/cmake/rocshmem_config.h.in	Adds `GDA_MUX` config define.
projects/rocshmem/cmake/DeviceBitcode.cmake	Updates bitcode sources to compile mux and provider-specific QP sources.

Comments suppressed due to low confidence (1)

projects/rocshmem/src/gda/backend_gda.cpp:587

Host-side buffer_register/buffer_unregister calls QueuePair methods through gpu_qps, but gpu_qps is allocated with hipMalloc (device memory). Under standard HIP semantics the host cannot dereference/call methods on device allocations, so registration/destruction will be invalid (and was previously done via a host mirror + hipMemcpy). Consider restoring a host-resident QP array for host-only operations (MR map + buffer_info updates) and explicitly copying the device-visible portions to gpu_qps, or switching gpu_qps to a host-accessible allocation (e.g., hipMallocManaged/hipHostMalloc with the required coherency guarantees).

  /* Register with QPs */
  for (size_t i = 0; i < num_qps; i++) {
    err = gpu_qps[i].buffer_register(addr, length);
    if (ROCSHMEM_SUCCESS != err) {
      qp_registration_failed = true;
    }
  }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

abouteiller

Ongoing review

Refactor monolithic QueuePair class into: * template class QueuePairSHMEM<typename Provider> a CRTP mixin class implementing a high-level SHMEM-like interface * template class QueuePairBase<typename Provider> : public QueuePairSHMEM<Provider> a CRTP base class implementing data members and intialization common to all QueuePair provider implementations * QueuePairMLX5 : public QueuePairBase<QueuePairMLX5> a concrete QueuePair implementation for mlx5 * QueuePairGeneric : public QueuePairSHMEM<QueuePairGeneric> a variant (tagged union) class that dispatches to an underlying concrete implementation at runtime * QueuePairBNXT and QueuePairIONIC implementations will follow shortly * extern "C" ::rocshmem_gin_init_constmem definition has been moved to constmem.cpp Signed-off-by: Omri Mor <Omri.Mor@amd.com>

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

amd-argus

ARGUS

This PR changes 10,126 lines across 66 files. A change this size is hard to review
well, for a person and for this bot alike: reviewers lose the thread, defects hide in the
volume, and the feedback arrives too late to be cheap to act on. Splitting it into a
stacked pull request
gives each piece a reviewable diff and keeps the history. This review covers the whole change
regardless.

Bottom line: Nothing new worth raising; still open from earlier: queue_pair_host.cpp:108 and 4 more. Worth clearing before approval.

_{Comment @argus review to re-run, or @argus re-review after pushing.}

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

A PostOpt object could be constructed with arbitrary types. It wouldn't do anything, but was semantically nonsense, so reject such arguments. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

Signed-off-by: Omri Mor <Omri.Mor@amd.com> Reported-by: amd-argus in #7217 review

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

amd-argus

ARGUS

This PR changes 10,153 lines across 66 files. A change this size is hard to review
well, for a person and for this bot alike: reviewers lose the thread, defects hide in the
volume, and the feedback arrives too late to be cheap to act on. Splitting it into a
stacked pull request
gives each piece a reviewable diff and keeps the history. This review covers the whole change
regardless.

Bottom line: Nothing new worth raising; still open from earlier: CMakeLists.txt:1110 and 8 more. Worth clearing before approval.

_{Comment @argus review to re-run, or @argus re-review after pushing.}

omor1 · 2026-09-20T00:05:45Z

@argus re-review full

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

…aders Several headers derived from rdma-core or the Linux kernel contain copyright notices that refer to a COPYING file. Clarify that this file is located in the origin source tree, not our own. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

amd-argus

ARGUS

This PR changes 9,818 lines across 70 files. A change this size is hard to review
well, for a person and for this bot alike: reviewers lose the thread, defects hide in the
volume, and the feedback arrives too late to be cheap to act on. Splitting it into a
stacked pull request
gives each piece a reviewable diff and keeps the history. This review covers the whole change
regardless.

Bottom line: Nothing new worth raising; still open from earlier: CMakeLists.txt:1067 and 1 more. Worth clearing before approval.

_{Comment @argus review to re-run, or @argus re-review after pushing.}

PRs #10785 and #7217 accidentally reintroduced some __hip_atomic builtins. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

systems-assistant · 2026-09-25T05:04:12Z

TheRock Submodule Bump Activity

Newest first

2026-09-25 — Included in TheRock via ROCm/TheRock#8470.

## Motivation The QueuePair class in src/gda/queue_pair.{hpp,cpp} operates as "three classes in a trenchcoat" that masquerade as a single class; it simultaneously has functionality for: - common device-side QP initialization and management, including host functions for registering additional local buffers; and - provider-specific send and completion queue management, including WQE posting and CQ polling; and - a multiplexing low-level interface that dispatches to the provider-specific functions based on which is at use at execution time; and - an intermediate-level interface that hides details such as opcodes, implemented on top of the low-level interface. Maintaining this complex class and its many interactions is complicated, has led to changes in one GDA provider causing unintended impacts on others, limits GDA provider performance, and hinders development of new features. This PR refactors the single QueuePair class into several distinct classes, which thereby improves code readability, maintainability, and modularity; allows for independent unit testing of QueuePair functionality; restores the ability to compile directly for specific GDA providers without runtime dispatch; and paves the way for the decoupling of the RCCL-GIN GDA backend from rocSHMEM. ## Technical Details ### rocSHMEM A class hierarchy is implemented using CRTP: - rocshmem::QueuePairInterface<typename Provider> A common mid-level interface used directly by GIN GDA and indirectly by rocSHMEM, via the high-level interface. - rocshmem::QueuePairSHMEM<typename Provider> : QueuePairInterface<Provider> A common high-level interface that is used directly by rocshmem::GDAContext. - rocshmem::QueuePairDevice<typename Provider> : QueuePairSHMEM<Provider> A common base class for concrete GDA provider QueuePair types. - rocshmem::QueuePairTraits<typename Provider> Used by the CRTP base classes to query provider-specific attributes. - rocshmem::QueuePairHost Used to manage the lifetime of memory used by QueuePairDevice instances. These are used to implement the concrete GDA provider QueuePair classes: - rocshmem::QueuePairIONIC GDA provider for AMD Pensando RDMA networks using the 'ionic' driver. - rocshmem::QueuePairBNXT GDA provider for Broadcom RDMA networks using the 'bnxt' driver. - rocshmem::QueuePairMLX5 GDA provider for Mellanox RDMA networks using the 'mlx5' driver. There are two additional 'meta' provider QueuePair classes: - rocshmem::QueuePairMux Supports runtime GDA provider selection via a specialized tagged union. - rocshmem::QueuePairMock Mock QueuePair object for unit tests. A compile-time mechanism allows callers of the QueuePair communication APIs to selectively override certain internal safety and consistency mechanisms. All QueuePair device code is header-only; this removes the necessity of linking with the rocSHMEM QueuePair bitcode for GDA support in RCCL GIN. ### RCCL - GIN GDA Since GIN GDA now requires access to the rocSHMEM QueuePair headers from within the installed device API headers, when RCCL is configured with support for GIN GDA (ENABLE_ROCSHMEM_GIN=ON) then the required headers are copied out of the rocSHMEM source directory into the RCCL build directory and thence to RCCL's installation prefix include directory. RCCL provides a subset of these headers as internal replacements instead of rocSHMEM's. ## JIRA ID JIRA ID: AIROCSHMEM-424 JIRA ID: AICOMRCCL-1457 ## Test Plan Use the rocSHMEM functional tests to validate correctness and performance regression analysis against current develop HEAD. Use the alltoall_perf GIN GDA implementation from rccl-tests to validate correctness for the GDA backend in RCCL GIN. ## Test Result - [x] Correctness: rocSHMEM functional tests - [x] ionic - [x] bnxt - [x] mlx5 - [x] Performance regression analysis - [x] ionic - [x] bnxt - [x] mlx5 - [x] Correctness: RCCL GIN rccl-tests/alltoall_perf ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Signed-off-by: Omri Mor <Omri.Mor@amd.com>

PRs #10785 and #7217 accidentally reintroduced some __hip_atomic builtins. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

## Motivation The QueuePair class in src/gda/queue_pair.{hpp,cpp} operates as "three classes in a trenchcoat" that masquerade as a single class; it simultaneously has functionality for: - common device-side QP initialization and management, including host functions for registering additional local buffers; and - provider-specific send and completion queue management, including WQE posting and CQ polling; and - a multiplexing low-level interface that dispatches to the provider-specific functions based on which is at use at execution time; and - an intermediate-level interface that hides details such as opcodes, implemented on top of the low-level interface. Maintaining this complex class and its many interactions is complicated, has led to changes in one GDA provider causing unintended impacts on others, limits GDA provider performance, and hinders development of new features. This PR refactors the single QueuePair class into several distinct classes, which thereby improves code readability, maintainability, and modularity; allows for independent unit testing of QueuePair functionality; restores the ability to compile directly for specific GDA providers without runtime dispatch; and paves the way for the decoupling of the RCCL-GIN GDA backend from rocSHMEM. ## Technical Details ### rocSHMEM A class hierarchy is implemented using CRTP: - rocshmem::QueuePairInterface<typename Provider> A common mid-level interface used directly by GIN GDA and indirectly by rocSHMEM, via the high-level interface. - rocshmem::QueuePairSHMEM<typename Provider> : QueuePairInterface<Provider> A common high-level interface that is used directly by rocshmem::GDAContext. - rocshmem::QueuePairDevice<typename Provider> : QueuePairSHMEM<Provider> A common base class for concrete GDA provider QueuePair types. - rocshmem::QueuePairTraits<typename Provider> Used by the CRTP base classes to query provider-specific attributes. - rocshmem::QueuePairHost Used to manage the lifetime of memory used by QueuePairDevice instances. These are used to implement the concrete GDA provider QueuePair classes: - rocshmem::QueuePairIONIC GDA provider for AMD Pensando RDMA networks using the 'ionic' driver. - rocshmem::QueuePairBNXT GDA provider for Broadcom RDMA networks using the 'bnxt' driver. - rocshmem::QueuePairMLX5 GDA provider for Mellanox RDMA networks using the 'mlx5' driver. There are two additional 'meta' provider QueuePair classes: - rocshmem::QueuePairMux Supports runtime GDA provider selection via a specialized tagged union. - rocshmem::QueuePairMock Mock QueuePair object for unit tests. A compile-time mechanism allows callers of the QueuePair communication APIs to selectively override certain internal safety and consistency mechanisms. All QueuePair device code is header-only; this removes the necessity of linking with the rocSHMEM QueuePair bitcode for GDA support in RCCL GIN. ### RCCL - GIN GDA Since GIN GDA now requires access to the rocSHMEM QueuePair headers from within the installed device API headers, when RCCL is configured with support for GIN GDA (ENABLE_ROCSHMEM_GIN=ON) then the required headers are copied out of the rocSHMEM source directory into the RCCL build directory and thence to RCCL's installation prefix include directory. RCCL provides a subset of these headers as internal replacements instead of rocSHMEM's. ## JIRA ID JIRA ID: AIROCSHMEM-424 JIRA ID: AICOMRCCL-1457 ## Test Plan Use the rocSHMEM functional tests to validate correctness and performance regression analysis against current develop HEAD. Use the alltoall_perf GIN GDA implementation from rccl-tests to validate correctness for the GDA backend in RCCL GIN. ## Test Result - [x] Correctness: rocSHMEM functional tests - [x] ionic - [x] bnxt - [x] mlx5 - [x] Performance regression analysis - [x] ionic - [x] bnxt - [x] mlx5 - [x] Correctness: RCCL GIN rccl-tests/alltoall_perf ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Signed-off-by: Omri Mor <Omri.Mor@amd.com>

PRs #10785 and #7217 accidentally reintroduced some __hip_atomic builtins. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

github-actions Bot added the project: rocshmem label Jun 13, 2026

systems-assistant Bot added the organization: ROCm label Jun 13, 2026

omor1 force-pushed the users/omor1/rocshmem/refactor_gda_qp branch from 5172b65 to 795eb8d Compare June 13, 2026 03:48

omor1 mentioned this pull request Jun 16, 2026

[rocshmem] gda/mlx5: skip get_lkey() for inline RMA sends #7294

Closed

1 task

omor1 force-pushed the users/omor1/rocshmem/refactor_gda_qp branch 2 times, most recently from 62b6284 to b5c1293 Compare June 30, 2026 00:36

therock-pr-bot Bot added the Not ready to Review label Jun 30, 2026

omor1 removed the Not ready to Review label Jun 30, 2026

omor1 marked this pull request as ready for review June 30, 2026 00:38

omor1 requested a review from a team as a code owner June 30, 2026 00:38

Copilot AI review requested due to automatic review settings June 30, 2026 00:38

Copilot started reviewing on behalf of omor1 June 30, 2026 00:39

View session

therock-pr-bot Bot added the Not ready to Review label Jun 30, 2026

Copilot AI reviewed Jun 30, 2026

View reviewed changes

omor1 changed the title ~~[rocshmem] gda: refactor QueuePair class~~ refactor(rocshmem/gda): refactor QueuePair class Jun 30, 2026

abouteiller reviewed Jul 6, 2026

View reviewed changes

omor1 mentioned this pull request Jul 7, 2026

Add SQTT marker support to rocSHMEM to improve device-level performance tracing #8176

Closed

1 task

omor1 force-pushed the users/omor1/rocshmem/refactor_gda_qp branch 3 times, most recently from 4ca9fab to 8ef949a Compare July 13, 2026 20:26

omor1 added 6 commits July 14, 2026 00:40

[rocshmem] gda: refactor QueuePairBNXT

962f65e

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

[rocshmem] gda: fix building w/multiple providers & w/o generic provider

6d2b8e1

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

[rocshmem] gda: fix invalid memory accesses from QueuePairBNXT refactor

148b526

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

[rocshmem] gda: QueuePairGeneric -> QueuePairMux, GDA_GENERIC -> GDA_MUX

3f8a04c

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

[rocshmem] gda: consistent enum order for ATOMIC_CS & ATOMIC_FA opcodes

c9bc963

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

amd-argus Bot reviewed Sep 18, 2026

View reviewed changes

omor1 added 4 commits September 19, 2026 04:09

refactor(rocshmem): [gda] type trait for PostOpt defaults

2b442fe

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

fix(rocshmem): [gda] constrain PostOpt constructor

dc9a02e

A PostOpt object could be constructed with arbitrary types. It wouldn't do anything, but was semantically nonsense, so reject such arguments. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

refactor(rocshmem): [gda] consolidate generic QP init info

e1c4609

Signed-off-by: Omri Mor <Omri.Mor@amd.com> Reported-by: amd-argus in #7217 review

style(rocshmem): [gda] fix minor spacing issues

2e15c35

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

amd-argus Bot reviewed Sep 19, 2026

View reviewed changes

Kapil-Shyam-Pawar approved these changes Sep 21, 2026

View reviewed changes

omor1 requested review from a team and wenkaidu and removed request for wenkaidu September 21, 2026 20:17

Kapil-Shyam-Pawar approved these changes Sep 21, 2026

View reviewed changes

wenkaidu approved these changes Sep 22, 2026

View reviewed changes

omor1 added 4 commits September 22, 2026 22:34

chore(rocshmem): [gda] use updated license format in new files

ea43561

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

chore(rccl): [gin/gda] use updated license format in new files

8e3c26c

Signed-off-by: Omri Mor <Omri.Mor@amd.com>

Merge branch 'develop' into users/omor1/rocshmem/refactor_gda_qp

ff9360d

amd-argus Bot reviewed Sep 22, 2026

View reviewed changes

omor1 mentioned this pull request Sep 23, 2026

perf(rocshmem): [gda/mlx5] replace SQ lock with lockless posting algorithm #12087

Draft

1 task done

omor1 merged commit eb12af8 into develop Sep 24, 2026
132 of 146 checks passed

omor1 deleted the users/omor1/rocshmem/refactor_gda_qp branch September 24, 2026 01:03

omor1 mentioned this pull request Sep 24, 2026

fix(rocSHMEM): remove GPU memory fault in WaveFrontPrimitiveTest, #AIROCSHMEM-512 #11646

Closed

1 task done

omor1 added a commit that referenced this pull request Sep 24, 2026

fix(rccl): replace remaining __hip_atomic builtins with __scoped_atomic

723dcfa

PRs #10785 and #7217 accidentally reintroduced some __hip_atomic builtins. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

amirsojoodi pushed a commit that referenced this pull request Sep 25, 2026

fix(rccl): replace remaining __hip_atomic builtins with __scoped_atomic

61abe59

PRs #10785 and #7217 accidentally reintroduced some __hip_atomic builtins. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

omor1 added a commit that referenced this pull request Sep 28, 2026

fix(rccl): replace remaining __hip_atomic builtins with __scoped_atomic

16a606c

PRs #10785 and #7217 accidentally reintroduced some __hip_atomic builtins. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

omor1 added a commit that referenced this pull request Sep 29, 2026

fix(rccl): replace remaining __hip_atomic builtins with __scoped_atomic

9aa69bc

PRs #10785 and #7217 accidentally reintroduced some __hip_atomic builtins. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

omor1 added a commit that referenced this pull request Oct 5, 2026

fix(rccl): replace remaining __hip_atomic builtins with __scoped_atomic

284a3de

PRs #10785 and #7217 accidentally reintroduced some __hip_atomic builtins. Signed-off-by: Omri Mor <Omri.Mor@amd.com>

Conversation

omor1 commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

JIRA ID

Test Plan

Test Result

Submission Checklist

Uh oh!

omor1 commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omor1 commented Jun 24, 2026

Uh oh!

therock-pr-bot Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Policy Checks Passed

Uh oh!

therock-pr-bot Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abouteiller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amd-argus Bot left a comment

Choose a reason for hiding this comment

Uh oh!

amd-argus Bot left a comment

Choose a reason for hiding this comment

Uh oh!

omor1 commented Sep 20, 2026

Uh oh!

amd-argus Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

systems-assistant Bot commented Sep 25, 2026

TheRock Submodule Bump Activity

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

omor1 commented Jun 13, 2026 •

edited

Loading

omor1 commented Jun 13, 2026 •

edited

Loading

therock-pr-bot Bot commented Jun 30, 2026 •

edited

Loading

therock-pr-bot Bot commented Jun 30, 2026 •

edited

Loading