Repository navigation
Users/rrawther/rocdecode: Update api comments for rocdecDecode sample - #6076
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates comments in the rocdecDecode sample to better describe the intent of a few hard-coded defaults and the purpose of helper functions, improving readability for users of the sample.
Changes:
- Clarified the rationale for
DEFAULT_WIDTH/DEFAULT_HEIGHTbeing used during initial decoder creation. - Added/updated helper function comments for chroma factor helpers and codec-type mapping.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
AryanSalmanpour
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some of the comments were not correct
Technical Details
Will be more clear for the user
JIRA ID
Test Plan
CTest should pass
Test Result
Test project /home/rajy/work/rocm-systems/projects/rocdecode/build
Start 1: video_decodeRaw-HEVC
1/6 Test #1: video_decodeRaw-HEVC ............. Passed 2.67 sec
Start 2: video_decodeRaw-AVC
2/6 Test #2: video_decodeRaw-AVC .............. Passed 1.68 sec
Start 3: video_decodeRaw-AV1
3/6 Test #3: video_decodeRaw-AV1 .............. Passed 1.77 sec
Start 4: video_decodeRaw-VP9
4/6 Test #4: video_decodeRaw-VP9 .............. Passed 1.82 sec
Start 5: rocdec_Decode-HEVC
5/6 Test #5: rocdec_Decode-HEVC ............... Passed 0.72 sec
Start 6: rocDecode_Negative_API_Tests
6/6 Test #6: rocDecode_Negative_API_Tests ..... Passed 0.53 sec
100% tests passed, 0 tests failed out of 6
Submission Checklist