Repository navigation
[rocjitsu] 2 small testing improvements after PR #5512 - #5609
Merged
Merged
Conversation
Contributor
Author
With only changes to the tests, nope! But I did just quickly verify that. :-P |
accauble
force-pushed
the
users/accauble/rj-minor-5512-improvements
branch
4 times, most recently
from
April 30, 2026 20:37
3632810 to
b5b1c47
Compare
* Added tests to make sure that if there is a refactor of the
cmpx_writes_vcc function (for instance returns false if the
instruction writes to scalar SGPR pair instead of VCC) that
the refactor doesn't siliently generate the wrong code.
* Made a minor fix to `test_v_cmpx_instructions_cannot_share_execute`
in `test_cross_isa_analyzer.py` which was passing the encoding
to `_can_share_execute`. This was changed in PR #5512
accauble
force-pushed
the
users/accauble/rj-minor-5512-improvements
branch
from
April 30, 2026 23:27
b5b1c47 to
7021d7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
[rocjitsu] Two small nit picks from PR #5512:
test_v_cmpx_instructions_cannot_share_executeintest_cross_isa_analyzer.pywhich was passing the encoding to_can_share_execute. This was changed in PR rocjitsu: Harden ISA layer, virtual machine, and adds initial DBT #5512JIRA ID
None
Test Result
Tests pass!
Submission Checklist