Repository navigation
SWDEV-541066-[catch2][dtest]-Create stream capture test for multiple stream with cross dependencies. - #555
Closed
systems-assistant[bot] wants to merge 5 commits into
Closed
SWDEV-541066-[catch2][dtest]-Create stream capture test for multiple stream with cross dependencies.#555systems-assistant[bot] wants to merge 5 commits into
systems-assistant[bot] wants to merge 5 commits into
Conversation
…stream with cross dependencies.
…evelop/ROCm_hip-tests/pr-523
jharryma
pushed a commit
that referenced
this pull request
Sep 12, 2025
…d-comgr. (#555) * remove samples dependency on rocprofiler-sdk-amd-comgr. * add find package for amd_comgr. --------- Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Contributor
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
2 tasks
1 task
dgaliffiAMD
pushed a commit
that referenced
this pull request
Aug 11, 2026
…eration failure (#9044) ## Motivation `ROCPROFSYS_MAX_THREADS` is a compile time constant that is the core of the `thread-limit` tests. For this test to work on TheRock, we need a way to get the compile time value at runtime and run the test with it. The idea here is to store it within `rocprof-sys-avail`, then read it and run the test against that value. ## Technical Details **Regarding thread-limit** - Store `ROCPROFSYS_MAX_THREADS` in `rocprof-sys-avail`. Accessed using `rocprof-sys-avail --max-threads`. - Make` test_categories.yaml` copied to build folder during build time, not configure time. - Gate per thread finalization logs on `ROCPROFSYS_VERBOSE>0` or in causal mode. - This gets rid of some of the many logs that would be seen during this test. I will be leaving the messages that say: `[SIG27] Sampler for thread <N> will be triggered 250.0x per second of CPU-time (every 4.000e+00 milliseconds)... ` **Regarding silent failure**: - CTest generation step has been silently failing on TheRock regarding thread-limit test as the `pytest.exit(0)` would mask any error during generation. To fix this, we detect any collection errors and report them, failing the build. - Moved `get_thread_limit()` into the `test` definition itself. Evaluating it during build (during CTesttestfile.cmake generation step) would cause a failure in TheRock CI. ## Issue Tracking Jira ID: AIPROFSYST-523 Jira ID: AIPROFSYST-656 Jira ID: ROCM-29285 ## Test Plan Examining TheRock CI workflow to see that the test ran and passed. ## Test Result Ongoing. Test passes in TheRock CI: https://github.com/ROCm/rocm-systems/actions/runs/30031596021/job/89312443869?pr=9044 ``` Start 546: thread-limit-half-sampling 420/498 Test #546: thread-limit-half-sampling ...................................................................................................................................................... Passed 4.60 sec Start 547: thread-limit-half-binary-rewrite 421/498 Test #547: thread-limit-half-binary-rewrite ................................................................................................................................................ Passed 5.49 sec Start 548: thread-limit-half-runtime-instrument 422/498 Test #548: thread-limit-half-runtime-instrument ............................................................................................................................................ Passed 7.47 sec Start 549: thread-limit-half-sys-run 423/498 Test #549: thread-limit-half-sys-run ....................................................................................................................................................... Passed 4.63 sec Start 550: thread-limit-at-limit-sampling 424/498 Test #550: thread-limit-at-limit-sampling .................................................................................................................................................. Passed 7.57 sec Start 551: thread-limit-at-limit-binary-rewrite 425/498 Test #551: thread-limit-at-limit-binary-rewrite ............................................................................................................................................ Passed 8.40 sec Start 552: thread-limit-at-limit-runtime-instrument 426/498 Test #552: thread-limit-at-limit-runtime-instrument ........................................................................................................................................ Passed 11.47 sec Start 553: thread-limit-at-limit-sys-run 427/498 Test #553: thread-limit-at-limit-sys-run ................................................................................................................................................... Passed 7.76 sec Start 554: thread-limit-exhausted-sampling 428/498 Test #554: thread-limit-exhausted-sampling ................................................................................................................................................. Passed 8.72 sec Start 555: thread-limit-exhausted-binary-rewrite 429/498 Test #555: thread-limit-exhausted-binary-rewrite ........................................................................................................................................... Passed 9.85 sec Start 556: thread-limit-exhausted-runtime-instrument 430/498 Test #556: thread-limit-exhausted-runtime-instrument ....................................................................................................................................... Passed 12.59 sec Start 557: thread-limit-exhausted-sys-run 431/498 Test #557: thread-limit-exhausted-sys-run .................................................................................................................................................. Passed 8.47 sec ``` ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
SWDEV-541066
What type of PR is this? (check all applicable)
What were the changes?
Stream capture tests for the following scenarios.
Why are these changes needed?
To increase the coverage of tests with stream capture apis.
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks
🔁 Imported from ROCm/hip-tests#523
🧑💻 Originally authored by @rocm-devops