Repository navigation
fix(rocinsight): pass ATT data through to_json()/to_webview() for Tier 3 serialization - #4978
Merged
ammarwa merged 1 commit intoApr 17, 2026
Conversation
github-actions
Bot
added
the
documentation
ammarwa
force-pushed
the
review-findings/f4-att-serialization
branch
3 times, most recently
from
April 13, 2026 19:31
db67acb to
674faf3
Compare
ammarwa
force-pushed
the
review-findings/f4-att-serialization
branch
from
April 13, 2026 20:38
674faf3 to
17e53b6
Compare
ammarwa
changed the base branch from
develop
to
rocm21553/pr4-fix-tool-commands
April 13, 2026 20:41
ammarwa
force-pushed
the
rocm21553/pr4-fix-tool-commands
branch
from
April 13, 2026 20:48
2beb62b to
d2cd4dd
Compare
ammarwa
force-pushed
the
review-findings/f4-att-serialization
branch
from
April 13, 2026 20:49
17e53b6 to
1bef8a5
Compare
ammarwa
marked this pull request as ready for review
April 13, 2026 20:54
ammarwa
force-pushed
the
rocm21553/pr4-fix-tool-commands
branch
from
April 13, 2026 21:02
d2cd4dd to
d67b1fb
Compare
ammarwa
force-pushed
the
review-findings/f4-att-serialization
branch
from
April 13, 2026 21:02
1bef8a5 to
b5edfad
Compare
ammarwa
force-pushed
the
rocm21553/pr4-fix-tool-commands
branch
from
April 13, 2026 21:11
d67b1fb to
f9a82b1
Compare
ammarwa
force-pushed
the
review-findings/f4-att-serialization
branch
2 times, most recently
from
April 13, 2026 21:17
ef9ffef to
4206e9a
Compare
ammarwa
force-pushed
the
rocm21553/pr4-fix-tool-commands
branch
from
April 14, 2026 00:14
f9a82b1 to
e0ac9a3
Compare
…alization Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ammarwa
force-pushed
the
review-findings/f4-att-serialization
branch
from
April 14, 2026 00:16
4206e9a to
b5f4898
Compare
bwelton
approved these changes
Apr 14, 2026
ammarwa
merged commit Apr 17, 2026
3dc7740
into
ROCm:rocm21553/pr4-fix-tool-commands
20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_json()andto_webview()onAnalysisResultdid not forwardatt_analysistoformat_analysis_output(), causing Tier 3 ATT results to be silently dropped from serialized output despiteanalysis_tier=3.Test plan
analyze_database(att_dir=...)→to_json()→ att_trace present🤖 Generated with Claude Code
Stacking note
This PR is based on the ROCM-21553 feature stack (#4968-#4972). Its own change is only:
ai_analysis/api.py(2 lines addingatt_analysisparam) +test_att_serialization.py(4 tests).Merge after #4972 lands, then rebase onto develop for a clean diff.