Skip to content

Windows: Use is_versioned = true consistently in both Comgr::LoadLib paths. #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
systems-assistant wants to merge 2 commits into from
Closed

Windows: Use is_versioned = true consistently in both Comgr::LoadLib paths. #493

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af1fd63
Use is_versioned = true consistently in both Comgr::LoadLib paths.
stellaraccident May 15, 2025
a4ee646
Merge commit 'af1fd63823e26628670d434f055bf3cd445a8071' into import/d…
systems-assistant[bot] Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/clr/rocclr/device/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ bool Device::ValidateComgr() {
#if defined(USE_COMGR_LIBRARY)
// Check if Lightning compiler was requested
if (settings_->useLightning_) {
constexpr bool kComgrVersioned = false;
constexpr bool kComgrVersioned = true;
std::call_once(amd::Comgr::initialized, amd::Comgr::LoadLib, kComgrVersioned);
// Use Lightning only if it's available
settings_->useLightning_ = amd::Comgr::IsReady();
Expand Down