Format source code to PEP8 using Ruff by systems-assistant[bot] · Pull Request #36 · ROCm/rocm-systems

systems-assistant · 2025-08-06T18:17:34Z

Changed rocprof pre-commit hooks to use ruff instead of isort and black. Additional manual changes to current rocprof python files to match PEP8 format.

fix: Correct syntax error in multi-line f-string

Addresses a syntax error in src/rocprof_compute_tui/views/main_view.py
that was introduced during a manual code formatting pass.

Ruff correctly identified a line as being too long but was unable to
apply an automatic fix. The subsequent manual edit incorrectly
added a newline character inside an f-string, causing the error.

The issue was an isolated manual error and not a
systemic problem with the new ruff/black formatting setup.

Relates to #315

🔁 Imported from ROCm/rocprofiler-compute#713
🧑‍💻 Originally authored by @jamessiddeley-amd

…into jsiddele/pre-commit-hooks UPDATE FORK FROM LATEST DEVELOP

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

…evelop/jamessiddeley-amd_rocprofiler-compute/jsiddele_pre-commit-hooks

vedithal-amd

LGTM

feizheng10 · 2025-08-06T19:46:36Z

-)
-'''
+[tool.ruff]
+target-version="py38"


I'd say we should remove the target-version

feizheng10 · 2025-08-06T23:19:36Z

I recall we had conversion something like adding guidance in readme:
There should be a chapter for contribution guide lines: how to install and run ruff before submit PR. And also mention that how to disable formatting code with unwanted sections.

feizheng10

LGTM with minor comments.
Please run the whole test suites locally to make sure all tests passed.

jamessiddeley-amd · 2025-08-07T17:17:46Z

LGTM with minor comments. Please run the whole test suites locally to make sure all tests passed.

Just ran on latest dev:

Test project /app/build
      Start  1: test_profile_kernel_execution
 1/16 Test  #1: test_profile_kernel_execution ....   Passed   46.11 sec
      Start  2: test_profile_dispatch
 2/16 Test  #2: test_profile_dispatch ............   Passed  131.29 sec
      Start  3: test_profile_mem
 3/16 Test  #3: test_profile_mem .................   Passed  175.43 sec
      Start  4: test_profile_join
 4/16 Test  #4: test_profile_join ................   Passed   88.03 sec
      Start  5: test_profile_sort
 5/16 Test  #5: test_profile_sort ................   Passed  174.83 sec
      Start  6: test_profile_misc
 6/16 Test  #6: test_profile_misc ................   Passed  1105.42 sec
      Start  7: test_profile_section
 7/16 Test  #7: test_profile_section .............   Passed   56.17 sec
      Start  8: test_profile_sets_func
 8/16 Test  #8: test_profile_sets_func ...........   Passed   32.65 sec
      Start  9: test_analyze_commands
 9/16 Test  #9: test_analyze_commands ............   Passed  462.41 sec
      Start 10: test_analyze_workloads
10/16 Test #10: test_analyze_workloads ...........   Passed  709.25 sec
      Start 11: test_L1_cache_counters
11/16 Test #11: test_L1_cache_counters ...........   Passed   67.96 sec
      Start 12: test_num_xcds_spec_class
12/16 Test #12: test_num_xcds_spec_class .........   Passed    3.97 sec
      Start 13: test_num_xcds_cli_output
13/16 Test #13: test_num_xcds_cli_output .........   Passed    4.78 sec
      Start 14: test_db_connector
14/16 Test #14: test_db_connector ................   Passed    2.37 sec
      Start 15: test_utils
15/16 Test #15: test_utils .......................   Passed   11.52 sec
      Start 16: test_autogen_config
16/16 Test #16: test_autogen_config ..............   Passed    2.19 sec

100% tests passed, 0 tests failed out of 16

Label Time Summary:
profile    = 1721.10 sec*proc (6 tests)

Total Test time (real) = 3074.38 sec

* Adding tool pc sampling support Fixing merge issue tool support on SDKupdates link amd-comgr Sanitizer failure fix fix format Addressing review comments misc fix Adding dispatch id to the CSV output AddingCHANGELOG [ROCProfV3][PC Sampling] Initial ROCProfV3 PC sampling tests for JSON and CSV formats (#17) ROCProfV3 initial tests for JSON and CSV output. Simple kernels that simplify the verification of samples to instruction decoding has been introduced. removing option to enable pc sampling explicitly Adding documentation no pc-sampling option in tests anymore Addressing review comments Updating docs an option for choosing whether all units must be sampled try ignoring PC sampling tests (#36) * run pc-sampling tests on MI2xx runners * use v_fmac_f32 instead of s_nop 0 in tests * fixing docs [ROCm/rocprofiler-sdk commit: 50b185b]

…ler-compute/jsiddele_pre-commit-hooks

* added ruff docs * style: Run ruff and black before yapf pass * yapf -r -i (23 fixes) * fixed conf.py and ran ruff format . * fixed conf.py 2 * formatted argparser.py * formatted src/rocprof_compute_analyze * formatted src/rocprof_compute_profile * formatted soc_base.py * formatted rocprof_compute_tui * formatted gui_components * formatted src/utils * formatted tests/ * format extra files * cleanup * fix test_utils.py * fixed typos * Update pyproject.toml * Update README.md * Update test_utils.py [rocm-systems] ROCm/rocm-systems#36 (commit 58d2a01)

jamessiddeley-amd · 2025-08-12T16:34:07Z

fix: Correct syntax error in multi-line f-string

Addresses a syntax error in src/rocprof_compute_tui/views/main_view.py
that was introduced during a manual code formatting pass.

Ruff correctly identified a line as being too long but was unable to
apply an automatic fix. The subsequent manual edit incorrectly
added a newline character inside an f-string, causing the error.

The issue was an isolated manual error and not a
systemic problem with the new ruff/black formatting setup.

Relates to #315

#36) SWDEV-546293 - Adds nvidia mappings to hipMemPrefetchAsync_vs and hipMemAdvise_v2

[ROCm/hip commit: 520bbad]

#36) SWDEV-546293 - Adds nvidia mappings to hipMemPrefetchAsync_vs and hipMemAdvise_v2 [ROCm/hipother commit: bf0302a]

Add cooperative groups for sync collective

…m-sync Fix `rocshmem_ctx_wg_team_sync` API

Add cooperative groups for sync collective [ROCm/rocshmem commit: 8015a45]

…m-sync Fix `rocshmem_ctx_wg_team_sync` API [ROCm/rocshmem commit: d97e5ba]

As things get more complicated, the install instructions will become too complicated to fit in README.md. This also seems to be where TheRock components seems to put their install instructions.

As things get more complicated, the install instructions will become too complicated to fit in README.md. This also seems to be where TheRock components seems to put their install instructions. [ROCm/hipFile commit: 5c97904]

jamessiddeley-amd and others added 20 commits July 30, 2025 14:28

added ruff docs

e8875b1

Merge branch 'develop' of https://github.com/ROCm/rocprofiler-compute …

fe19ca5

…into jsiddele/pre-commit-hooks UPDATE FORK FROM LATEST DEVELOP

style: Run ruff and black before yapf pass

239b4bc

yapf -r -i (23 fixes)

57e8197

fixed conf.py and ran ruff format .

0f22f34

fixed conf.py 2

ff6036f

formatted argparser.py

2548479

formatted src/rocprof_compute_analyze

5f167a5

formatted src/rocprof_compute_profile

9e5c962

formatted soc_base.py

ddfc621

formatted rocprof_compute_tui

5d26c7b

formatted gui_components

26a6f84

formatted src/utils

285773b

formatted tests/

c248a0f

format extra files

7521827

cleanup

d01f9c3

fix test_utils.py

86646b8

fixed typos

8121515

Merge branch 'develop' into jsiddele/pre-commit-hooks

e5d7ec6

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

Merge commit 'e5d7ec6bd686446c6cff297c00bc5f6e817c21e7' into import/d…

b8b7e09

…evelop/jamessiddeley-amd_rocprofiler-compute/jsiddele_pre-commit-hooks

systems-assistant Bot added the imported pr label Aug 6, 2025

systems-assistant Bot requested review from cfallows-amd, coleramos425, feizheng10, jamessiddeley-amd, vedithal-amd, xuchen-amd and ywang103-amd as code owners August 6, 2025 18:17

systems-assistant Bot added the project: rocprofiler-compute label Aug 6, 2025

vedithal-amd approved these changes Aug 6, 2025

View reviewed changes

jayhawk-commits assigned jamessiddeley-amd Aug 6, 2025

jayhawk-commits added the organization: ROCm label Aug 6, 2025

feizheng10 reviewed Aug 6, 2025

View reviewed changes

feizheng10 approved these changes Aug 6, 2025

View reviewed changes

jamessiddeley-amd added 4 commits August 8, 2025 10:37

Update pyproject.toml

528bf7b

Update README.md

7a7b743

Update test_utils.py

048546d

Merge branch 'develop' into import/develop/jamessiddeley-amd_rocprofi…

6884bb9

…ler-compute/jsiddele_pre-commit-hooks

jamessiddeley-amd merged commit 58d2a01 into develop Aug 8, 2025

jamessiddeley-amd deleted the import/develop/jamessiddeley-amd_rocprofiler-compute/jsiddele_pre-commit-hooks branch August 8, 2025 19:32

systems-assistant Bot pushed a commit that referenced this pull request Aug 10, 2025

SWDEV-461087 - add OCP types to HIP (#36)

520bbad

xuchen-amd mentioned this pull request Aug 12, 2025

[rocprofiler-compute][TUI]Fix fstring formatting. #315

Merged

1 task done

jayhawk-commits pushed a commit that referenced this pull request Aug 18, 2025

SWDEV-546293 - Adds nvidia mappings to hipMemPrefetchAsync_vs and hip… (

bf0302a

#36) SWDEV-546293 - Adds nvidia mappings to hipMemPrefetchAsync_vs and hipMemAdvise_v2

jayhawk-commits pushed a commit that referenced this pull request Aug 18, 2025

SWDEV-461087 - add OCP types to HIP (#36)

35a0bd1

[ROCm/hip commit: 520bbad]

jayhawk-commits pushed a commit that referenced this pull request Aug 18, 2025

SWDEV-546293 - Adds nvidia mappings to hipMemPrefetchAsync_vs and hip… (

b5ca920

#36) SWDEV-546293 - Adds nvidia mappings to hipMemPrefetchAsync_vs and hipMemAdvise_v2 [ROCm/hipother commit: bf0302a]

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Merge pull request #36 from Yiltan/LWPRHMEM-71-add-coop-groups

8015a45

Add cooperative groups for sync collective

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Merge pull request #36 from avinashkethineedi/fix/rocshmem-ctx-wg-tea…

d97e5ba

…m-sync Fix `rocshmem_ctx_wg_team_sync` API

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Merge pull request #36 from Yiltan/LWPRHMEM-71-add-coop-groups

9eb928d

Add cooperative groups for sync collective [ROCm/rocshmem commit: 8015a45]

ammallya pushed a commit that referenced this pull request Jan 21, 2026

Merge pull request #36 from avinashkethineedi/fix/rocshmem-ctx-wg-tea…

4d919fa

…m-sync Fix `rocshmem_ctx_wg_team_sync` API [ROCm/rocshmem commit: d97e5ba]

Navigation Menu

Repository navigation

Format source code to PEP8 using Ruff - #36

Format source code to PEP8 using Ruff#36
jamessiddeley-amd merged 24 commits into
developfrom
import/develop/jamessiddeley-amd_rocprofiler-compute/jsiddele_pre-commit-hooks

systems-assistant Bot commented Aug 6, 2025 •

edited by jamessiddeley-amd

Loading

Uh oh!

vedithal-amd left a comment

Uh oh!

feizheng10 Aug 6, 2025

Uh oh!

feizheng10 commented Aug 6, 2025 •

edited

Loading

Uh oh!

feizheng10 left a comment

Uh oh!

jamessiddeley-amd commented Aug 7, 2025

Uh oh!

jamessiddeley-amd commented Aug 12, 2025 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

systems-assistant Bot commented Aug 6, 2025 • edited by jamessiddeley-amd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changed rocprof pre-commit hooks to use ruff instead of isort and black. Additional manual changes to current rocprof python files to match PEP8 format.

Relates to #315

Uh oh!

vedithal-amd left a comment

Choose a reason for hiding this comment

Uh oh!

feizheng10 Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

feizheng10 commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feizheng10 left a comment

Choose a reason for hiding this comment

Uh oh!

jamessiddeley-amd commented Aug 7, 2025

Uh oh!

jamessiddeley-amd commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

systems-assistant Bot commented Aug 6, 2025 •

edited by jamessiddeley-amd

Loading

feizheng10 commented Aug 6, 2025 •

edited

Loading

jamessiddeley-amd commented Aug 12, 2025 •

edited

Loading