Skip to content

Fix use-after-free in Runtime::DestroyAgents() cleanup ordering #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeniferC99 merged 2 commits into from
Feb 26, 2026
+5 −4
Merged

Fix use-after-free in Runtime::DestroyAgents() cleanup ordering #3240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a9237d
rocr: Fix ASan's use-after-free error: move system region cleanup to …
ShwetakAMD Feb 12, 2026
ceb8ed5
Merge branch 'develop' into users/shwetak/fix-destroy-agents-use-afte…
JeniferC99 Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions projects/rocr-runtime/runtime/hsa-runtime/core/runtime/runtime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ void Runtime::RegisterDriver(std::unique_ptr<Driver> driver) {

void Runtime::DestroyAgents() {
agents_by_node_.clear();

std::for_each(gpu_agents_.begin(), gpu_agents_.end(), DeleteObject());
gpu_agents_.clear();

Expand All @@ -271,9 +270,6 @@ void Runtime::DestroyAgents() {
aie_agents_.clear();

region_gpu_ = NULL;

system_regions_fine_.clear();
system_regions_coarse_.clear();
}

void Runtime::DestroyDrivers() {
Expand Down Expand Up @@ -2486,6 +2482,11 @@ void Runtime::Unload() {
SharedSignalPool.clear();
EventPool.clear();

// Clear system regions before destroying agents to prevent use-after-free
// when agent destructors access region memory.
system_regions_fine_.clear();
system_regions_coarse_.clear();

DestroyAgents();

CloseTools();
Expand Down