Repository navigation
Fix for thread limit tests - #323
Merged
Merged
Conversation
anujshuk-amd
requested changes
Aug 13, 2025
anujshuk-amd
left a comment
anujshuk-amd
left a comment
Contributor
There was a problem hiding this comment.
SAMPLING_TIMEOUT
240
REWRITE_TIMEOUT
240
RUNTIME_TIMEOUT
360
anujshuk-amd
approved these changes
Aug 13, 2025
anujshuk-amd
left a comment
anujshuk-amd
left a comment
Contributor
There was a problem hiding this comment.
Updated suggested changes directly to the CmakeLists.txt
Contributor
Author
|
Can we catch this at runtime and fail more gracefully? I'm okay with unblocking the workflow but a user can still write an application with 4097 threads and hit this same failure. |
cfallows-amd
pushed a commit
that referenced
this pull request
Aug 18, 2025
…#323) * SWDEV-532868 - Disable implicit wait in hipFree for async allocations * Fix compilation error
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
[ROCm/hip commit: 564ed55]
dgaliffiAMD
force-pushed
the
users/anujshuk/thread-limit-test
branch
from
August 27, 2025 21:26
5dbf1b2 to
29da146
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes thread limit tests that were failing due to exceeding allowed thread counts by implementing a maximum thread limit of 4096 and updating the test infrastructure to properly handle various thread count scenarios.
- Updates CMake test configuration to loop through multiple thread values and properly handle cases above the limit
- Adds runtime enforcement of the 4096 thread limit in the pthread creation wrapper
- Replaces single hardcoded test with parameterized tests for better coverage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/rocprofiler-systems/tests/source/CMakeLists.txt | Refactors thread limit tests to use multiple test values and proper limit handling |
| projects/rocprofiler-systems/source/lib/rocprof-sys/library/components/pthread_create_gotcha.cpp | Adds thread limit enforcement and early return when max threads exceeded |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…mber of threads allowed. Signed-off-by: Anuj-Kumar Shukla <AnujKumar.Shukla@amd.com>
dgaliffiAMD
force-pushed
the
users/anujshuk/thread-limit-test
branch
from
October 3, 2025 20:27
4eb41be to
28b87e3
Compare
Contributor
Author
|
Rebasing branch |
dgaliffiAMD
commented
Oct 3, 2025
Contributor
Author
|
@anujshuk-amd, looks good to me. Do you really need to increase the timeout values? It looks like there is plenty of time remaining on our runners. |
1 task
dgaliffiAMD
commented
Oct 6, 2025
systems-assistant Bot
pushed a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Oct 9, 2025
* Fix for thread limit tests. Which are failing due to exceeding the number of threads allowed. Signed-off-by: Anuj-Kumar Shukla <AnujKumar.Shukla@amd.com> * Update CMakeLists.txt * Stopping thread creation after max thread limit * Adressed review comments * Update projects/rocprofiler-systems/tests/source/CMakeLists.txt [rocm-systems] ROCm/rocm-systems#323 (commit 182a750)
ammallya
pushed a commit
that referenced
this pull request
Nov 17, 2025
* Update to remove vram enum and instead use the string directly from the driver. Signed-off-by: Narlo, Joseph <Joseph.Narlo@amd.com> Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Nov 18, 2025
* Update to remove vram enum and instead use the string directly from the driver. Signed-off-by: Narlo, Joseph <Joseph.Narlo@amd.com> Signed-off-by: Maisam Arif <Maisam.Arif@amd.com> [ROCm/amdsmi commit: f71ae88]
ammallya
pushed a commit
that referenced
this pull request
Nov 21, 2025
* Update to remove vram enum and instead use the string directly from the driver. Signed-off-by: Narlo, Joseph <Joseph.Narlo@amd.com> Signed-off-by: Maisam Arif <Maisam.Arif@amd.com> [ROCm/amdsmi commit: f71ae88]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported PR from ROCm/rocprofiler-systems#312
rocprofiler-systems Pull Request
Related Issue
What type of PR is this? (check all that apply)
Technical Details
Have you added or updated tests to validate functionality?
Added / Updated documentation?
Have you updated CHANGELOG?