Skip to content

[rocprofiler-compute] Test env. vars. in rocprofiler-sdk backend #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jharryma merged 2 commits into from
Dec 23, 2025
Merged

[rocprofiler-compute] Test env. vars. in rocprofiler-sdk backend #2414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bf7cdd
Test env. vars. in rocprofiler-sdk backend
vedithal-amd Dec 19, 2025
5963f22
Remove redundant code in tests
vedithal-amd Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions projects/rocprofiler-compute/src/utils/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1606,9 +1606,9 @@ def merge_stall_reasons(
pc_sample_instructions = search_key_in_json(file_name, "pc_sample_instructions")
df["instruction"] = (
df["inst_index"].apply(
lambda x: pc_sample_instructions[x]
if x < len(pc_sample_instructions)
else None
lambda x: (
pc_sample_instructions[x] if x < len(pc_sample_instructions) else None
)
)
if pc_sample_instructions
else None
Expand All @@ -1618,9 +1618,11 @@ def merge_stall_reasons(
pc_sample_comments = search_key_in_json(file_name, "pc_sample_comments")
df["source_line"] = (
df["inst_index"].apply(
lambda x: f".../{Path(pc_sample_comments[x]).name}"
if x < len(pc_sample_comments)
else None
lambda x: (
f".../{Path(pc_sample_comments[x]).name}"
if x < len(pc_sample_comments)
else None
)
)
if pc_sample_comments
else None
Expand Down
11 changes: 0 additions & 11 deletions projects/rocprofiler-compute/src/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,17 +776,6 @@ def run_prof(
f"ROCPROFILER_METRICS_PATH={new_env['ROCPROFILER_METRICS_PATH']}"
)

# set required env var for >= mi300
if mspec.gpu_model.lower() not in (
"mi50",
"mi60",
"mi100",
"mi210",
"mi250",
"mi250x",
):
new_env["ROCPROFILER_INDIVIDUAL_XCC_MODE"] = "1"

time_1 = time.time()

output_path = Path(workload_dir + "/out/pmc_1")
Expand Down
Loading
Loading